Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] allow synonyms and spaces in time shift intervals configuration #102405

Closed
ghudgins opened this issue Jun 16, 2021 · 5 comments · Fixed by #102709
Closed

[Lens] allow synonyms and spaces in time shift intervals configuration #102405

ghudgins opened this issue Jun 16, 2021 · 5 comments · Fixed by #102709
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@ghudgins
Copy link
Contributor

ghudgins commented Jun 16, 2021

Describe the feature:
During usability testing someone attempted 8 w and 8 wk as a shift interval. We should allow the spaces as a valid input if we are able. Would be nice to handle common synonyms and fully typed out intervals like mon month wk week day yr year qtr quarter. Might also be good to allow the plural on all fully spelled out variants months weeks days years quarters

Describe a specific use case for the feature:
A user entering a number can naturally enter a space between the number ("8") and the interval unit ("w") without thinking if it matches the time shift syntax which expects no space. we should remove spaces for them and allow this as a valid configuration

A user enters the full name of the interval (plus a space) like "8 weeks" and expects the "8w" shift

@ghudgins ghudgins added usability Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added enhancement New value added to drive a business result good first issue low hanging fruit and removed good first issue low hanging fruit labels Jun 17, 2021
@ghudgins ghudgins changed the title [Lens] allow spaces in time shift intervals [Lens] allow synonyms and spaces in time shift intervals configuration Jun 17, 2021
@ghudgins
Copy link
Contributor Author

@markov00 mentions i18n (can we use translatable intervals via moment or something) and considering the word "ago" in the dropdown (example: 1 week ago)

this concept overall is sometimes referred to as time stamp humanization

@flash1293
Copy link
Contributor

These are two separate things - the phrase 1 week ago in the dropdown is already translated. The underlying value is just 1w (and I don't think we should translate these as it will get very messy and I don't see a good reason for it - we also don't translate function names)

@markov00
Copy link
Member

@flash1293 you are right, we were talking about time and ended up talking about that humanize the timestamp in general.
I think we just mess up with the ideas in this ticket

@ghudgins
Copy link
Contributor Author

we aren't using the word ago in that dropdown. might be worth adding (since it'll get translated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants