-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Dynamic colouring with last value #101583
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
to me the best solution (and what i'd expect as a gentle user) is your first and third bullet: if the value in the cell is a single number it would work and, alternatively, if the value isn't numeric (you tried to color by value the last value of a string / array) that nothing would happen. So in the above case color by value wouldn't do anything since there are multiple values per row. However, last value could work if the aggregation returns a single number. @MichaelMarcialis might want to weigh in here too since this is regarding user expectations / experience. not sure how expensive of an ask that is.... |
Do you think a warning message is required in such cases? |
@dej611 not an easy task actually, but there are probably solutions.
To me, this could be a valid option. In this case, I think we should do something to visually render better the fact that the cell is a multi-value/array cell. An icon, a different way of representing the values instead of the comma separator or something else can probably be useful to understand this situation better. I have also another possible idea: why not expanding the rows for each field that contains an array? Something like a table denormalization? In this way each row actually represents a single value, we can correctly color-coding them, and we clearly represent a field array. |
That's a nice idea, @markov00 . I think we would need something like elastic/eui#4636 to do this, but I think it would a great follow-up. |
Created a PoC with some of the listed solutions : #101619
While this is nice I think it requires some upstream solution first. 😅
I think this is some kind of doable right now (maybe via |
after using the POC I think the skip is the best because we don't have to show an error (although we could). it's pretty clear why it's happening this way...hard to reason about the other color options...but maybe that's just me. |
Ok, I'll create a PR with the |
The current dynamic colouring feature for datatable is not correctly handling array values (using
Last value
operation).Every cells gets assigned the first color stop bucket:
I cannot see any "natural" solution here, other than pick an arbitrary route and make it clear to the user the actual logic for it.
Possible solutions (mentioned so far) are:
cc @ghudgins @flash1293 @markov00
The text was updated successfully, but these errors were encountered: