-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-indent rounds large numbers #101391
Comments
@elastic/es-ui Is console still in your domain as per CODEOWNERS? |
cc @elastic/elastic-ui it looks like we don't have a |
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@TinaHeiligers @tsullivan ES UI is now @elastic/kibana-stack-management 😄 And yes, we still maintain all Dev Tools including Console. I'm pretty sure |
Pings every ui engineer in the company... 😂 |
>> Number.isSafeInteger(-9223372036854775808)
false >> -9223372036854775808 === -9223372036854776000
true This is probably caused by the fact that the reindent script is parsing the JSON to perform the reindent, resulting on non-safe integer being truncated. Related to #40183 Note that Edited #40183 to reflect that. |
Note that this issue appears to occur now regardless if "auto indent" is used |
Pinging @elastic/kibana-management (Team:Kibana Management) |
Kibana version: 7.13.1 (newest), also observed on 7.12.0
Elasticsearch version: 7.13.1, or 7.12.0
Server OS version: Windows 10 (64-bit)
Browser version: Chrome (64-bit, newest)
Browser OS version: Windoes 10 (64-bit)
Original install method (e.g. download page, yum, from source, etc.): Download (from https://www.elastic.co/downloads/kibana)
Describe the bug:
Steps to reproduce:
Expected behavior:
I'd expect allignment, newlines and indentation to be fixed/modified, but my query to be otherwise identical
Actual baheviour
Indentation is modified, but large numbers are also rounded. This leads to different results.
Example:
When using pagination, the search_after parameter needs to be exactly copied. The query I originally wanted to execute:
was modified to this:
The two seem very alike. Yet the first one ran as expected, while the second one gave me an error, due to the now rounded number causing an overflow.
See also elastic/elasticsearch#73772, where I originally suspected something competely different
The text was updated successfully, but these errors were encountered: