Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Show warning when CCS searches omit data due to version mismatch #101130

Closed
jasonrhodes opened this issue Jun 2, 2021 · 4 comments
Closed
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jasonrhodes
Copy link
Member

See: #100876

When a cross-cluster search is extended to a cluster that doesn't support the "fields" API, ES will now return a warning so that we can let users know that some data that exists in older clusters may not be present in the current view.

AC:

  • Confirm that the warning is received from the ES query
  • Display some kind of notification to the user

@elastic/observability-design / @mukeshelastic we will need some guidance on what kind of warning we should display here, and how often

@jasonrhodes jasonrhodes added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort
Copy link
Member

💭 There are other situations as well in which the data might be incomplete:

  • Because we use async search queries might be in progress but already have partial results.
  • A request might have failure only in some shards but return data for other shards.

Maybe we can find a place in the UI to show these warnings/errors in addition to the partial results. I implemented something like this for the log entry fly-out where I render a call-out at the top when there are results and shard failures at the same time (#81710).

@jasonrhodes
Copy link
Member Author

Do the other scenarios you describe have known error messages so we can accurately determine when that scenario occurs? I think it's a great idea to collapse these things but the CCS search will result in a very specific message from ES, so I wonder if we should just "surface ES warnings" somehow, as a baseline.

@weltenwort
Copy link
Member

Yes, each ES error has a type property that we can check. An example can be found there:

const shardFailureSearchStrategyErrorRT = rt.type({
type: rt.literal('shardFailure'),
shardInfo: rt.type({
shard: rt.union([rt.number, rt.null]),
index: rt.union([rt.string, rt.null]),
node: rt.union([rt.string, rt.null]),
}),
message: rt.union([rt.string, rt.null]),
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

3 participants