Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to TLS certificate/key changes without requiring a restart #101072

Open
1 of 5 tasks
legrego opened this issue Jun 1, 2021 · 6 comments
Open
1 of 5 tasks

Respond to TLS certificate/key changes without requiring a restart #101072

legrego opened this issue Jun 1, 2021 · 6 comments
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Jun 1, 2021

Kibana maintains a number of different TLS configuration settings:

TLS certificates and keys are generally stored on disk, read once on startup, and used for the lifetime of the process. Changes to these files will not be picked up until Kibana is restarted.

Elasticsearch has long supported reloading this configuration from disk -- we should explore the feasibility of similar support within Kibana, so that we can accept updated certificates/keys without a restart.

Support for this would greatly simplify certificate rotation in managed environments such as ESS and ECE

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result labels Jun 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner
Copy link
Contributor

jportner commented Jun 1, 2021

Note for posterity:

Before I merged #53810 (in the 7.6 release), every time a certificate config value was read by a consumer, it was read off of the disk. So it was possible to change a certificate on the filesystem while Kibana was running, and get into a situation where some consumers were using the old cert, and some were using the new one. That PR included a change to read the cert off of disk when Kibana starts and keep the PEM file in memory.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 29, 2021
@legrego
Copy link
Member Author

legrego commented Mar 31, 2022

Closing in favor of #54368

@legrego legrego closed this as completed Mar 31, 2022
@pgayvallet
Copy link
Contributor

Reopening, as #171823 only fixed the first point (Reloading Kibana http certificates), and this issue was more broad than #54368

@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

Regarding reloading the Kibana<->ES certificates, proposal on how it could be done started here: #110082 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

4 participants