Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Render suggestions after main chart #100346

Closed
flash1293 opened this issue May 19, 2021 · 6 comments
Closed

[Lens] Render suggestions after main chart #100346

flash1293 opened this issue May 19, 2021 · 6 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Right now the main chart and the suggestions start rendering almost at the same time - this can cause a lot Elasticsearch load. By waiting for the main chart and rendering suggestions afterwards, caches can be leveraged better on several levels.

@flash1293 flash1293 added performance Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels May 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

@gingerwizard I prepared a PR for rendering suggestions after the main chart here: #100410

It's still kicking off the un-aggregated 500 document search for the field existence check in parallel - let me know what happens.

@flash1293
Copy link
Contributor Author

When implementing this we can also get rid of the hardcoded debounce of 2s for rendering of suggestion charts - waiting for the main chart is a much better way of handling this:

@flash1293 flash1293 removed their assignment Jul 8, 2021
@ghudgins
Copy link
Contributor

waiting on @gingerwizard to tell us if we should proceed with this in 7.15 (see #100410)

@flash1293
Copy link
Contributor Author

As discussed we moved this towards the end because it's not simple to do technically in our current architecture

@VladLasitsa VladLasitsa removed their assignment Jan 13, 2023
@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 15, 2023
@stratoula
Copy link
Contributor

We don't rendert the charts in suggestions in recent kibana versions so this is not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
5 participants