-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Render suggestions after main chart #100346
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
@gingerwizard I prepared a PR for rendering suggestions after the main chart here: #100410 It's still kicking off the un-aggregated 500 document search for the field existence check in parallel - let me know what happens. |
When implementing this we can also get rid of the hardcoded debounce of 2s for rendering of suggestion charts - waiting for the main chart is a much better way of handling this: kibana/x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx Line 97 in b35cde5
|
waiting on @gingerwizard to tell us if we should proceed with this in 7.15 (see #100410) |
As discussed we moved this towards the end because it's not simple to do technically in our current architecture |
We don't rendert the charts in suggestions in recent kibana versions so this is not relevant anymore |
Right now the main chart and the suggestions start rendering almost at the same time - this can cause a lot Elasticsearch load. By waiting for the main chart and rendering suggestions afterwards, caches can be leveraged better on several levels.
The text was updated successfully, but these errors were encountered: