From fd08c62f052d065e677b670a381840ae80dc9724 Mon Sep 17 00:00:00 2001
From: Robert Oskamp <robert.oskamp@elastic.co>
Date: Fri, 11 Aug 2023 19:40:26 +0200
Subject: [PATCH] Adjust global loading indicator data-test-subj for projects
 (#163697)

## Summary

This PR adjusts the `data-test-subj` for the global loading indicator in
serverless projects such that at matches the stateful version. This
makes sure that functional tests and corresponding test helper methods
continue to work the same in stateful and serverless environments when
comes to waiting for global loading to finish, which is a key mechanism
to avoid test flakiness.

### Additional information

- The serverless project specific global loading indicator was
introduced with #158523
- The stateful loading indicator `data-test-subj` naming is implemented
here:
https://github.com/elastic/kibana/blob/main/packages/core/chrome/core-chrome-browser-internal/src/ui/loading_indicator.tsx#L61

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
---
 .../core-chrome-browser-internal/src/ui/project/header.tsx  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx
index 551fa7895795d..f9e076db4410e 100644
--- a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx
+++ b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx
@@ -141,14 +141,14 @@ const Logo = (
   );
 
   return (
-    <span css={logo.container}>
+    <span css={logo.container} data-test-subj="nav-header-logo">
       {loadingCount === 0 ? (
         <EuiHeaderLogo
           iconType="logoElastic"
           onClick={navigateHome}
           href={fullHref}
           css={logo}
-          data-test-subj="nav-header-logo"
+          data-test-subj="globalLoadingIndicator-hidden"
           aria-label={headerStrings.logo.ariaLabel}
         />
       ) : (
@@ -157,7 +157,7 @@ const Logo = (
             size="l"
             aria-hidden={false}
             onClick={navigateHome}
-            data-test-subj="nav-header-loading-spinner"
+            data-test-subj="globalLoadingIndicator"
           />
         </a>
       )}