From f979aa7a006f698822271af4fb97bd672989b112 Mon Sep 17 00:00:00 2001 From: Aleh Zasypkin Date: Fri, 12 Jan 2024 21:24:56 +0200 Subject: [PATCH] Review#1: move `isDevOnly` check to `getDistPackagesFromRepo`. --- src/dev/build/lib/config.ts | 2 +- src/dev/build/tasks/build_packages_task.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dev/build/lib/config.ts b/src/dev/build/lib/config.ts index a27592e3f6427..19fbd6ae8bd37 100644 --- a/src/dev/build/lib/config.ts +++ b/src/dev/build/lib/config.ts @@ -246,7 +246,7 @@ export class Config { return getPackages(this.repoRoot).filter( (p) => (this.pluginSelector.testPlugins || !p.isDevOnly()) && - (!p.isPlugin() || this.pluginFilter(p)) + (!p.isPlugin() || (this.pluginFilter(p) && !p.isDevOnly())) ); } diff --git a/src/dev/build/tasks/build_packages_task.ts b/src/dev/build/tasks/build_packages_task.ts index 1f6e150496921..5db703481b7df 100644 --- a/src/dev/build/tasks/build_packages_task.ts +++ b/src/dev/build/tasks/build_packages_task.ts @@ -255,7 +255,7 @@ export const BuildPackages: Task = { Path.resolve(pkgDistPath, 'package-map.json'), JSON.stringify( packages - .filter((p) => p.isPlugin() && !p.isDevOnly()) + .filter((p) => p.isPlugin()) .map((p) => [p.manifest.id, `node_modules/${p.manifest.id}`]) ) );