From f6f5efd5f9356fef99ad5e37341d3e68c9a1a60a Mon Sep 17 00:00:00 2001
From: Rodney Norris <rodney.norris@elastic.co>
Date: Wed, 21 Sep 2022 10:34:33 -0500
Subject: [PATCH] [Enterprise Search] disable adding ml pipelines to default
 ingest pipeline (#141169)

---
 .../ml_inference/add_ml_inference_button.tsx  | 17 +++++++++++++-
 .../pipelines/pipelines_logic.test.ts         |  3 +++
 .../search_index/pipelines/pipelines_logic.ts | 23 +++++++++++++++----
 3 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx
index 6a11c17e878aa..2bc65e041cc86 100644
--- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/add_ml_inference_button.tsx
@@ -22,7 +22,7 @@ export const AddMLInferencePipelineButton: React.FC<AddMLInferencePipelineButton
   onClick,
 }) => {
   const { capabilities } = useValues(KibanaLogic);
-  const { canUseMlInferencePipeline } = useValues(PipelinesLogic);
+  const { canUseMlInferencePipeline, hasIndexIngestionPipeline } = useValues(PipelinesLogic);
   const hasMLPermissions = capabilities?.ml?.canAccessML ?? false;
   if (!hasMLPermissions) {
     return (
@@ -36,6 +36,21 @@ export const AddMLInferencePipelineButton: React.FC<AddMLInferencePipelineButton
       </EuiToolTip>
     );
   }
+  if (!hasIndexIngestionPipeline) {
+    return (
+      <EuiToolTip
+        content={i18n.translate(
+          'xpack.enterpriseSearch.content.indices.pipelines.mlInference.addButton.defaultIngestPipeline.disabledTooltip',
+          {
+            defaultMessage:
+              'You cannot add machine learning inference pipeline processors to the default ingest pipeline. You must first copy and customize the default ingest pipeline to add machine learning inference pipeline processors.',
+          }
+        )}
+      >
+        <AddButton disabled />
+      </EuiToolTip>
+    );
+  }
   if (!canUseMlInferencePipeline) {
     return (
       <EuiToolTip
diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.test.ts b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.test.ts
index 47b60b7c4f4b3..7dc3a221cc57a 100644
--- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.test.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.test.ts
@@ -30,6 +30,7 @@ const DEFAULT_VALUES = {
   pipelineState: DEFAULT_PIPELINE_VALUES,
   showModal: false,
   showAddMlInferencePipelineModal: false,
+  hasIndexIngestionPipeline: false,
 };
 
 describe('PipelinesLogic', () => {
@@ -86,6 +87,7 @@ describe('PipelinesLogic', () => {
       expect(PipelinesLogic.values).toEqual({
         ...DEFAULT_VALUES,
         pipelineState: { ...DEFAULT_PIPELINE_VALUES, name: 'new_pipeline_name' },
+        hasIndexIngestionPipeline: true,
       });
     });
     describe('makeRequest', () => {
@@ -155,6 +157,7 @@ describe('PipelinesLogic', () => {
             connector: { ...connectorIndex.connector, pipeline: newPipeline },
           },
           pipelineState: newPipeline,
+          hasIndexIngestionPipeline: true,
         });
       });
       it('should not set configState if modal is open', () => {
diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.ts b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.ts
index e6cb840be420a..99d241507dd2a 100644
--- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/pipelines_logic.ts
@@ -107,6 +107,7 @@ interface PipelinesValues {
   canUseMlInferencePipeline: boolean;
   defaultPipelineValues: IngestPipelineParams;
   defaultPipelineValuesData: IngestPipelineParams | null;
+  hasIndexIngestionPipeline: boolean;
   index: FetchIndexApiResponse;
   mlInferencePipelineProcessors: InferencePipeline[];
   pipelineState: IngestPipelineParams;
@@ -289,14 +290,26 @@ export const PipelinesLogic = kea<MakeLogicType<PipelinesValues, PipelinesAction
       () => [selectors.index],
       (index: ElasticsearchIndexWithIngestion) => !isApiIndex(index),
     ],
-    canUseMlInferencePipeline: [
-      () => [selectors.canSetPipeline, selectors.pipelineState],
-      (canSetPipeline: boolean, pipelineState: IngestPipelineParams) =>
-        canSetPipeline && pipelineState.run_ml_inference,
-    ],
     defaultPipelineValues: [
       () => [selectors.defaultPipelineValuesData],
       (pipeline: IngestPipelineParams | null) => pipeline ?? DEFAULT_PIPELINE_VALUES,
     ],
+    hasIndexIngestionPipeline: [
+      () => [selectors.pipelineState, selectors.defaultPipelineValues],
+      (pipelineState: IngestPipelineParams, defaultPipelineValues: IngestPipelineParams) =>
+        pipelineState.name !== defaultPipelineValues.name,
+    ],
+    canUseMlInferencePipeline: [
+      () => [
+        selectors.canSetPipeline,
+        selectors.hasIndexIngestionPipeline,
+        selectors.pipelineState,
+      ],
+      (
+        canSetPipeline: boolean,
+        hasIndexIngestionPipeline: boolean,
+        pipelineState: IngestPipelineParams
+      ) => canSetPipeline && hasIndexIngestionPipeline && pipelineState.run_ml_inference,
+    ],
   }),
 });