From f6a3f900b1a3e4deacb65768d5ffbc5f0b4e0cf4 Mon Sep 17 00:00:00 2001
From: Guanghao Fan <389823537@qq.com>
Date: Thu, 30 Aug 2018 20:14:36 +0800
Subject: [PATCH] Fix issue with heatmap showing black tiles (#20753)

* Heatmap metric data points should only be quantized while the data full range is grate than the maxmum allowed color count

* The data cell with metric value 'null' should always be hidden in the heatmap

* Add one variable for max color count and follow the coding style
---
 .../point_series/heatmap_chart.js               | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/ui/public/vislib/visualizations/point_series/heatmap_chart.js b/src/ui/public/vislib/visualizations/point_series/heatmap_chart.js
index 3f2391eb1e351..b765ccb31838e 100644
--- a/src/ui/public/vislib/visualizations/point_series/heatmap_chart.js
+++ b/src/ui/public/vislib/visualizations/point_series/heatmap_chart.js
@@ -69,6 +69,7 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
       const zScale = this.getValueAxis().getScale();
       const [min, max] = zScale.domain();
       const labels = [];
+      const maxColorCnt = 10;
       if (cfg.get('setColorRange')) {
         colorsRange.forEach(range => {
           const from = isFinite(range.from) ? zAxisFormatter(range.from) : range.from;
@@ -90,8 +91,14 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
           } else {
             val = val * (max - min) + min;
             nextVal = nextVal * (max - min) + min;
-            if (max > 1) {
-              val = Math.ceil(val);
+            if (max - min > maxColorCnt) {
+              const valInt = Math.ceil(val);
+              if (i === 0) {
+                val = (valInt === val ? val : valInt - 1);
+              }
+              else{
+                val = valInt;
+              }
               nextVal = Math.ceil(nextVal);
             }
             if (isFinite(val)) val = zAxisFormatter(val);
@@ -184,12 +191,16 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
             val = Math.min(colorsNumber - 1, Math.floor(val * colorsNumber));
           }
         }
+        if (d.y == null) {
+          return -1;
+        }
         return !isNaN(val) ? val : -1;
       }
 
       function label(d) {
         const colorBucket = getColorBucket(d);
-        if (colorBucket === -1) d.hide = true;
+        // colorBucket id should always GTE 0
+        if (colorBucket < 0) d.hide = true;
         return labels[colorBucket];
       }