From f4b925cd2b160f12389c39c94824891fbbf995a8 Mon Sep 17 00:00:00 2001 From: Davis McPhee Date: Wed, 16 Aug 2023 08:38:02 -0300 Subject: [PATCH] [Saved Seaches] Unskip embeddable Jest tests and only skip the actual flaky test (#164003) In #162997, the entire saved search embeddable Jest test suite was skipped instead of just the flaky test. This PR doesn't fix the flaky test, but unskips the test suite and instead only skips the flaky test to ensure the other tests run. --- .../public/embeddable/saved_search_embeddable.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts b/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts index 1fc7b2fcd775c..f492b49b8849d 100644 --- a/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts +++ b/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts @@ -75,8 +75,7 @@ const createSearchFnMock = (nrOfHits: number) => { const dataViewMock = buildDataViewMock({ name: 'the-data-view', fields: deepMockedFields }); -// FLAKY: https://github.com/elastic/kibana/issues/162997 -describe.skip('saved search embeddable', () => { +describe('saved search embeddable', () => { let mountpoint: HTMLDivElement; let servicesMock: jest.Mocked; @@ -322,7 +321,8 @@ describe.skip('saved search embeddable', () => { expect(search).toHaveBeenCalledTimes(1); }); - it('should not reload when the input title doesnt change', async () => { + // FLAKY: https://github.com/elastic/kibana/issues/162997 + it.skip('should not reload when the input title doesnt change', async () => { const search = jest.fn().mockReturnValue(getSearchResponse(1)); const { embeddable } = createEmbeddable({ searchMock: search, customTitle: 'custom title' }); await waitOneTick();