From 1b10ca905ed7c3aff67573c0c22c5341e6239b55 Mon Sep 17 00:00:00 2001 From: bhavyarm Date: Thu, 26 Sep 2019 09:34:58 -0400 Subject: [PATCH 1/3] try to fix all the skipped tests in vertical bar chart --- .../options/metrics_axes/value_axis_options.tsx | 1 + test/functional/apps/visualize/_vertical_bar_chart.js | 8 ++++---- test/functional/page_objects/visualize_page.js | 4 +--- test/functional/services/find.ts | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/value_axis_options.tsx b/src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/value_axis_options.tsx index e7d04d7025a68..660623ea995c9 100644 --- a/src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/value_axis_options.tsx +++ b/src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/value_axis_options.tsx @@ -141,6 +141,7 @@ function ValueAxisOptions(props: ValueAxisOptionsParams) { { + describe('switch between Y axis scale types', () => { before(initBarChart); const axisId = 'ValueAxis-1'; @@ -162,7 +162,7 @@ export default function ({ getService, getPageObjects }) { await PageObjects.visualize.clickMetricsAndAxes(); await PageObjects.visualize.clickYAxisOptions(axisId); await PageObjects.visualize.selectYAxisScaleType(axisId, 'log'); - await PageObjects.visualize.clickYAxisAdvancedOptions(axisId); + await PageObjects.visualize.clickYAxisOptions(axisId); await PageObjects.visualize.changeYAxisFilterLabelsCheckbox(axisId, false); await PageObjects.visualize.clickGo(); const labels = await PageObjects.visualize.getYAxisLabels(); @@ -279,7 +279,7 @@ export default function ({ getService, getPageObjects }) { }); // FLAKY: https://github.com/elastic/kibana/issues/45105 - describe.skip('vertical bar with multiple splits', function () { + describe('vertical bar with multiple splits', function () { before(initBarChart); it('should show correct series', async function () { diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js index 994a4d4a989c3..de897188817e2 100644 --- a/test/functional/page_objects/visualize_page.js +++ b/test/functional/page_objects/visualize_page.js @@ -685,9 +685,7 @@ export function VisualizePageProvider({ getService, getPageObjects, updateBaseli } async selectYAxisScaleType(axisId, scaleType) { - const selectElement = await testSubjects.find(`scaleSelectYAxis-${axisId}`); - const selector = await selectElement.findByCssSelector(`option[value="${scaleType}"]`); - await selector.click(); + await find.selectValue(`select#scaleSelectYAxis-${axisId}`, scaleType); } async selectYAxisMode(mode) { diff --git a/test/functional/services/find.ts b/test/functional/services/find.ts index 9723e3b745502..ba510b4b693e3 100644 --- a/test/functional/services/find.ts +++ b/test/functional/services/find.ts @@ -390,7 +390,7 @@ export async function FindProvider({ getService }: FtrProviderContext) { await retry.try(async () => { const element = await this.byCssSelector(selector, timeout); if (element) { - // await element.moveMouseTo(); + await element.moveMouseTo(); await element.click(); } else { throw new Error(`Element with css='${selector}' is not found`); From 466479458564fcb0be89c1ba7a3fe9eaa9c4a5f4 Mon Sep 17 00:00:00 2001 From: bhavyarm Date: Mon, 30 Sep 2019 09:17:07 -0400 Subject: [PATCH 2/3] commenting the movemouse in clickByCssSelector --- test/functional/services/find.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/services/find.ts b/test/functional/services/find.ts index ba510b4b693e3..6d88ed3ae90df 100644 --- a/test/functional/services/find.ts +++ b/test/functional/services/find.ts @@ -390,7 +390,7 @@ export async function FindProvider({ getService }: FtrProviderContext) { await retry.try(async () => { const element = await this.byCssSelector(selector, timeout); if (element) { - await element.moveMouseTo(); + //await element.moveMouseTo(); await element.click(); } else { throw new Error(`Element with css='${selector}' is not found`); From 64d09c63355976f34d45a9f29009b6e80a0ab0a3 Mon Sep 17 00:00:00 2001 From: bhavyarm Date: Mon, 30 Sep 2019 09:18:33 -0400 Subject: [PATCH 3/3] commenting the movemouse in clickByCssSelector --- test/functional/services/find.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/services/find.ts b/test/functional/services/find.ts index 6d88ed3ae90df..9723e3b745502 100644 --- a/test/functional/services/find.ts +++ b/test/functional/services/find.ts @@ -390,7 +390,7 @@ export async function FindProvider({ getService }: FtrProviderContext) { await retry.try(async () => { const element = await this.byCssSelector(selector, timeout); if (element) { - //await element.moveMouseTo(); + // await element.moveMouseTo(); await element.click(); } else { throw new Error(`Element with css='${selector}' is not found`);