From f0caabd543a99ae4896a378c08da007ec723a6e1 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Wed, 27 Nov 2024 01:09:24 +1100
Subject: [PATCH] [8.x] [a11y][search connectors] Fix a11y with connectors
 table (#201421) (#201770)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[a11y][search connectors] Fix a11y with connectors table
(#201421)](https://github.com/elastic/kibana/pull/201421)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jedr
Blaszyk","email":"jedrazb@gmail.com"},"sourceCommit":{"committedDate":"2024-11-26T12:07:44Z","message":"[a11y][search
connectors] Fix a11y with connectors table (#201421)\n\n##
Summary\r\n\r\nfrom issue: When Search doesn't provide any results, it
should not only\r\nbe present visually, but it should also be announced.
Especially for the\r\nusers using assistive technology, that they would
understand that no\r\nmatching elements were found.\r\n\r\n\r\nAdd table
caption and `aria-live` announcement when no connectors found:\r\n\r\n+
additionally customize the 'no items found' message and add
table\r\ncaption to further improve a11y\r\n\r\n<img width=\"1287\"
alt=\"Screenshot 2024-11-22 at 16 30
33\"\r\nsrc=\"https://github.com/user-attachments/assets/2bce17f9-f6cf-4357-a679-54d43a247493\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n\r\nDoes this PR introduce any risks? For example,
consider risks like hard\r\nto test bugs, performance regression,
potential of data loss.\r\n\r\nDescribe the risk, its severity, and
mitigation for each identified\r\nrisk. Invite stakeholders and evaluate
how to proceed before merging.\r\n\r\n- [ ] [See some
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n-
[ ]
...","sha":"75f5d59845092274e520f6b3039e27812b308b7e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[a11y][search
connectors] Fix a11y with connectors
table","number":201421,"url":"https://github.com/elastic/kibana/pull/201421","mergeCommit":{"message":"[a11y][search
connectors] Fix a11y with connectors table (#201421)\n\n##
Summary\r\n\r\nfrom issue: When Search doesn't provide any results, it
should not only\r\nbe present visually, but it should also be announced.
Especially for the\r\nusers using assistive technology, that they would
understand that no\r\nmatching elements were found.\r\n\r\n\r\nAdd table
caption and `aria-live` announcement when no connectors found:\r\n\r\n+
additionally customize the 'no items found' message and add
table\r\ncaption to further improve a11y\r\n\r\n<img width=\"1287\"
alt=\"Screenshot 2024-11-22 at 16 30
33\"\r\nsrc=\"https://github.com/user-attachments/assets/2bce17f9-f6cf-4357-a679-54d43a247493\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n\r\nDoes this PR introduce any risks? For example,
consider risks like hard\r\nto test bugs, performance regression,
potential of data loss.\r\n\r\nDescribe the risk, its severity, and
mitigation for each identified\r\nrisk. Invite stakeholders and evaluate
how to proceed before merging.\r\n\r\n- [ ] [See some
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n-
[ ]
...","sha":"75f5d59845092274e520f6b3039e27812b308b7e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201421","number":201421,"mergeCommit":{"message":"[a11y][search
connectors] Fix a11y with connectors table (#201421)\n\n##
Summary\r\n\r\nfrom issue: When Search doesn't provide any results, it
should not only\r\nbe present visually, but it should also be announced.
Especially for the\r\nusers using assistive technology, that they would
understand that no\r\nmatching elements were found.\r\n\r\n\r\nAdd table
caption and `aria-live` announcement when no connectors found:\r\n\r\n+
additionally customize the 'no items found' message and add
table\r\ncaption to further improve a11y\r\n\r\n<img width=\"1287\"
alt=\"Screenshot 2024-11-22 at 16 30
33\"\r\nsrc=\"https://github.com/user-attachments/assets/2bce17f9-f6cf-4357-a679-54d43a247493\">\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nCheck the PR satisfies following conditions.
\r\n\r\nReviewers should verify this PR satisfies this list as
well.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [x] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n###
Identify risks\r\n\r\nDoes this PR introduce any risks? For example,
consider risks like hard\r\nto test bugs, performance regression,
potential of data loss.\r\n\r\nDescribe the risk, its severity, and
mitigation for each identified\r\nrisk. Invite stakeholders and evaluate
how to proceed before merging.\r\n\r\n- [ ] [See some
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n-
[ ] ...","sha":"75f5d59845092274e520f6b3039e27812b308b7e"}}]}]
BACKPORT-->

Co-authored-by: Jedr Blaszyk <jedrazb@gmail.com>
---
 .../components/connectors/connectors_table.tsx       | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/connectors_table.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/connectors_table.tsx
index 82f258487f39e..4f7937a0f1c76 100644
--- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/connectors_table.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/connectors_table.tsx
@@ -16,6 +16,7 @@ import {
   EuiBasicTableColumn,
   EuiFlexGroup,
   EuiFlexItem,
+  EuiText,
 } from '@elastic/eui';
 
 import { i18n } from '@kbn/i18n';
@@ -221,7 +222,18 @@ export const ConnectorsTable: React.FC<ConnectorsTableProps> = ({
           columns={columns}
           onChange={onChange}
           tableLayout="fixed"
+          tableCaption={i18n.translate(
+            'xpack.enterpriseSearch.connectorsTable.table.availableConnectorsTableCaption',
+            { defaultMessage: 'Available connectors table' }
+          )}
           loading={isLoading}
+          noItemsMessage={
+            <EuiText aria-live="polite" size="s">
+              {i18n.translate('xpack.enterpriseSearch.connectorsTable.table.noResultsMessage', {
+                defaultMessage: 'No connectors found',
+              })}
+            </EuiText>
+          }
           pagination={{
             pageIndex: meta.page.from / (meta.page.size || 1),
             pageSize: meta.page.size,