diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 51c0162a5ee9c..309e90be7077d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -79,7 +79,7 @@ /src/plugins/data_view_field_editor @elastic/kibana-app-services /src/plugins/screenshot_mode @elastic/kibana-app-services /src/plugins/bfetch/ @elastic/kibana-app-services -/src/plugins/index_pattern_management/ @elastic/kibana-app-services +/src/plugins/data_view_management/ @elastic/kibana-app-services /src/plugins/inspector/ @elastic/kibana-app-services /x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-services /x-pack/plugins/data_enhanced/ @elastic/kibana-app-services diff --git a/.i18nrc.json b/.i18nrc.json index afe5c7e7627f3..5688f700aab3d 100644 --- a/.i18nrc.json +++ b/.i18nrc.json @@ -43,7 +43,7 @@ "presentationUtil": "src/plugins/presentation_util", "indexPatternEditor": "src/plugins/index_pattern_editor", "indexPatternFieldEditor": "src/plugins/data_view_field_editor", - "indexPatternManagement": "src/plugins/index_pattern_management", + "indexPatternManagement": "src/plugins/data_view_management", "interactiveSetup": "src/plugins/interactive_setup", "advancedSettings": "src/plugins/advanced_settings", "kibana_legacy": "src/plugins/kibana_legacy", diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc index 40ad65d43b5de..df6e7e6b63e5b 100644 --- a/docs/developer/plugin-list.asciidoc +++ b/docs/developer/plugin-list.asciidoc @@ -57,6 +57,10 @@ as uiSettings within the code. |The reusable field editor across Kibana! +|{kib-repo}blob/{branch}/src/plugins/data_view_management[dataViewManagement] +|WARNING: Missing README. + + |{kib-repo}blob/{branch}/src/plugins/data_views/README.mdx[dataViews] |The data views API provides a consistent method of structuring and formatting documents and field lists across the various Kibana apps. Its typically used in conjunction with @@ -145,10 +149,6 @@ for use in their own application. |Create index patterns from within Kibana apps. -|{kib-repo}blob/{branch}/src/plugins/index_pattern_management[indexPatternManagement] -|WARNING: Missing README. - - |{kib-repo}blob/{branch}/src/plugins/input_control_vis/README.md[inputControlVis] |Contains the input control visualization allowing to place custom filter controls on a dashboard. diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 6930875cb5c17..105bb3ae50038 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -114,5 +114,5 @@ pageLoadAssetSize: urlDrilldown: 30063 indexPatternEditor: 19123 dataViewFieldEditor: 20000 - indexPatternManagement: 19165 + dataViewManagement: 5000 reporting: 57003 diff --git a/src/plugins/index_pattern_management/jest.config.js b/src/plugins/data_view_management/jest.config.js similarity index 72% rename from src/plugins/index_pattern_management/jest.config.js rename to src/plugins/data_view_management/jest.config.js index 6249d44e6b31f..885706e862ceb 100644 --- a/src/plugins/index_pattern_management/jest.config.js +++ b/src/plugins/data_view_management/jest.config.js @@ -9,11 +9,9 @@ module.exports = { preset: '@kbn/test', rootDir: '../../..', - roots: ['/src/plugins/index_pattern_management'], + roots: ['/src/plugins/data_view_management'], testRunner: 'jasmine2', - coverageDirectory: '/target/kibana-coverage/jest/src/plugins/index_pattern_management', + coverageDirectory: '/target/kibana-coverage/jest/src/plugins/data_view_management', coverageReporters: ['text', 'html'], - collectCoverageFrom: [ - '/src/plugins/index_pattern_management/{public,server}/**/*.{ts,tsx}', - ], + collectCoverageFrom: ['/src/plugins/data_view_management/{public,server}/**/*.{ts,tsx}'], }; diff --git a/src/plugins/index_pattern_management/kibana.json b/src/plugins/data_view_management/kibana.json similarity index 78% rename from src/plugins/index_pattern_management/kibana.json rename to src/plugins/data_view_management/kibana.json index 81477e7c1be79..cd556dbeb505e 100644 --- a/src/plugins/index_pattern_management/kibana.json +++ b/src/plugins/data_view_management/kibana.json @@ -1,5 +1,5 @@ { - "id": "indexPatternManagement", + "id": "dataViewManagement", "version": "kibana", "server": true, "ui": true, @@ -9,5 +9,5 @@ "name": "App Services", "githubTeam": "kibana-app-services" }, - "description": "Index pattern management app" + "description": "Data view management app" } diff --git a/src/plugins/index_pattern_management/public/_templates.scss b/src/plugins/data_view_management/public/_templates.scss similarity index 100% rename from src/plugins/index_pattern_management/public/_templates.scss rename to src/plugins/data_view_management/public/_templates.scss diff --git a/src/plugins/index_pattern_management/public/_variables.scss b/src/plugins/data_view_management/public/_variables.scss similarity index 100% rename from src/plugins/index_pattern_management/public/_variables.scss rename to src/plugins/data_view_management/public/_variables.scss diff --git a/src/plugins/index_pattern_management/public/assets/icons/LICENSE.txt b/src/plugins/data_view_management/public/assets/icons/LICENSE.txt similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/LICENSE.txt rename to src/plugins/data_view_management/public/assets/icons/LICENSE.txt diff --git a/src/plugins/index_pattern_management/public/assets/icons/cv.png b/src/plugins/data_view_management/public/assets/icons/cv.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/cv.png rename to src/plugins/data_view_management/public/assets/icons/cv.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/de.png b/src/plugins/data_view_management/public/assets/icons/de.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/de.png rename to src/plugins/data_view_management/public/assets/icons/de.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/go.png b/src/plugins/data_view_management/public/assets/icons/go.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/go.png rename to src/plugins/data_view_management/public/assets/icons/go.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/ne.png b/src/plugins/data_view_management/public/assets/icons/ne.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/ne.png rename to src/plugins/data_view_management/public/assets/icons/ne.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/ni.png b/src/plugins/data_view_management/public/assets/icons/ni.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/ni.png rename to src/plugins/data_view_management/public/assets/icons/ni.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/stop.png b/src/plugins/data_view_management/public/assets/icons/stop.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/stop.png rename to src/plugins/data_view_management/public/assets/icons/stop.png diff --git a/src/plugins/index_pattern_management/public/assets/icons/us.png b/src/plugins/data_view_management/public/assets/icons/us.png similarity index 100% rename from src/plugins/index_pattern_management/public/assets/icons/us.png rename to src/plugins/data_view_management/public/assets/icons/us.png diff --git a/src/plugins/index_pattern_management/public/components/__snapshots__/utils.test.ts.snap b/src/plugins/data_view_management/public/components/__snapshots__/utils.test.ts.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/__snapshots__/utils.test.ts.snap rename to src/plugins/data_view_management/public/components/__snapshots__/utils.test.ts.snap diff --git a/src/plugins/index_pattern_management/public/components/breadcrumbs.ts b/src/plugins/data_view_management/public/components/breadcrumbs.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/breadcrumbs.ts rename to src/plugins/data_view_management/public/components/breadcrumbs.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/constants.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/constants.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/constants.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/constants.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/create_edit_field_container.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/create_edit_field_container.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/create_edit_field_container.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/create_edit_field_container.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/create_edit_field/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/create_edit_field/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern_container.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern_container.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern_container.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern_container.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern_state_container.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern_state_container.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/edit_index_pattern_state_container.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/edit_index_pattern_state_container.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/index.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/index.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/index.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/index.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/index_header/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/index_header/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/index_header/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/index_header/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/index_header/index_header.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/index_header/index_header.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/index_header/index_header.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/index_header/index_header.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/__snapshots__/indexed_fields_table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/__snapshots__/indexed_fields_table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/__snapshots__/indexed_fields_table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/__snapshots__/indexed_fields_table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/types.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/types.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/types.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/__snapshots__/scripted_field_table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/__snapshots__/scripted_field_table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/__snapshots__/scripted_field_table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/__snapshots__/scripted_field_table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/__snapshots__/call_outs.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/__snapshots__/call_outs.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/__snapshots__/call_outs.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/__snapshots__/call_outs.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/call_outs.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/call_outs/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/confirmation_modal.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/confirmation_modal/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/__snapshots__/header.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/header.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/header/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/header/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/scripted_field_table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/scripted_field_table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/scripted_field_table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/scripted_field_table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/types.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/scripted_fields_table/types.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/types.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/__snapshots__/source_filters_table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/__snapshots__/source_filters_table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/__snapshots__/source_filters_table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/__snapshots__/source_filters_table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/__snapshots__/add_filter.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/__snapshots__/add_filter.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/__snapshots__/add_filter.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/__snapshots__/add_filter.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/add_filter.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/add_filter/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/__snapshots__/confirmation_modal.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/confirmation_modal.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/confirmation_modal/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/header.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/header.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/header/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/components/table/table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.test.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.test.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/source_filters_table.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/types.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/source_filters_table/types.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/types.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/index.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/tabs/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/index.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/tabs/index.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/tabs.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/tabs/tabs.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/tabs.tsx rename to src/plugins/data_view_management/public/components/edit_index_pattern/tabs/tabs.tsx diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.test.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.test.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.test.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.test.ts diff --git a/src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.ts b/src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/edit_index_pattern/tabs/utils.ts rename to src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/__snapshots__/field_editor.test.tsx.snap b/src/plugins/data_view_management/public/components/field_editor/__snapshots__/field_editor.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/__snapshots__/field_editor.test.tsx.snap rename to src/plugins/data_view_management/public/components/field_editor/__snapshots__/field_editor.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/__snapshots__/field_format_editor.test.tsx.snap b/src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/__snapshots__/field_format_editor.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/__snapshots__/field_format_editor.test.tsx.snap rename to src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/__snapshots__/field_format_editor.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/field_format_editor.test.tsx b/src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/field_format_editor.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/field_format_editor.test.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/field_format_editor.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/field_format_editor.tsx b/src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/field_format_editor.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/field_format_editor.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/field_format_editor.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/index.ts b/src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/field_format_editor/index.ts rename to src/plugins/data_view_management/public/components/field_editor/components/field_format_editor/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/disabled_call_out.test.tsx.snap b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/disabled_call_out.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/disabled_call_out.test.tsx.snap rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/disabled_call_out.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.tsx.snap b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.tsx.snap rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.test.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.test.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/disabled_call_out.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/index.ts b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/index.ts rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.test.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.test.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_call_outs/warning_call_out.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/__snapshots__/help_flyout.test.tsx.snap b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/__snapshots__/help_flyout.test.tsx.snap similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/__snapshots__/help_flyout.test.tsx.snap rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/__snapshots__/help_flyout.test.tsx.snap diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/help_flyout.test.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/help_flyout.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/help_flyout.test.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/help_flyout.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/help_flyout.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/help_flyout.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/help_flyout.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/help_flyout.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/index.ts b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/index.ts rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/scripting_syntax.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/scripting_syntax.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/scripting_syntax.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/scripting_syntax.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/test_script.scss b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/test_script.scss similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/test_script.scss rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/test_script.scss diff --git a/src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/test_script.tsx b/src/plugins/data_view_management/public/components/field_editor/components/scripting_help/test_script.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/components/scripting_help/test_script.tsx rename to src/plugins/data_view_management/public/components/field_editor/components/scripting_help/test_script.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/constants/index.ts b/src/plugins/data_view_management/public/components/field_editor/constants/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/constants/index.ts rename to src/plugins/data_view_management/public/components/field_editor/constants/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/field_editor.test.tsx b/src/plugins/data_view_management/public/components/field_editor/field_editor.test.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/field_editor.test.tsx rename to src/plugins/data_view_management/public/components/field_editor/field_editor.test.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx b/src/plugins/data_view_management/public/components/field_editor/field_editor.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx rename to src/plugins/data_view_management/public/components/field_editor/field_editor.tsx diff --git a/src/plugins/index_pattern_management/public/components/field_editor/index.ts b/src/plugins/data_view_management/public/components/field_editor/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/index.ts rename to src/plugins/data_view_management/public/components/field_editor/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/lib/index.ts b/src/plugins/data_view_management/public/components/field_editor/lib/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/lib/index.ts rename to src/plugins/data_view_management/public/components/field_editor/lib/index.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/lib/validate_script.ts b/src/plugins/data_view_management/public/components/field_editor/lib/validate_script.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/lib/validate_script.ts rename to src/plugins/data_view_management/public/components/field_editor/lib/validate_script.ts diff --git a/src/plugins/index_pattern_management/public/components/field_editor/types.ts b/src/plugins/data_view_management/public/components/field_editor/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/field_editor/types.ts rename to src/plugins/data_view_management/public/components/field_editor/types.ts diff --git a/src/plugins/index_pattern_management/public/components/index.ts b/src/plugins/data_view_management/public/components/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/index.ts rename to src/plugins/data_view_management/public/components/index.ts diff --git a/src/plugins/index_pattern_management/public/components/index_pattern_table/index.ts b/src/plugins/data_view_management/public/components/index_pattern_table/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/index_pattern_table/index.ts rename to src/plugins/data_view_management/public/components/index_pattern_table/index.ts diff --git a/src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx b/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx rename to src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx diff --git a/src/plugins/index_pattern_management/public/components/test_utils.tsx b/src/plugins/data_view_management/public/components/test_utils.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/components/test_utils.tsx rename to src/plugins/data_view_management/public/components/test_utils.tsx diff --git a/src/plugins/index_pattern_management/public/components/types.ts b/src/plugins/data_view_management/public/components/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/types.ts rename to src/plugins/data_view_management/public/components/types.ts diff --git a/src/plugins/index_pattern_management/public/components/utils.test.ts b/src/plugins/data_view_management/public/components/utils.test.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/utils.test.ts rename to src/plugins/data_view_management/public/components/utils.test.ts diff --git a/src/plugins/index_pattern_management/public/components/utils.ts b/src/plugins/data_view_management/public/components/utils.ts similarity index 100% rename from src/plugins/index_pattern_management/public/components/utils.ts rename to src/plugins/data_view_management/public/components/utils.ts diff --git a/src/plugins/index_pattern_management/public/constants.ts b/src/plugins/data_view_management/public/constants.ts similarity index 100% rename from src/plugins/index_pattern_management/public/constants.ts rename to src/plugins/data_view_management/public/constants.ts diff --git a/src/plugins/index_pattern_management/public/index.ts b/src/plugins/data_view_management/public/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/index.ts rename to src/plugins/data_view_management/public/index.ts diff --git a/src/plugins/index_pattern_management/public/management_app/index.tsx b/src/plugins/data_view_management/public/management_app/index.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/management_app/index.tsx rename to src/plugins/data_view_management/public/management_app/index.tsx diff --git a/src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx b/src/plugins/data_view_management/public/management_app/mount_management_section.tsx similarity index 100% rename from src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx rename to src/plugins/data_view_management/public/management_app/mount_management_section.tsx diff --git a/src/plugins/index_pattern_management/public/mocks.ts b/src/plugins/data_view_management/public/mocks.ts similarity index 100% rename from src/plugins/index_pattern_management/public/mocks.ts rename to src/plugins/data_view_management/public/mocks.ts diff --git a/src/plugins/index_pattern_management/public/plugin.ts b/src/plugins/data_view_management/public/plugin.ts similarity index 100% rename from src/plugins/index_pattern_management/public/plugin.ts rename to src/plugins/data_view_management/public/plugin.ts diff --git a/src/plugins/index_pattern_management/public/scripting_languages/index.ts b/src/plugins/data_view_management/public/scripting_languages/index.ts similarity index 100% rename from src/plugins/index_pattern_management/public/scripting_languages/index.ts rename to src/plugins/data_view_management/public/scripting_languages/index.ts diff --git a/src/plugins/index_pattern_management/public/types.ts b/src/plugins/data_view_management/public/types.ts similarity index 100% rename from src/plugins/index_pattern_management/public/types.ts rename to src/plugins/data_view_management/public/types.ts diff --git a/src/plugins/index_pattern_management/server/index.ts b/src/plugins/data_view_management/server/index.ts similarity index 100% rename from src/plugins/index_pattern_management/server/index.ts rename to src/plugins/data_view_management/server/index.ts diff --git a/src/plugins/index_pattern_management/server/plugin.ts b/src/plugins/data_view_management/server/plugin.ts similarity index 100% rename from src/plugins/index_pattern_management/server/plugin.ts rename to src/plugins/data_view_management/server/plugin.ts diff --git a/src/plugins/index_pattern_management/server/routes/index.ts b/src/plugins/data_view_management/server/routes/index.ts similarity index 100% rename from src/plugins/index_pattern_management/server/routes/index.ts rename to src/plugins/data_view_management/server/routes/index.ts diff --git a/src/plugins/index_pattern_management/server/routes/preview_scripted_field.test.ts b/src/plugins/data_view_management/server/routes/preview_scripted_field.test.ts similarity index 100% rename from src/plugins/index_pattern_management/server/routes/preview_scripted_field.test.ts rename to src/plugins/data_view_management/server/routes/preview_scripted_field.test.ts diff --git a/src/plugins/index_pattern_management/server/routes/preview_scripted_field.ts b/src/plugins/data_view_management/server/routes/preview_scripted_field.ts similarity index 100% rename from src/plugins/index_pattern_management/server/routes/preview_scripted_field.ts rename to src/plugins/data_view_management/server/routes/preview_scripted_field.ts diff --git a/src/plugins/index_pattern_management/server/routes/resolve_index.ts b/src/plugins/data_view_management/server/routes/resolve_index.ts similarity index 100% rename from src/plugins/index_pattern_management/server/routes/resolve_index.ts rename to src/plugins/data_view_management/server/routes/resolve_index.ts diff --git a/src/plugins/index_pattern_management/tsconfig.json b/src/plugins/data_view_management/tsconfig.json similarity index 100% rename from src/plugins/index_pattern_management/tsconfig.json rename to src/plugins/data_view_management/tsconfig.json diff --git a/test/functional/apps/visualize/_tsvb_chart.ts b/test/functional/apps/visualize/_tsvb_chart.ts index c530b00364fd1..0efc4b2f1d1ae 100644 --- a/test/functional/apps/visualize/_tsvb_chart.ts +++ b/test/functional/apps/visualize/_tsvb_chart.ts @@ -27,8 +27,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ]); describe('visual builder', function describeIndexTests() { - this.tags('includeFirefox'); - before(async () => { await visualize.initTests(); }); diff --git a/test/functional/apps/visualize/_tsvb_time_series.ts b/test/functional/apps/visualize/_tsvb_time_series.ts index 69cc764c39b21..e9d0fabe0fefa 100644 --- a/test/functional/apps/visualize/_tsvb_time_series.ts +++ b/test/functional/apps/visualize/_tsvb_time_series.ts @@ -49,147 +49,157 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await visualBuilder.clickDataTab('timeSeries'); }); - it('should render all necessary components', async () => { - await visualBuilder.checkTimeSeriesChartIsPresent(); - await visualBuilder.checkTimeSeriesLegendIsPresent(); - }); + describe('basics', () => { + this.tags('includeFirefox'); - it('should show the correct count in the legend', async () => { - await retry.try(async () => { - const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be('156'); + it('should render all necessary components', async () => { + await visualBuilder.checkTimeSeriesChartIsPresent(); + await visualBuilder.checkTimeSeriesLegendIsPresent(); }); - }); - - it('should show the correct count in the legend with 2h offset', async () => { - await visualBuilder.clickSeriesOption(); - await visualBuilder.enterOffsetSeries('2h'); - const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be('293'); - }); - - it('should show the correct count in the legend with -2h offset', async () => { - await visualBuilder.clickSeriesOption(); - await visualBuilder.enterOffsetSeries('-2h'); - const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be('53'); - }); - it('should open color picker, deactivate panel and clone series', async () => { - await visualBuilder.clickColorPicker(); - await visualBuilder.checkColorPickerPopUpIsPresent(); - await visualBuilder.clickColorPicker(); - - await visualBuilder.changePanelPreview(); - await visualBuilder.checkPreviewIsDisabled(); - await visualBuilder.changePanelPreview(); - - await visualBuilder.cloneSeries(); - const legend = await visualBuilder.getLegendItems(); - const series = await visualBuilder.getSeries(); - expect(legend.length).to.be(2); - expect(series.length).to.be(2); - }); - - it('should show the correct count in the legend with custom numeric formatter', async () => { - const expectedLegendValue = '$ 156'; + it('should show the correct count in the legend', async () => { + await retry.try(async () => { + const actualCount = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCount).to.be('156'); + }); + }); - await visualBuilder.clickSeriesOption(); - await visualBuilder.changeDataFormatter('number'); - await visualBuilder.enterSeriesTemplate('$ {{value}}'); - await retry.try(async () => { + it('should show the correct count in the legend with 2h offset', async () => { + await visualBuilder.clickSeriesOption(); + await visualBuilder.enterOffsetSeries('2h'); const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be(expectedLegendValue); + expect(actualCount).to.be('293'); }); - }); - it('should show the correct count in the legend with percent formatter', async () => { - const expectedLegendValue = '15,600%'; + it('should show the correct count in the legend with -2h offset', async () => { + await visualBuilder.clickSeriesOption(); + await visualBuilder.enterOffsetSeries('-2h'); + const actualCount = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCount).to.be('53'); + }); - await visualBuilder.clickSeriesOption(); - await visualBuilder.changeDataFormatter('percent'); - const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be(expectedLegendValue); - }); + it('should open color picker, deactivate panel and clone series', async () => { + await visualBuilder.clickColorPicker(); + await visualBuilder.checkColorPickerPopUpIsPresent(); + await visualBuilder.clickColorPicker(); - it('should show the correct count in the legend with bytes formatter', async () => { - const expectedLegendValue = '156B'; + await visualBuilder.changePanelPreview(); + await visualBuilder.checkPreviewIsDisabled(); + await visualBuilder.changePanelPreview(); - await visualBuilder.clickSeriesOption(); - await visualBuilder.changeDataFormatter('bytes'); - const actualCount = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCount).to.be(expectedLegendValue); - }); + await visualBuilder.cloneSeries(); + const legend = await visualBuilder.getLegendItems(); + const series = await visualBuilder.getSeries(); + expect(legend.length).to.be(2); + expect(series.length).to.be(2); + }); - it('should show the correct count in the legend with "Human readable" duration formatter', async () => { - await visualBuilder.clickSeriesOption(); - await visualBuilder.changeDataFormatter('duration'); - await visualBuilder.setDurationFormatterSettings({ to: 'Human readable' }); - const actualCountDefault = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCountDefault).to.be('a few seconds'); - - log.debug(`to: 'Human readable', from: 'Seconds'`); - await visualBuilder.setDurationFormatterSettings({ to: 'Human readable', from: 'Seconds' }); - const actualCountSec = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCountSec).to.be('3 minutes'); - - log.debug(`to: 'Human readable', from: 'Minutes'`); - await visualBuilder.setDurationFormatterSettings({ to: 'Human readable', from: 'Minutes' }); - const actualCountMin = await visualBuilder.getRhythmChartLegendValue(); - expect(actualCountMin).to.be('3 hours'); - }); + it('should show the correct count in the legend with custom numeric formatter', async () => { + const expectedLegendValue = '$ 156'; - describe('Dark mode', () => { - before(async () => { - await kibanaServer.uiSettings.update({ - 'theme:darkMode': true, + await visualBuilder.clickSeriesOption(); + await visualBuilder.changeDataFormatter('number'); + await visualBuilder.enterSeriesTemplate('$ {{value}}'); + await retry.try(async () => { + const actualCount = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCount).to.be(expectedLegendValue); }); }); - it(`viz should have light class when background color is white`, async () => { - await visualBuilder.clickPanelOptions('timeSeries'); - await visualBuilder.setBackgroundColor('#FFFFFF'); + it('should show the correct count in the legend with percent formatter', async () => { + const expectedLegendValue = '15,600%'; - expect(await visualBuilder.checkTimeSeriesIsLight()).to.be(true); + await visualBuilder.clickSeriesOption(); + await visualBuilder.changeDataFormatter('percent'); + const actualCount = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCount).to.be(expectedLegendValue); }); - after(async () => { - await kibanaServer.uiSettings.update({ - 'theme:darkMode': false, - }); + it('should show the correct count in the legend with bytes formatter', async () => { + const expectedLegendValue = '156B'; + + await visualBuilder.clickSeriesOption(); + await visualBuilder.changeDataFormatter('bytes'); + const actualCount = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCount).to.be(expectedLegendValue); }); - }); - describe('Clicking on the chart', () => { - it(`should create a filter`, async () => { - await visualBuilder.setMetricsGroupByTerms('machine.os.raw', { - include: 'win 7', - exclude: 'ios', - }); + it('should show the correct count in the legend with "Human readable" duration formatter', async () => { await visualBuilder.clickSeriesOption(); - await testSubjects.click('visualizeSaveButton'); + await visualBuilder.changeDataFormatter('duration'); + await visualBuilder.setDurationFormatterSettings({ to: 'Human readable' }); + const actualCountDefault = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCountDefault).to.be('a few seconds'); + + log.debug(`to: 'Human readable', from: 'Seconds'`); + await visualBuilder.setDurationFormatterSettings({ + to: 'Human readable', + from: 'Seconds', + }); + const actualCountSec = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCountSec).to.be('3 minutes'); - await timeToVisualize.saveFromModal('My TSVB viz 1', { - addToDashboard: 'new', - saveToLibrary: false, + log.debug(`to: 'Human readable', from: 'Minutes'`); + await visualBuilder.setDurationFormatterSettings({ + to: 'Human readable', + from: 'Minutes', }); + const actualCountMin = await visualBuilder.getRhythmChartLegendValue(); + expect(actualCountMin).to.be('3 hours'); + }); - await dashboard.waitForRenderComplete(); - const el = await elasticChart.getCanvas(); - // click on specific coordinates - await browser - .getActions() - .move({ x: 105, y: 115, origin: el._webElement }) - .click() - .perform(); + describe('Dark mode', () => { + before(async () => { + await kibanaServer.uiSettings.update({ + 'theme:darkMode': true, + }); + }); - await retry.try(async () => { - await testSubjects.click('applyFiltersPopoverButton'); - await testSubjects.missingOrFail('applyFiltersPopoverButton'); + it(`viz should have light class when background color is white`, async () => { + await visualBuilder.clickPanelOptions('timeSeries'); + await visualBuilder.setBackgroundColor('#FFFFFF'); + + expect(await visualBuilder.checkTimeSeriesIsLight()).to.be(true); + }); + + after(async () => { + await kibanaServer.uiSettings.update({ + 'theme:darkMode': false, + }); }); + }); - const hasMachineRawFilter = await filterBar.hasFilter('machine.os.raw', 'win 7'); - expect(hasMachineRawFilter).to.be(true); + describe('Clicking on the chart', () => { + it(`should create a filter`, async () => { + await visualBuilder.setMetricsGroupByTerms('machine.os.raw', { + include: 'win 7', + exclude: 'ios', + }); + await visualBuilder.clickSeriesOption(); + await testSubjects.click('visualizeSaveButton'); + + await timeToVisualize.saveFromModal('My TSVB viz 1', { + addToDashboard: 'new', + saveToLibrary: false, + }); + + await dashboard.waitForRenderComplete(); + const el = await elasticChart.getCanvas(); + // click on specific coordinates + await browser + .getActions() + .move({ x: 105, y: 115, origin: el._webElement }) + .click() + .perform(); + + await retry.try(async () => { + await testSubjects.click('applyFiltersPopoverButton'); + await testSubjects.missingOrFail('applyFiltersPopoverButton'); + }); + + const hasMachineRawFilter = await filterBar.hasFilter('machine.os.raw', 'win 7'); + expect(hasMachineRawFilter).to.be(true); + }); }); }); diff --git a/test/tsconfig.json b/test/tsconfig.json index 288d152bf4bc0..64c85dad73312 100644 --- a/test/tsconfig.json +++ b/test/tsconfig.json @@ -51,7 +51,7 @@ { "path": "../src/plugins/ui_actions/tsconfig.json" }, { "path": "../src/plugins/url_forwarding/tsconfig.json" }, { "path": "../src/plugins/usage_collection/tsconfig.json" }, - { "path": "../src/plugins/index_pattern_management/tsconfig.json" }, + { "path": "../src/plugins/data_view_management/tsconfig.json" }, { "path": "../src/plugins/visualize/tsconfig.json" }, { "path": "interactive_setup_api_integration/fixtures/test_endpoints/tsconfig.json" }, { "path": "plugin_functional/plugins/core_app_status/tsconfig.json" }, diff --git a/x-pack/plugins/apm/tsconfig.json b/x-pack/plugins/apm/tsconfig.json index 5db20725dd785..2c10a8d175ad1 100644 --- a/x-pack/plugins/apm/tsconfig.json +++ b/x-pack/plugins/apm/tsconfig.json @@ -22,7 +22,6 @@ { "path": "../../../src/plugins/data/tsconfig.json" }, { "path": "../../../src/plugins/embeddable/tsconfig.json" }, { "path": "../../../src/plugins/home/tsconfig.json" }, - { "path": "../../../src/plugins/index_pattern_management/tsconfig.json" }, { "path": "../../../src/plugins/inspector/tsconfig.json" }, { "path": "../../../src/plugins/kibana_react/tsconfig.json" }, { "path": "../../../src/plugins/kibana_utils/tsconfig.json" }, diff --git a/x-pack/plugins/lens/common/expressions/datatable/datatable.ts b/x-pack/plugins/lens/common/expressions/datatable/datatable.ts index 7a6d68eaa6566..1eab399055480 100644 --- a/x-pack/plugins/lens/common/expressions/datatable/datatable.ts +++ b/x-pack/plugins/lens/common/expressions/datatable/datatable.ts @@ -16,6 +16,11 @@ export interface SortingState { direction: 'asc' | 'desc' | 'none'; } +export interface PagingState { + size: number; + enabled: boolean; +} + export interface DatatableArgs { title: string; description?: string; @@ -23,6 +28,7 @@ export interface DatatableArgs { sortingColumnId: SortingState['columnId']; sortingDirection: SortingState['direction']; fitRowToContent?: boolean; + pageSize?: PagingState['size']; } export const getDatatable = ( @@ -62,6 +68,10 @@ export const getDatatable = ( types: ['boolean'], help: '', }, + pageSize: { + types: ['number'], + help: '', + }, }, async fn(...args) { /** Build optimization: prevent adding extra code into initial bundle **/ diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/constants.ts b/x-pack/plugins/lens/public/datatable_visualization/components/constants.ts index 84ee4f0e8a18e..b1053631b0117 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/components/constants.ts +++ b/x-pack/plugins/lens/public/datatable_visualization/components/constants.ts @@ -8,3 +8,4 @@ export const LENS_EDIT_SORT_ACTION = 'sort'; export const LENS_EDIT_RESIZE_ACTION = 'resize'; export const LENS_TOGGLE_ACTION = 'toggle'; +export const LENS_EDIT_PAGESIZE_ACTION = 'pagesize'; diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.test.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.test.tsx index 22407f2b39771..f71d2b9ec6326 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.test.tsx +++ b/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.test.tsx @@ -6,12 +6,16 @@ */ import React from 'react'; -import { ReactWrapper, shallow } from 'enzyme'; +import { ReactWrapper, shallow, mount } from 'enzyme'; import { act } from 'react-dom/test-utils'; import { mountWithIntl } from '@kbn/test/jest'; import { EuiDataGrid } from '@elastic/eui'; import { IAggType } from 'src/plugins/data/public'; -import { IFieldFormat } from 'src/plugins/field_formats/common'; +import { + FieldFormatParams, + IFieldFormat, + SerializedFieldFormat, +} from 'src/plugins/field_formats/common'; import { VisualizationContainer } from '../../visualization_container'; import { EmptyPlaceholder } from '../../shared_components'; import { LensIconChartDatatable } from '../../assets/chart_datatable'; @@ -20,6 +24,9 @@ import { LensMultiTable } from '../../../common'; import { DatatableProps } from '../../../common/expressions'; import { chartPluginMock } from 'src/plugins/charts/public/mocks'; import { IUiSettingsClient } from 'kibana/public'; +import { RenderMode } from 'src/plugins/expressions'; + +import { LENS_EDIT_PAGESIZE_ACTION } from './constants'; function sampleArgs() { const indexPatternId = 'indexPatternId'; @@ -82,7 +89,7 @@ function sampleArgs() { return { data, args }; } -function copyData(data: LensMultiTable): LensMultiTable { +function copyData(data: T): T { return JSON.parse(JSON.stringify(data)); } @@ -658,4 +665,133 @@ describe('DatatableComponent', () => { expect(wrapper.find('[data-test-subj="lnsDataTable-footer-c"]').exists()).toBe(false); }); + + describe('pagination', () => { + it('enables pagination', async () => { + const { data, args } = sampleArgs(); + + args.pageSize = 10; + + const wrapper = mount( + x as IFieldFormat} + dispatchEvent={onDispatchEvent} + getType={jest.fn()} + paletteService={chartPluginMock.createPaletteRegistry()} + uiSettings={{ get: jest.fn() } as unknown as IUiSettingsClient} + renderMode="edit" + /> + ); + + const paginationConfig = wrapper.find(EuiDataGrid).prop('pagination'); + expect(paginationConfig).toBeTruthy(); + expect(paginationConfig?.pageIndex).toBe(0); // should start at 0 + expect(paginationConfig?.pageSize).toBe(args.pageSize); + + // trigger new page + const newIndex = 3; + act(() => paginationConfig?.onChangePage(newIndex)); + wrapper.update(); + + const updatedConfig = wrapper.find(EuiDataGrid).prop('pagination'); + expect(updatedConfig).toBeTruthy(); + expect(updatedConfig?.pageIndex).toBe(newIndex); + expect(updatedConfig?.pageSize).toBe(args.pageSize); + }); + + it('disables pagination by default', async () => { + const { data, args } = sampleArgs(); + + delete args.pageSize; + + const wrapper = mount( + x as IFieldFormat} + dispatchEvent={onDispatchEvent} + getType={jest.fn()} + paletteService={chartPluginMock.createPaletteRegistry()} + uiSettings={{ get: jest.fn() } as unknown as IUiSettingsClient} + renderMode="edit" + /> + ); + + const paginationConfig = wrapper.find(EuiDataGrid).prop('pagination'); + expect(paginationConfig).not.toBeTruthy(); + }); + + it('dynamically toggles pagination', async () => { + const { data, args } = sampleArgs(); + + const argsWithPagination = copyData(args); + argsWithPagination.pageSize = 20; + + const argsWithoutPagination = copyData(args); + delete argsWithoutPagination.pageSize; + + const defaultProps = { + data, + formatFactory: (x?: SerializedFieldFormat) => x as IFieldFormat, + dispatchEvent: onDispatchEvent, + getType: jest.fn(), + paletteService: chartPluginMock.createPaletteRegistry(), + uiSettings: { get: jest.fn() } as unknown as IUiSettingsClient, + renderMode: 'edit' as RenderMode, + }; + + const wrapper = mount( + + ); + wrapper.update(); + + expect(wrapper.find(EuiDataGrid).prop('pagination')).not.toBeTruthy(); + + wrapper.setProps({ args: argsWithPagination }); + wrapper.update(); + + expect(wrapper.find(EuiDataGrid).prop('pagination')).toBeTruthy(); + + wrapper.setProps({ args: argsWithoutPagination }); + wrapper.update(); + + expect(wrapper.find(EuiDataGrid).prop('pagination')).not.toBeTruthy(); + }); + + it('dispatches event when page size changed', async () => { + const { data, args } = sampleArgs(); + + args.pageSize = 10; + + const wrapper = mount( + x as IFieldFormat} + dispatchEvent={onDispatchEvent} + getType={jest.fn()} + paletteService={chartPluginMock.createPaletteRegistry()} + uiSettings={{ get: jest.fn() } as unknown as IUiSettingsClient} + renderMode="edit" + /> + ); + + const paginationConfig = wrapper.find(EuiDataGrid).prop('pagination'); + expect(paginationConfig).toBeTruthy(); + + const sizeToChangeTo = 100; + paginationConfig?.onChangeItemsPerPage(sizeToChangeTo); + + expect(onDispatchEvent).toHaveBeenCalledTimes(1); + expect(onDispatchEvent).toHaveBeenCalledWith({ + name: 'edit', + data: { + action: LENS_EDIT_PAGESIZE_ACTION, + size: sizeToChangeTo, + }, + }); + }); + }); }); diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.tsx index f8a2bb1fabf81..6635ada9a4036 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.tsx +++ b/x-pack/plugins/lens/public/datatable_visualization/components/table_basic.tsx @@ -7,7 +7,7 @@ import './table_basic.scss'; -import React, { useCallback, useMemo, useRef, useState, useContext } from 'react'; +import React, { useCallback, useMemo, useRef, useState, useContext, useEffect } from 'react'; import { i18n } from '@kbn/i18n'; import useDeepCompareEffect from 'react-use/lib/useDeepCompareEffect'; import { @@ -30,6 +30,7 @@ import type { LensSortAction, LensResizeAction, LensToggleAction, + LensPagesizeAction, } from './types'; import { createGridColumns } from './columns'; import { createGridCell } from './cell_value'; @@ -50,6 +51,9 @@ const gridStyle: EuiDataGridStyle = { header: 'underline', }; +export const DEFAULT_PAGE_SIZE = 10; +const PAGE_SIZE_OPTIONS = [DEFAULT_PAGE_SIZE, 20, 30, 50, 100]; + export const DatatableComponent = (props: DatatableRenderProps) => { const [firstTable] = Object.values(props.data.tables); @@ -60,6 +64,22 @@ export const DatatableComponent = (props: DatatableRenderProps) => { }); const [firstLocalTable, updateTable] = useState(firstTable); + // ** Pagination config + const [pagination, setPagination] = useState<{ pageIndex: number; pageSize: number } | undefined>( + undefined + ); + + useEffect(() => { + setPagination( + props.args.pageSize + ? { + pageIndex: 0, + pageSize: props.args.pageSize ?? DEFAULT_PAGE_SIZE, + } + : undefined + ); + }, [props.args.pageSize]); + useDeepCompareEffect(() => { setColumnConfig({ columns: props.args.columns, @@ -102,11 +122,35 @@ export const DatatableComponent = (props: DatatableRenderProps) => { ); const onEditAction = useCallback( - (data: LensSortAction['data'] | LensResizeAction['data'] | LensToggleAction['data']) => { + ( + data: + | LensSortAction['data'] + | LensResizeAction['data'] + | LensToggleAction['data'] + | LensPagesizeAction['data'] + ) => { dispatchEvent({ name: 'edit', data }); }, [dispatchEvent] ); + + const onChangeItemsPerPage = useCallback( + (pageSize) => onEditAction({ action: 'pagesize', size: pageSize }), + [onEditAction] + ); + + // active page isn't persisted, so we manage this state locally + const onChangePage = useCallback( + (pageIndex) => { + setPagination((_pagination) => { + if (_pagination) { + return { pageSize: _pagination?.pageSize, pageIndex }; + } + }); + }, + [setPagination] + ); + const onRowContextMenuClick = useCallback( (data: LensTableRowContextMenuEvent['data']) => { dispatchEvent({ name: 'tableRowContextMenuClick', data }); @@ -346,6 +390,15 @@ export const DatatableComponent = (props: DatatableRenderProps) => { }} > id).join('-') + '-' + pagination.pageSize, + } + : {}) + } aria-label={dataGridAriaLabel} data-test-subj="lnsDataTable" rowHeightsOptions={ @@ -362,6 +415,14 @@ export const DatatableComponent = (props: DatatableRenderProps) => { renderCellValue={renderCellValue} gridStyle={gridStyle} sorting={sorting} + pagination={ + pagination && { + ...pagination, + pageSizeOptions: PAGE_SIZE_OPTIONS, + onChangeItemsPerPage, + onChangePage, + } + } onColumnResize={onColumnResize} toolbarVisibility={false} renderFooterCellValue={renderSummaryRow} diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.test.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.test.tsx new file mode 100644 index 0000000000000..35e5c81cb72c4 --- /dev/null +++ b/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.test.tsx @@ -0,0 +1,125 @@ +/* + * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one + * or more contributor license agreements. Licensed under the Elastic License + * 2.0; you may not use this file except in compliance with the Elastic License + * 2.0. + */ + +import React, { FormEvent } from 'react'; +import { mountWithIntl } from '@kbn/test/jest'; +import { DataTableToolbar } from './toolbar'; +import { DatatableVisualizationState } from '../visualization'; +import { FramePublicAPI, VisualizationToolbarProps } from '../../types'; +import { ToolbarButton } from 'src/plugins/kibana_react/public'; +import { ReactWrapper } from 'enzyme'; +import { PagingState } from '../../../common/expressions'; + +class Harness { + wrapper: ReactWrapper; + + constructor(wrapper: ReactWrapper) { + this.wrapper = wrapper; + } + + togglePopover() { + this.wrapper.find(ToolbarButton).simulate('click'); + } + + public get fitRowToContentSwitch() { + return this.wrapper.find('EuiSwitch[data-test-subj="lens-legend-auto-height-switch"]'); + } + + toggleFitRowToContent() { + this.fitRowToContentSwitch.prop('onChange')!({} as FormEvent); + } + + public get paginationSwitch() { + return this.wrapper.find('EuiSwitch[data-test-subj="lens-table-pagination-switch"]'); + } + + togglePagination() { + this.paginationSwitch.prop('onChange')!({} as FormEvent); + } +} + +describe('datatable toolbar', () => { + const defaultPagingState: PagingState = { + size: 10, + enabled: true, + }; + + let harness: Harness; + let defaultProps: VisualizationToolbarProps; + + beforeEach(() => { + defaultProps = { + setState: jest.fn(), + frame: {} as FramePublicAPI, + state: { + fitRowToContent: false, + } as DatatableVisualizationState, + }; + + harness = new Harness(mountWithIntl()); + }); + + it('should reflect state in the UI', async () => { + harness.togglePopover(); + + expect(harness.fitRowToContentSwitch.prop('checked')).toBe(false); + expect(harness.paginationSwitch.prop('checked')).toBe(false); + + harness.wrapper.setProps({ + state: { + fitRowToContent: true, + paging: defaultPagingState, + }, + }); + + expect(harness.fitRowToContentSwitch.prop('checked')).toBe(true); + expect(harness.paginationSwitch.prop('checked')).toBe(true); + }); + + it('should toggle fit-row-to-content', async () => { + harness.togglePopover(); + + harness.toggleFitRowToContent(); + + expect(defaultProps.setState).toHaveBeenCalledTimes(1); + expect(defaultProps.setState).toHaveBeenNthCalledWith(1, { + fitRowToContent: true, + }); + + harness.wrapper.setProps({ state: { fitRowToContent: true } }); // update state manually + harness.toggleFitRowToContent(); // turn it off + + expect(defaultProps.setState).toHaveBeenCalledTimes(2); + expect(defaultProps.setState).toHaveBeenNthCalledWith(2, { + fitRowToContent: false, + }); + }); + + it('should toggle table pagination', async () => { + harness.togglePopover(); + + harness.togglePagination(); + + expect(defaultProps.setState).toHaveBeenCalledTimes(1); + expect(defaultProps.setState).toHaveBeenNthCalledWith(1, { + paging: defaultPagingState, + fitRowToContent: false, + }); + + // update state manually + harness.wrapper.setProps({ + state: { fitRowToContent: false, paging: defaultPagingState }, + }); + harness.togglePagination(); // turn it off. this should disable pagination but preserve the default page size + + expect(defaultProps.setState).toHaveBeenCalledTimes(2); + expect(defaultProps.setState).toHaveBeenNthCalledWith(2, { + fitRowToContent: false, + paging: { ...defaultPagingState, enabled: false }, + }); + }); +}); diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx index 8da980af64462..e95ae98e37563 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx +++ b/x-pack/plugins/lens/public/datatable_visualization/components/toolbar.tsx @@ -7,15 +7,16 @@ import React, { useCallback } from 'react'; import { i18n } from '@kbn/i18n'; -import { EuiFlexGroup, EuiFormRow, EuiSwitch } from '@elastic/eui'; +import { EuiFlexGroup, EuiFormRow, EuiSwitch, EuiToolTip } from '@elastic/eui'; import { ToolbarPopover } from '../../shared_components'; import type { VisualizationToolbarProps } from '../../types'; import type { DatatableVisualizationState } from '../visualization'; +import { DEFAULT_PAGE_SIZE } from './table_basic'; export function DataTableToolbar(props: VisualizationToolbarProps) { const { state, setState } = props; - const onChange = useCallback(() => { + const onToggleFitRow = useCallback(() => { const current = state.fitRowToContent ?? false; setState({ ...state, @@ -23,6 +24,15 @@ export function DataTableToolbar(props: VisualizationToolbarProps { + const current = state.paging ?? { size: DEFAULT_PAGE_SIZE, enabled: false }; + + setState({ + ...state, + paging: { ...current, enabled: !current.enabled }, + }); + }, [setState, state]); + return ( + + + ); diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/types.ts b/x-pack/plugins/lens/public/datatable_visualization/components/types.ts index f3d81c2d13340..e7be5b78545e8 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/components/types.ts +++ b/x-pack/plugins/lens/public/datatable_visualization/components/types.ts @@ -10,7 +10,12 @@ import { CustomPaletteState, PaletteRegistry } from 'src/plugins/charts/public'; import type { IAggType } from 'src/plugins/data/public'; import type { Datatable, RenderMode } from 'src/plugins/expressions'; import type { ILensInterpreterRenderHandlers, LensEditEvent } from '../../types'; -import { LENS_EDIT_SORT_ACTION, LENS_EDIT_RESIZE_ACTION, LENS_TOGGLE_ACTION } from './constants'; +import { + LENS_EDIT_SORT_ACTION, + LENS_EDIT_RESIZE_ACTION, + LENS_TOGGLE_ACTION, + LENS_EDIT_PAGESIZE_ACTION, +} from './constants'; import type { FormatFactory } from '../../../common'; import type { DatatableProps, LensGridDirection } from '../../../common/expressions'; @@ -28,9 +33,14 @@ export interface LensToggleActionData { columnId: string; } +export interface LensPagesizeActionData { + size: number; +} + export type LensSortAction = LensEditEvent; export type LensResizeAction = LensEditEvent; export type LensToggleAction = LensEditEvent; +export type LensPagesizeAction = LensEditEvent; export type DatatableRenderProps = DatatableProps & { formatFactory: FormatFactory; diff --git a/x-pack/plugins/lens/public/datatable_visualization/visualization.test.tsx b/x-pack/plugins/lens/public/datatable_visualization/visualization.test.tsx index 64d5a6f8f25a6..4f27d33e0a94f 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/visualization.test.tsx +++ b/x-pack/plugins/lens/public/datatable_visualization/visualization.test.tsx @@ -7,7 +7,7 @@ import { Ast } from '@kbn/interpreter/common'; import { buildExpression } from '../../../../../src/plugins/expressions/public'; -import { createMockDatasource, createMockFramePublicAPI } from '../mocks'; +import { createMockDatasource, createMockFramePublicAPI, DatasourceMock } from '../mocks'; import { DatatableVisualizationState, getDatatableVisualization } from './visualization'; import { Operation, @@ -453,11 +453,29 @@ describe('Datatable Visualization', () => { }); describe('#toExpression', () => { - it('reorders the rendered colums based on the order from the datasource', () => { - const datasource = createMockDatasource('test'); - const frame = mockFrame(); - frame.datasourceLayers = { a: datasource.publicAPIMock }; + const getDatatableExpressionArgs = (state: DatatableVisualizationState) => + buildExpression( + datatableVisualization.toExpression(state, frame.datasourceLayers) as Ast + ).findFunction('lens_datatable')[0].arguments; + + const defaultExpressionTableState = { + layerId: 'a', + layerType: layerTypes.DATA, + columns: [{ columnId: 'b' }, { columnId: 'c' }], + }; + + let datasource: DatasourceMock; + let frame: FramePublicAPI; + + beforeEach(() => { + datasource = createMockDatasource('test'); datasource.publicAPIMock.getTableSpec.mockReturnValue([{ columnId: 'c' }, { columnId: 'b' }]); + + frame = mockFrame(); + frame.datasourceLayers = { a: datasource.publicAPIMock }; + }); + + it('reorders the rendered colums based on the order from the datasource', () => { datasource.publicAPIMock.getOperationForColumnId.mockReturnValue({ dataType: 'string', isBucketed: false, // <= make them metrics @@ -465,11 +483,7 @@ describe('Datatable Visualization', () => { }); const expression = datatableVisualization.toExpression( - { - layerId: 'a', - layerType: layerTypes.DATA, - columns: [{ columnId: 'b' }, { columnId: 'c' }], - }, + defaultExpressionTableState, frame.datasourceLayers ) as Ast; @@ -509,10 +523,6 @@ describe('Datatable Visualization', () => { }); it('returns no expression if the metric dimension is not defined', () => { - const datasource = createMockDatasource('test'); - const frame = mockFrame(); - frame.datasourceLayers = { a: datasource.publicAPIMock }; - datasource.publicAPIMock.getTableSpec.mockReturnValue([{ columnId: 'c' }, { columnId: 'b' }]); datasource.publicAPIMock.getOperationForColumnId.mockReturnValue({ dataType: 'string', isBucketed: true, // move it from the metric to the break down by side @@ -520,16 +530,46 @@ describe('Datatable Visualization', () => { }); const expression = datatableVisualization.toExpression( - { - layerId: 'a', - layerType: layerTypes.DATA, - columns: [{ columnId: 'b' }, { columnId: 'c' }], - }, + defaultExpressionTableState, frame.datasourceLayers ); expect(expression).toEqual(null); }); + + it('sets pagination based on state', () => { + expect(getDatatableExpressionArgs({ ...defaultExpressionTableState }).pageSize).toEqual([]); + + expect( + getDatatableExpressionArgs({ + ...defaultExpressionTableState, + paging: { size: 20, enabled: false }, + }).pageSize + ).toEqual([]); + + expect( + getDatatableExpressionArgs({ + ...defaultExpressionTableState, + paging: { size: 20, enabled: true }, + }).pageSize + ).toEqual([20]); + }); + + it('sets fitRowToContent based on state', () => { + expect( + getDatatableExpressionArgs({ ...defaultExpressionTableState }).fitRowToContent + ).toEqual([false]); + + expect( + getDatatableExpressionArgs({ ...defaultExpressionTableState, fitRowToContent: false }) + .fitRowToContent + ).toEqual([false]); + + expect( + getDatatableExpressionArgs({ ...defaultExpressionTableState, fitRowToContent: true }) + .fitRowToContent + ).toEqual([true]); + }); }); describe('#getErrorMessages', () => { @@ -628,5 +668,23 @@ describe('Datatable Visualization', () => { columns: [{ columnId: 'saved', width: undefined }], }); }); + + it('should update page size', () => { + const currentState: DatatableVisualizationState = { + layerId: 'foo', + layerType: layerTypes.DATA, + columns: [{ columnId: 'saved', width: 5000 }], + paging: { enabled: true, size: 10 }, + }; + expect( + datatableVisualization.onEditAction!(currentState, { + name: 'edit', + data: { action: 'pagesize', size: 30 }, + }) + ).toEqual({ + ...currentState, + paging: { enabled: true, size: 30 }, + }); + }); }); }); diff --git a/x-pack/plugins/lens/public/datatable_visualization/visualization.tsx b/x-pack/plugins/lens/public/datatable_visualization/visualization.tsx index a953da4c380f0..903dd7bcaa74a 100644 --- a/x-pack/plugins/lens/public/datatable_visualization/visualization.tsx +++ b/x-pack/plugins/lens/public/datatable_visualization/visualization.tsx @@ -22,7 +22,7 @@ import { TableDimensionEditor } from './components/dimension_editor'; import { CUSTOM_PALETTE } from '../shared_components/coloring/constants'; import { getStopsForFixedMode } from '../shared_components'; import { LayerType, layerTypes } from '../../common'; -import { getDefaultSummaryLabel } from '../../common/expressions'; +import { getDefaultSummaryLabel, PagingState } from '../../common/expressions'; import type { ColumnState, SortingState } from '../../common/expressions'; import { DataTableToolbar } from './components/toolbar'; export interface DatatableVisualizationState { @@ -31,6 +31,7 @@ export interface DatatableVisualizationState { layerType: LayerType; sorting?: SortingState; fitRowToContent?: boolean; + paging?: PagingState; } const visualizationLabel = i18n.translate('xpack.lens.datatable.label', { @@ -391,6 +392,7 @@ export const getDatatableVisualization = ({ sortingColumnId: [state.sorting?.columnId || ''], sortingDirection: [state.sorting?.direction || 'none'], fitRowToContent: [state.fitRowToContent ?? false], + pageSize: state.paging?.enabled ? [state.paging.size] : [], }, }, ], @@ -421,10 +423,11 @@ export const getDatatableVisualization = ({ }, }; case 'toggle': + const toggleColumnId = event.data.columnId; return { ...state, columns: state.columns.map((column) => { - if (column.columnId === event.data.columnId) { + if (column.columnId === toggleColumnId) { return { ...column, hidden: !column.hidden, @@ -436,10 +439,11 @@ export const getDatatableVisualization = ({ }; case 'resize': const targetWidth = event.data.width; + const resizeColumnId = event.data.columnId; return { ...state, columns: state.columns.map((column) => { - if (column.columnId === event.data.columnId) { + if (column.columnId === resizeColumnId) { return { ...column, width: targetWidth, @@ -449,6 +453,14 @@ export const getDatatableVisualization = ({ } }), }; + case 'pagesize': + return { + ...state, + paging: { + enabled: state.paging?.enabled || false, + size: event.data.size, + }, + }; default: return state; } diff --git a/x-pack/plugins/lens/public/types.ts b/x-pack/plugins/lens/public/types.ts index ab6f1d8d55082..35620982447a5 100644 --- a/x-pack/plugins/lens/public/types.ts +++ b/x-pack/plugins/lens/public/types.ts @@ -26,6 +26,7 @@ import type { LensSortActionData, LensResizeActionData, LensToggleActionData, + LensPagesizeActionData, } from './datatable_visualization/components/types'; import type { UiActionsStart, @@ -37,6 +38,7 @@ import { LENS_EDIT_SORT_ACTION, LENS_EDIT_RESIZE_ACTION, LENS_TOGGLE_ACTION, + LENS_EDIT_PAGESIZE_ACTION, } from './datatable_visualization/components/constants'; import type { LensInspector } from './lens_inspector_service'; @@ -783,6 +785,7 @@ export interface LensEditContextMapping { [LENS_EDIT_SORT_ACTION]: LensSortActionData; [LENS_EDIT_RESIZE_ACTION]: LensResizeActionData; [LENS_TOGGLE_ACTION]: LensToggleActionData; + [LENS_EDIT_PAGESIZE_ACTION]: LensPagesizeActionData; } type LensEditSupportedActions = keyof LensEditContextMapping; diff --git a/x-pack/plugins/ml/public/application/app.tsx b/x-pack/plugins/ml/public/application/app.tsx index de212cbe4916e..5334f420698ab 100644 --- a/x-pack/plugins/ml/public/application/app.tsx +++ b/x-pack/plugins/ml/public/application/app.tsx @@ -28,10 +28,7 @@ import { mlApiServicesProvider } from './services/ml_api_service'; import { HttpService } from './services/http_service'; import { ML_APP_LOCATOR, ML_PAGES } from '../../common/constants/locator'; -export type MlDependencies = Omit< - MlSetupDependencies, - 'share' | 'indexPatternManagement' | 'fieldFormats' -> & +export type MlDependencies = Omit & MlStartDependencies; interface AppProps { diff --git a/x-pack/plugins/ml/tsconfig.json b/x-pack/plugins/ml/tsconfig.json index 0c108f8b3b8a5..87ba8c50c3a88 100644 --- a/x-pack/plugins/ml/tsconfig.json +++ b/x-pack/plugins/ml/tsconfig.json @@ -20,7 +20,6 @@ "references": [ { "path": "../../../src/core/tsconfig.json" }, { "path": "../../../src/plugins/embeddable/tsconfig.json" }, - { "path": "../../../src/plugins/index_pattern_management/tsconfig.json" }, { "path": "../../../src/plugins/data_views/tsconfig.json" }, { "path": "../cloud/tsconfig.json" }, { "path": "../features/tsconfig.json" }, diff --git a/x-pack/plugins/transform/tsconfig.json b/x-pack/plugins/transform/tsconfig.json index 99e8baf3f92fc..9d13498814dc4 100644 --- a/x-pack/plugins/transform/tsconfig.json +++ b/x-pack/plugins/transform/tsconfig.json @@ -16,7 +16,6 @@ ], "references": [ { "path": "../../../src/core/tsconfig.json" }, - { "path": "../../../src/plugins/index_pattern_management/tsconfig.json" }, { "path": "../features/tsconfig.json" }, { "path": "../license_management/tsconfig.json" }, { "path": "../licensing/tsconfig.json" }, diff --git a/x-pack/test/tsconfig.json b/x-pack/test/tsconfig.json index 1ffe3834d782d..752bf09d96df0 100644 --- a/x-pack/test/tsconfig.json +++ b/x-pack/test/tsconfig.json @@ -29,7 +29,7 @@ { "path": "../../src/plugins/es_ui_shared/tsconfig.json" }, { "path": "../../src/plugins/expressions/tsconfig.json" }, { "path": "../../src/plugins/home/tsconfig.json" }, - { "path": "../../src/plugins/index_pattern_management/tsconfig.json" }, + { "path": "../../src/plugins/data_view_management/tsconfig.json" }, { "path": "../../src/plugins/kibana_overview/tsconfig.json" }, { "path": "../../src/plugins/kibana_react/tsconfig.json" }, { "path": "../../src/plugins/kibana_usage_collection/tsconfig.json" },