From deea4d99672195ca219696e2eb2e3d9dc7220d04 Mon Sep 17 00:00:00 2001 From: Spencer Date: Wed, 19 Feb 2020 07:33:45 -0700 Subject: [PATCH] Unskip flaky tests (#57715) (#57947) * Revert "Skip flaky test (#57675)" This reverts commit c965a9efa8490539327a04bb005987c72fb1e58d. * Revert "disable firefox smoke tests so we can fix flakiness out of band" This reverts commit fe3864282a0e3c26affc1bf3f34e235833f58041. * Revert "skip flaky tests (#57643)" This reverts commit b22045433ec5dee20353624b0b23d28979796871. * Revert "skip flaky suite (#50018)" This reverts commit b058dc2fe73abc2e00321687f27a7c15b63534c0. * Revert "skip settings tests (#57608)" This reverts commit 64625b282cc0042fcec96459bec6376c00db4451. * Revert "skip failing suite (#44631)" This reverts commit 8aa718d11e68e0ac422271e5e8a91b6a46504e1b. * Revert "skip flaky suite (#44631)" This reverts commit 6e4efdfa7cccab3c3053414334b90a3feff4e3c3. * Revert "skip flaky test (#57377)" This reverts commit 59672ab5da6d616fb77f564bd4bcff74fd0a5fa1. * Revert "Skip save query tests (#57589)" This reverts commit 431a1e9c894d0251da968a2dee65ac76da2e7b92. * remove hard coded timeouts * Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band"" This reverts commit 271f8814d58e6c64be2df02d5caff3132d8edfc6. * Revert "remove hard coded timeouts" This reverts commit 8b843d0aa6d59c12ff179bec99006391f89639b1. * wait for managementHome to exist, don't bail early if it's missing * Revert "skip flaky suite (#45244)" This reverts commit 0cee1a4adb0940ed911daf2ddf50ff15f40fa539. * extend timeouts for common existsOrFail() calls Co-authored-by: Elastic Machine Co-authored-by: Elastic Machine --- test/functional/page_objects/common_page.ts | 2 +- .../advanced_settings_security.ts | 6 ++-- .../advanced_settings_spaces.ts | 11 +++--- .../feature_controls/dashboard_security.ts | 30 ++++++++++------ .../feature_controls/dashboard_spaces.ts | 19 ++++++---- .../feature_controls/dev_tools_security.ts | 7 ++-- .../feature_controls/dev_tools_spaces.ts | 7 ++-- .../feature_controls/discover_security.ts | 6 ++-- .../feature_controls/discover_spaces.ts | 7 ++-- .../index_patterns_security.ts | 3 +- .../feature_controls/index_patterns_spaces.ts | 6 ++-- .../test/functional/apps/rollup_job/tsvb.js | 3 +- .../feature_controls/visualize_security.ts | 36 +++++++++++++------ .../feature_controls/visualize_spaces.ts | 14 ++++---- .../apps/triggers_actions_ui/details.ts | 2 +- 15 files changed, 99 insertions(+), 60 deletions(-) diff --git a/test/functional/page_objects/common_page.ts b/test/functional/page_objects/common_page.ts index 75a15cc16db2e..08232322f297f 100644 --- a/test/functional/page_objects/common_page.ts +++ b/test/functional/page_objects/common_page.ts @@ -114,7 +114,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo ); await find.byCssSelector( '[data-test-subj="kibanaChrome"] nav:not(.ng-hide)', - 2 * defaultFindTimeout + 6 * defaultFindTimeout ); await browser.get(appUrl); currentUrl = await browser.getCurrentUrl(); diff --git a/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts b/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts index 8f902471cf6cd..261a853387619 100644 --- a/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts +++ b/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); const security = getService('security'); + const config = getService('config'); const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']); const appsMenu = getService('appsMenu'); const testSubjects = getService('testSubjects'); @@ -178,14 +179,13 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { expect(navLinks).to.eql(['Discover', 'Stack Management']); }); - // https://github.com/elastic/kibana/issues/57377 - it.skip(`does not allow navigation to advanced settings; redirects to management home`, async () => { + it(`does not allow navigation to advanced settings; redirects to management home`, async () => { await PageObjects.common.navigateToActualUrl('kibana', 'management/kibana/settings', { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); await testSubjects.existOrFail('managementHome', { - timeout: 10000, + timeout: config.get('timeouts.waitFor'), }); }); }); diff --git a/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts b/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts index aceebf7219c3f..53202089e8961 100644 --- a/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts +++ b/x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts @@ -12,9 +12,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']); const testSubjects = getService('testSubjects'); const appsMenu = getService('appsMenu'); + const config = getService('config'); - // FLAKY: https://github.com/elastic/kibana/issues/57377 - describe.skip('spaces feature controls', () => { + describe('spaces feature controls', () => { before(async () => { await esArchiver.loadIfNeeded('logstash_functional'); }); @@ -58,8 +58,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { }); }); - // https://github.com/elastic/kibana/issues/57413 - describe.skip('space with Advanced Settings disabled', () => { + describe('space with Advanced Settings disabled', () => { before(async () => { // we need to load the following in every situation as deleting // a space deletes all of the associated saved objects @@ -82,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('managementHome'); + await testSubjects.existOrFail('managementHome', { + timeout: config.get('timeouts.waitFor'), + }); }); }); }); diff --git a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts index ad09bc5c89143..98035d2558b09 100644 --- a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts +++ b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts @@ -13,6 +13,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const security = getService('security'); + const config = getService('config'); const PageObjects = getPageObjects(['common', 'dashboard', 'security', 'spaceSelector', 'share']); const appsMenu = getService('appsMenu'); const panelActions = getService('dashboardPanelActions'); @@ -21,8 +22,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const queryBar = getService('queryBar'); const savedQueryManagementComponent = getService('savedQueryManagementComponent'); - // FLAKY: https://github.com/elastic/kibana/issues/44631 - describe.skip('dashboard security', () => { + describe('dashboard security', () => { before(async () => { await esArchiver.load('dashboard/feature_controls/security'); await esArchiver.loadIfNeeded('logstash_functional'); @@ -88,7 +88,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 }); + await testSubjects.existOrFail('dashboardLandingPage', { + timeout: config.get('timeouts.waitFor'), + }); await testSubjects.existOrFail('newItemButton'); }); @@ -105,7 +107,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 }); + await testSubjects.existOrFail('emptyDashboardWidget', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`can view existing Dashboard`, async () => { @@ -113,7 +117,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 }); + await testSubjects.existOrFail('embeddablePanelHeading-APie', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`does not allow a visualization to be edited`, async () => { @@ -266,7 +272,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 }); + await testSubjects.existOrFail('dashboardLandingPage', { + timeout: config.get('timeouts.waitFor'), + }); await testSubjects.missingOrFail('newItemButton'); }); @@ -291,7 +299,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 }); + await testSubjects.existOrFail('embeddablePanelHeading-APie', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`Permalinks doesn't show create short-url button`, async () => { @@ -377,7 +387,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`create new dashboard redirects to the home page`, async () => { @@ -401,7 +411,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit dashboard for object which exists redirects to the home page`, async () => { @@ -409,7 +419,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts index 002ae627c488d..1f4f0f33a061e 100644 --- a/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts +++ b/x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts @@ -12,6 +12,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); + const config = getService('config'); const spacesService = getService('spaces'); const PageObjects = getPageObjects([ 'common', @@ -64,7 +65,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 }); + await testSubjects.existOrFail('dashboardLandingPage', { + timeout: config.get('timeouts.waitFor'), + }); await testSubjects.existOrFail('newItemButton'); }); @@ -78,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 }); + await testSubjects.existOrFail('emptyDashboardWidget', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`can view existing Dashboard`, async () => { @@ -87,7 +92,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 }); + await testSubjects.existOrFail('embeddablePanelHeading-APie', { + timeout: config.get('timeouts.waitFor'), + }); }); }); @@ -126,7 +133,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit dashboard for object which doesn't exist redirects to the home page`, async () => { @@ -139,7 +146,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit dashboard for object which exists redirects to the home page`, async () => { @@ -148,7 +155,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts b/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts index 9db9a913e9a4b..162bf23c29490 100644 --- a/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts +++ b/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const security = getService('security'); const PageObjects = getPageObjects(['common', 'console', 'security']); + const config = getService('config'); const appsMenu = getService('appsMenu'); const testSubjects = getService('testSubjects'); const grokDebugger = getService('grokDebugger'); @@ -232,21 +233,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.common.navigateToUrl('console', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`navigating to search profiler redirect to homepage`, async () => { await PageObjects.common.navigateToUrl('searchProfiler', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`navigating to grok debugger redirect to homepage`, async () => { await PageObjects.common.navigateToUrl('grokDebugger', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts b/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts index f917792eea027..561b7f64eb77d 100644 --- a/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts +++ b/x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); + const config = getService('config'); const spacesService = getService('spaces'); const PageObjects = getPageObjects([ 'common', @@ -92,21 +93,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.common.navigateToUrl('console', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`navigating to search profiler redirect to homepage`, async () => { await PageObjects.common.navigateToUrl('searchProfiler', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`navigating to grok debugger redirect to homepage`, async () => { await PageObjects.common.navigateToUrl('grokDebugger', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts b/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts index 8669577f202a7..a1d6bfefdea64 100644 --- a/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts +++ b/x-pack/test/functional/apps/discover/feature_controls/discover_security.ts @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const security = getService('security'); const globalNav = getService('globalNav'); + const config = getService('config'); const PageObjects = getPageObjects([ 'common', 'discover', @@ -27,8 +28,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.timePicker.setDefaultAbsoluteRange(); } - // FLAKY: https://github.com/elastic/kibana/issues/45348 - describe.skip('security', () => { + describe('security', () => { before(async () => { await esArchiver.load('discover/feature_controls/security'); await esArchiver.loadIfNeeded('logstash_functional'); @@ -305,7 +305,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.common.navigateToUrl('discover', '', { ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts b/x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts index c38dda536f253..ba7d4077b2740 100644 --- a/x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts +++ b/x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); + const config = getService('config'); const spacesService = getService('spaces'); const PageObjects = getPageObjects([ 'common', @@ -59,7 +60,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.common.navigateToApp('discover', { basePath: '/s/custom_space', }); - await testSubjects.existOrFail('discoverSaveButton', { timeout: 10000 }); + await testSubjects.existOrFail('discoverSaveButton', { + timeout: config.get('timeouts.waitFor'), + }); }); it('shows "visualize" field button', async () => { @@ -156,7 +159,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { basePath: '/s/custom_space', ensureCurrentUrl: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts b/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts index ed25816e68712..0783767d8f152 100644 --- a/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts +++ b/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts @@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); const security = getService('security'); + const config = getService('config'); const PageObjects = getPageObjects(['common', 'settings', 'security']); const appsMenu = getService('appsMenu'); const testSubjects = getService('testSubjects'); @@ -190,7 +191,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces.ts b/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces.ts index b303ad23f8977..d4422e94d10cf 100644 --- a/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces.ts +++ b/x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces.ts @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); + const config = getService('config'); const spacesService = getService('spaces'); const PageObjects = getPageObjects(['common', 'settings', 'security']); const testSubjects = getService('testSubjects'); @@ -52,8 +53,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { }); }); - // https://github.com/elastic/kibana/issues/57601 - describe.skip('space with Index Patterns disabled', () => { + describe('space with Index Patterns disabled', () => { before(async () => { // we need to load the following in every situation as deleting // a space deletes all of the associated saved objects @@ -76,7 +76,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/rollup_job/tsvb.js b/x-pack/test/functional/apps/rollup_job/tsvb.js index b697e751ef550..f3782c4c91644 100644 --- a/x-pack/test/functional/apps/rollup_job/tsvb.js +++ b/x-pack/test/functional/apps/rollup_job/tsvb.js @@ -21,8 +21,7 @@ export default function({ getService, getPageObjects }) { 'timePicker', ]); - // https://github.com/elastic/kibana/issues/56816 - describe.skip('tsvb integration', function() { + describe('tsvb integration', function() { //Since rollups can only be created once with the same name (even if you delete it), //we add the Date.now() to avoid name collision if you run the tests locally back to back. const rollupJobName = `tsvb-test-rollup-job-${Date.now()}`; diff --git a/x-pack/test/functional/apps/visualize/feature_controls/visualize_security.ts b/x-pack/test/functional/apps/visualize/feature_controls/visualize_security.ts index 6db8ad28deccb..1876f46038326 100644 --- a/x-pack/test/functional/apps/visualize/feature_controls/visualize_security.ts +++ b/x-pack/test/functional/apps/visualize/feature_controls/visualize_security.ts @@ -9,6 +9,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const security = getService('security'); + const config = getService('config'); const PageObjects = getPageObjects([ 'common', 'visualize', @@ -24,8 +25,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const queryBar = getService('queryBar'); const savedQueryManagementComponent = getService('savedQueryManagementComponent'); - // FLAKY: https://github.com/elastic/kibana/issues/50018 - describe.skip('feature controls security', () => { + describe('feature controls security', () => { before(async () => { await esArchiver.load('visualize/default'); await esArchiver.loadIfNeeded('logstash_functional'); @@ -81,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { it(`landing page shows "Create new Visualization" button`, async () => { await PageObjects.visualize.gotoVisualizationLandingPage(); - await testSubjects.existOrFail('visualizeLandingPage', { timeout: 10000 }); + await testSubjects.existOrFail('visualizeLandingPage', { + timeout: config.get('timeouts.waitFor'), + }); await testSubjects.existOrFail('newItemButton'); }); @@ -94,7 +96,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('visualizationLoader', { timeout: 10000 }); + await testSubjects.existOrFail('visualizationLoader', { + timeout: config.get('timeouts.waitFor'), + }); }); it('can save existing Visualization', async () => { @@ -102,7 +106,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('visualizeSaveButton', { timeout: 10000 }); + await testSubjects.existOrFail('visualizeSaveButton', { + timeout: config.get('timeouts.waitFor'), + }); }); it('Embed code shows create short-url button', async () => { @@ -199,7 +205,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { it(`landing page shows "Create new Visualization" button`, async () => { await PageObjects.visualize.gotoVisualizationLandingPage(); - await testSubjects.existOrFail('visualizeLandingPage', { timeout: 10000 }); + await testSubjects.existOrFail('visualizeLandingPage', { + timeout: config.get('timeouts.waitFor'), + }); await testSubjects.existOrFail('newItemButton'); }); @@ -212,7 +220,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('visualizationLoader', { timeout: 10000 }); + await testSubjects.existOrFail('visualizationLoader', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`can't save existing Visualization`, async () => { @@ -220,8 +230,12 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('shareTopNavButton', { timeout: 10000 }); - await testSubjects.missingOrFail('visualizeSaveButton', { timeout: 10000 }); + await testSubjects.existOrFail('shareTopNavButton', { + timeout: config.get('timeouts.waitFor'), + }); + await testSubjects.missingOrFail('visualizeSaveButton', { + timeout: config.get('timeouts.waitFor'), + }); }); it(`Embed Code doesn't show create short-url button`, async () => { @@ -305,7 +319,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit page redirects to home page`, async () => { @@ -313,7 +327,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces.ts b/x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces.ts index b24c537d25085..b1cb156caad90 100644 --- a/x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces.ts +++ b/x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces.ts @@ -9,6 +9,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export default function({ getPageObjects, getService }: FtrProviderContext) { const esArchiver = getService('esArchiver'); + const config = getService('config'); const spacesService = getService('spaces'); const PageObjects = getPageObjects([ 'common', @@ -20,8 +21,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const appsMenu = getService('appsMenu'); - // FLAKY: https://github.com/elastic/kibana/issues/45244 - describe.skip('visualize', () => { + describe('visualize', () => { before(async () => { await esArchiver.loadIfNeeded('logstash_functional'); }); @@ -62,7 +62,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('visualizationLoader', { timeout: 10000 }); + await testSubjects.existOrFail('visualizationLoader', { + timeout: config.get('timeouts.waitFor'), + }); }); }); @@ -97,7 +99,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { ensureCurrentUrl: false, shouldLoginIfPrompted: false, }); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit visualization for object which doesn't exist redirects to the home page`, async () => { @@ -110,7 +112,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); it(`edit visualization for object which exists redirects to the home page`, async () => { @@ -123,7 +125,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { shouldLoginIfPrompted: false, } ); - await testSubjects.existOrFail('homeApp', { timeout: 10000 }); + await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') }); }); }); }); diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts index 6d83e0bbf1df7..95371b5b501f5 100644 --- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts +++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts @@ -204,7 +204,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { }); }); - it.skip('renders the active alert instances', async () => { + it('renders the active alert instances', async () => { const testBeganAt = moment().utc(); // Verify content