From 6f6c2cf042a5a14e5fb0bec90cdf46637f87fc82 Mon Sep 17 00:00:00 2001 From: Shahzad Date: Tue, 3 Nov 2020 16:43:07 +0100 Subject: [PATCH 1/4] [Uptime] Add-aria-labels-for-filter-inputs (#82249) --- .../__tests__/__snapshots__/filter_popover.test.tsx.snap | 2 ++ .../components/overview/filter_group/filter_popover.tsx | 8 +++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/uptime/public/components/overview/filter_group/__tests__/__snapshots__/filter_popover.test.tsx.snap b/x-pack/plugins/uptime/public/components/overview/filter_group/__tests__/__snapshots__/filter_popover.test.tsx.snap index 49fce8af9414e..47efe8946d0b6 100644 --- a/x-pack/plugins/uptime/public/components/overview/filter_group/__tests__/__snapshots__/filter_popover.test.tsx.snap +++ b/x-pack/plugins/uptime/public/components/overview/filter_group/__tests__/__snapshots__/filter_popover.test.tsx.snap @@ -24,6 +24,7 @@ exports[`FilterPopover component does not show item list when loading 1`] = ` > setSearchQuery(query)} + aria-label={i18n.translate('xpack.uptime.filterPopout.searchMessage.ariaLabel', { + defaultMessage: 'Search for {title}', + values: { + title: title.toLowerCase(), + }, + })} placeholder={ loading ? i18n.translate('xpack.uptime.filterPopout.loadingMessage', { @@ -108,7 +114,7 @@ export const FilterPopover = ({ : i18n.translate('xpack.uptime.filterPopout.searchMessage', { defaultMessage: 'Search {title}', values: { - title, + title: title.toLowerCase(), }, }) } From 593a607be08f90c00f83920d524712477e63e0e6 Mon Sep 17 00:00:00 2001 From: Stratoula Kalafateli Date: Tue, 3 Nov 2020 18:21:24 +0200 Subject: [PATCH 2/4] [TableListView] Fix table scope issues (#82105) * [TableListView] Fix table scope issues * Replace the default tableCaption with another one that describes what the table does * Make the accessibility props required in order to always add them in the future Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../__snapshots__/dashboard_listing.test.js.snap | 12 ++++++++++++ .../public/application/listing/dashboard_listing.js | 4 ++++ .../public/table_list_view/table_list_view.tsx | 10 ++++++++++ .../application/components/visualize_listing.tsx | 4 ++++ x-pack/plugins/graph/public/components/listing.tsx | 4 ++++ 5 files changed, 34 insertions(+) diff --git a/src/plugins/dashboard/public/application/listing/__snapshots__/dashboard_listing.test.js.snap b/src/plugins/dashboard/public/application/listing/__snapshots__/dashboard_listing.test.js.snap index 94a9c646a403c..d68011d2f7fde 100644 --- a/src/plugins/dashboard/public/application/listing/__snapshots__/dashboard_listing.test.js.snap +++ b/src/plugins/dashboard/public/application/listing/__snapshots__/dashboard_listing.test.js.snap @@ -31,7 +31,9 @@ exports[`after fetch hideWriteControls 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { @@ -134,7 +136,9 @@ exports[`after fetch initialFilter 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { @@ -237,7 +241,9 @@ exports[`after fetch renders call to action when no dashboards exist 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { @@ -340,7 +346,9 @@ exports[`after fetch renders table rows 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { @@ -443,7 +451,9 @@ exports[`after fetch renders warning when listingLimit is exceeded 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { @@ -545,7 +555,9 @@ exports[`renders empty page in before initial fetch to avoid flickering 1`] = ` /> } + rowHeader="title" searchFilters={Array []} + tableCaption="Dashboards" tableColumns={ Array [ Object { diff --git a/src/plugins/dashboard/public/application/listing/dashboard_listing.js b/src/plugins/dashboard/public/application/listing/dashboard_listing.js index 31e5bcf83150b..1af89f4bcb71f 100644 --- a/src/plugins/dashboard/public/application/listing/dashboard_listing.js +++ b/src/plugins/dashboard/public/application/listing/dashboard_listing.js @@ -43,6 +43,7 @@ export class DashboardListing extends React.Component { ); } diff --git a/src/plugins/visualize/public/application/components/visualize_listing.tsx b/src/plugins/visualize/public/application/components/visualize_listing.tsx index 2a4b1df743800..2edabbf46f9d8 100644 --- a/src/plugins/visualize/public/application/components/visualize_listing.tsx +++ b/src/plugins/visualize/public/application/components/visualize_listing.tsx @@ -154,6 +154,9 @@ export const VisualizeListing = () => { // we allow users to create visualizations even if they can't save them // for data exploration purposes createItem={createNewVis} + tableCaption={i18n.translate('visualize.listing.table.listTitle', { + defaultMessage: 'Visualizations', + })} findItems={fetchItems} deleteItems={visualizeCapabilities.delete ? deleteItems : undefined} editItem={visualizeCapabilities.save ? editItem : undefined} @@ -161,6 +164,7 @@ export const VisualizeListing = () => { listingLimit={listingLimit} initialPageSize={savedObjectsPublic.settings.getPerPage()} initialFilter={''} + rowHeader="title" noItemsFragment={noItemsFragment} entityName={i18n.translate('visualize.listing.table.entityName', { defaultMessage: 'visualization', diff --git a/x-pack/plugins/graph/public/components/listing.tsx b/x-pack/plugins/graph/public/components/listing.tsx index b89ee2489d7f3..8423ac1184186 100644 --- a/x-pack/plugins/graph/public/components/listing.tsx +++ b/x-pack/plugins/graph/public/components/listing.tsx @@ -31,7 +31,11 @@ export function Listing(props: ListingProps) { return ( Date: Tue, 3 Nov 2020 17:24:55 +0100 Subject: [PATCH 3/4] [Discover] Unskip functional sidebar test (#81188) --- test/functional/apps/discover/_sidebar.js | 3 +-- test/functional/page_objects/discover_page.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/test/functional/apps/discover/_sidebar.js b/test/functional/apps/discover/_sidebar.js index f7784b739336b..ce7ebff9cce74 100644 --- a/test/functional/apps/discover/_sidebar.js +++ b/test/functional/apps/discover/_sidebar.js @@ -25,8 +25,7 @@ export default function ({ getService, getPageObjects }) { const kibanaServer = getService('kibanaServer'); const PageObjects = getPageObjects(['common', 'discover', 'timePicker']); - // FLAKY: https://github.com/elastic/kibana/issues/80914 - describe.skip('discover sidebar', function describeIndexTests() { + describe('discover sidebar', function describeIndexTests() { before(async function () { // delete .kibana index and update configDoc await kibanaServer.uiSettings.replace({ diff --git a/test/functional/page_objects/discover_page.ts b/test/functional/page_objects/discover_page.ts index 60532c81493f9..2423f66a4b34e 100644 --- a/test/functional/page_objects/discover_page.ts +++ b/test/functional/page_objects/discover_page.ts @@ -349,7 +349,7 @@ export function DiscoverPageProvider({ getService, getPageObjects }: FtrProvider public async closeSidebarFieldFilter() { await testSubjects.click('toggleFieldFilterButton'); - await testSubjects.missingOrFail('filterSelectionPanel', { allowHidden: true }); + await testSubjects.missingOrFail('filterSelectionPanel'); } public async waitForChartLoadingComplete(renderCount: number) { From c974f56e1ca9ddd0c5f0460fd2737ae8c580716f Mon Sep 17 00:00:00 2001 From: Clint Andrew Hall Date: Tue, 3 Nov 2020 10:32:47 -0600 Subject: [PATCH 4/4] Team:Presentation Code Owners and automation changes (#82343) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .github/CODEOWNERS | 28 +++++++++---------- .github/workflows/pr-project-assigner.yml | 2 +- .github/workflows/project-assigner.yml | 2 +- .../src/release_notes_config.ts | 8 +++--- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 915f0f799b210..27532f0f377f9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -60,7 +60,7 @@ /src/plugins/expressions/ @elastic/kibana-app-arch /src/plugins/inspector/ @elastic/kibana-app-arch /src/plugins/kibana_react/ @elastic/kibana-app-arch -/src/plugins/kibana_react/public/code_editor @elastic/kibana-canvas +/src/plugins/kibana_react/public/code_editor @elastic/kibana-presentation /src/plugins/kibana_utils/ @elastic/kibana-app-arch /src/plugins/navigation/ @elastic/kibana-app-arch /src/plugins/share/ @elastic/kibana-app-arch @@ -104,19 +104,19 @@ /x-pack/legacy/plugins/beats_management/ @elastic/beats #CC# /x-pack/plugins/beats_management/ @elastic/beats -# Canvas -/src/plugins/dashboard/ @elastic/kibana-canvas -/src/plugins/input_control_vis/ @elastic/kibana-canvas -/src/plugins/vis_type_markdown/ @elastic/kibana-canvas -/x-pack/plugins/canvas/ @elastic/kibana-canvas -/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-canvas -/x-pack/test/functional/apps/canvas/ @elastic/kibana-canvas -#CC# /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-canvas -#CC# /src/legacy/core_plugins/input_control_vis @elastic/kibana-canvas -#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-canvas -#CC# /x-pack/legacy/plugins/canvas/ @elastic/kibana-canvas -#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-canvas -#CC# /x-pack/legacy/plugins/dashboard_mode/ @elastic/kibana-canvas +# Presentation +/src/plugins/dashboard/ @elastic/kibana-presentation +/src/plugins/input_control_vis/ @elastic/kibana-presentation +/src/plugins/vis_type_markdown/ @elastic/kibana-presentation +/x-pack/plugins/canvas/ @elastic/kibana-presentation +/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation +/x-pack/test/functional/apps/canvas/ @elastic/kibana-presentation +#CC# /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-presentation +#CC# /src/legacy/core_plugins/input_control_vis @elastic/kibana-presentation +#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation +#CC# /x-pack/legacy/plugins/canvas/ @elastic/kibana-presentation +#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-presentation +#CC# /x-pack/legacy/plugins/dashboard_mode/ @elastic/kibana-presentation # Core UI # Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon diff --git a/.github/workflows/pr-project-assigner.yml b/.github/workflows/pr-project-assigner.yml index ca5d0b9864f99..3ff3bb7fb97d1 100644 --- a/.github/workflows/pr-project-assigner.yml +++ b/.github/workflows/pr-project-assigner.yml @@ -18,4 +18,4 @@ jobs: # { "label": "Team:AppArch", "projectNumber": 37, "columnName": "Review in progress" }, # { "label": "Feature:Lens", "projectNumber": 32, "columnName": "In progress" }, -# { "label": "Team:Canvas", "projectNumber": 38, "columnName": "Review in progress" } \ No newline at end of file +# { "label": "Feature:Canvas", "projectNumber": 38, "columnName": "Review in progress" } diff --git a/.github/workflows/project-assigner.yml b/.github/workflows/project-assigner.yml index eb5827e121c74..96284345d1631 100644 --- a/.github/workflows/project-assigner.yml +++ b/.github/workflows/project-assigner.yml @@ -11,7 +11,7 @@ jobs: uses: elastic/github-actions/project-assigner@v2.0.0 id: project_assigner with: - issue-mappings: '[{"label": "Team:AppArch", "projectNumber": 37, "columnName": "To triage"}, {"label": "Feature:Lens", "projectNumber": 32, "columnName": "Long-term goals"}, {"label": "Team:Canvas", "projectNumber": 38, "columnName": "Inbox"}]' + issue-mappings: '[{"label": "Team:AppArch", "projectNumber": 37, "columnName": "To triage"}, {"label": "Feature:Lens", "projectNumber": 32, "columnName": "Long-term goals"}, {"label": "Feature:Canvas", "projectNumber": 38, "columnName": "Inbox"}, {"label": "Feature:Dashboard", "projectNumber": 68, "columnName": "Inbox"}, {"label": "Feature:Drilldowns", "projectNumber": 68, "columnName": "Inbox"}]' ghToken: ${{ secrets.PROJECT_ASSIGNER_TOKEN }} diff --git a/packages/kbn-release-notes/src/release_notes_config.ts b/packages/kbn-release-notes/src/release_notes_config.ts index 88ab5dfa2fda4..f0e7e76cb4612 100644 --- a/packages/kbn-release-notes/src/release_notes_config.ts +++ b/packages/kbn-release-notes/src/release_notes_config.ts @@ -119,10 +119,6 @@ export const AREAS: Area[] = [ title: 'Maps', labels: ['Team:Geo'], }, - { - title: 'Canvas', - labels: ['Team:Canvas'], - }, { title: 'QA', labels: ['Team:QA'], @@ -138,6 +134,10 @@ export const AREAS: Area[] = [ 'Feature:Security/Feature Controls', ], }, + { + title: 'Canvas', + labels: ['Feature:Canvas'], + }, { title: 'Dashboard', labels: ['Feature:Dashboard', 'Feature:Drilldowns'],