CoreStart | |
-| [getSearchStrategy](./kibana-plugin-plugins-data-public.isearchcontext.getsearchstrategy.md) | <T extends TStrategyTypes>(name: T) => TSearchStrategyProvider<T> | |
-
diff --git a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
index 75d3abefc74b9..e818fb009fb19 100644
--- a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
+++ b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
@@ -67,7 +67,6 @@
| [IndexPatternTypeMeta](./kibana-plugin-plugins-data-public.indexpatterntypemeta.md) | |
| [IRequestTypesMap](./kibana-plugin-plugins-data-public.irequesttypesmap.md) | |
| [IResponseTypesMap](./kibana-plugin-plugins-data-public.iresponsetypesmap.md) | |
-| [ISearchContext](./kibana-plugin-plugins-data-public.isearchcontext.md) | |
| [ISearchOptions](./kibana-plugin-plugins-data-public.isearchoptions.md) | |
| [ISearchStrategy](./kibana-plugin-plugins-data-public.isearchstrategy.md) | Search strategy interface contains a search method that takes in a request and returns a promise that resolves to a response. |
| [ISyncSearchRequest](./kibana-plugin-plugins-data-public.isyncsearchrequest.md) | |
@@ -157,5 +156,4 @@
| [TabbedAggRow](./kibana-plugin-plugins-data-public.tabbedaggrow.md) | \* |
| [TimefilterContract](./kibana-plugin-plugins-data-public.timefiltercontract.md) | |
| [TimeHistoryContract](./kibana-plugin-plugins-data-public.timehistorycontract.md) | |
-| [TSearchStrategyProvider](./kibana-plugin-plugins-data-public.tsearchstrategyprovider.md) | Search strategy provider creates an instance of a search strategy with the request handler context bound to it. This way every search strategy can use whatever information they require from the request context. |
diff --git a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.tsearchstrategyprovider.md b/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.tsearchstrategyprovider.md
deleted file mode 100644
index 3233bb48cea2c..0000000000000
--- a/docs/development/plugins/data/public/kibana-plugin-plugins-data-public.tsearchstrategyprovider.md
+++ /dev/null
@@ -1,13 +0,0 @@
-
-
-[Home](./index.md) > [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) > [TSearchStrategyProvider](./kibana-plugin-plugins-data-public.tsearchstrategyprovider.md)
-
-## TSearchStrategyProvider type
-
-Search strategy provider creates an instance of a search strategy with the request handler context bound to it. This way every search strategy can use whatever information they require from the request context.
-
-Signature:
-
-```typescript
-export declare type TSearchStrategyProvider
diff --git a/examples/developer_examples/kibana.json b/examples/developer_examples/kibana.json
new file mode 100644
index 0000000000000..8c9ec2e4dcbfc
--- /dev/null
+++ b/examples/developer_examples/kibana.json
@@ -0,0 +1,9 @@
+{
+ "id": "developerExamples",
+ "version": "0.0.1",
+ "kibanaVersion": "kibana",
+ "server": false,
+ "ui": true,
+ "requiredPlugins": [],
+ "optionalPlugins": []
+}
diff --git a/examples/developer_examples/navigation.png b/examples/developer_examples/navigation.png
new file mode 100644
index 0000000000000..ac72f697e5db0
Binary files /dev/null and b/examples/developer_examples/navigation.png differ
diff --git a/examples/developer_examples/public/app.tsx b/examples/developer_examples/public/app.tsx
new file mode 100644
index 0000000000000..2ce21bae75e21
--- /dev/null
+++ b/examples/developer_examples/public/app.tsx
@@ -0,0 +1,117 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useState } from 'react';
+import ReactDOM from 'react-dom';
+
+import {
+ EuiText,
+ EuiPageContent,
+ EuiCard,
+ EuiPageContentHeader,
+ EuiFlexGroup,
+ EuiFlexItem,
+ EuiFieldSearch,
+ EuiListGroup,
+ EuiHighlight,
+ EuiLink,
+ EuiButtonIcon,
+} from '@elastic/eui';
+import { AppMountParameters } from '../../../src/core/public';
+import { ExampleDefinition } from './types';
+
+interface Props {
+ examples: ExampleDefinition[];
+ navigateToApp: (appId: string) => void;
+ getUrlForApp: (appId: string) => string;
+}
+
+function DeveloperExamples({ examples, navigateToApp, getUrlForApp }: Props) {
+ const [search, setSearch] = useStateDeveloper examples
+
+ The following examples showcase services and APIs that are available to developers.
+
+ Either enable the
+
+ `);
+ unmount();
+ });
+
+ it('does not redirect or show warning if URL is not too long', () => {
+ history.push('/regular-length-url');
+ expect(history.location.pathname).toEqual('/regular-length-url');
+ expect(assignSpy).not.toHaveBeenCalled();
+ expect(toasts.addWarning).not.toHaveBeenCalled();
+ });
+
+ it('does not redirect or show warning if state:storeInSessionStorage is set', () => {
+ uiSettings.get.mockReturnValue(true);
+ history.push(longUrl);
+ expect(history.location.pathname).toEqual(longUrl);
+ expect(assignSpy).not.toHaveBeenCalled();
+ expect(toasts.addWarning).not.toHaveBeenCalled();
+ });
+
+ it('does not redirect or show warning if already on the error page', () => {
+ history.push('/app/error');
+ const longQueryParam = 'a'.repeat(URL_MAX_LENGTH);
+ const longErrorUrl = `/app/error?q=${longQueryParam}`;
+ history.push(longErrorUrl);
+ expect(history.location.pathname).toEqual('/app/error');
+ expect(history.location.search).toEqual(`?q=${longQueryParam}`);
+ expect(assignSpy).not.toHaveBeenCalled();
+ expect(toasts.addWarning).not.toHaveBeenCalled();
+ });
+});
diff --git a/src/core/public/core_app/errors/url_overflow.tsx b/src/core/public/core_app/errors/url_overflow.tsx
new file mode 100644
index 0000000000000..da287a74d09ae
--- /dev/null
+++ b/src/core/public/core_app/errors/url_overflow.tsx
@@ -0,0 +1,96 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { History, Location } from 'history';
+
+import { i18n } from '@kbn/i18n';
+import { FormattedMessage } from '@kbn/i18n/react';
+
+import { mountReactNode } from '../../utils';
+import { IToasts } from '../../notifications';
+import { IBasePath } from '../../http';
+import { IUiSettingsClient } from '../../ui_settings';
+
+const IE_REGEX = /(; ?MSIE |Edge\/\d|Trident\/[\d+\.]+;.*rv:*11\.\d+)/;
+export const IS_IE = IE_REGEX.test(window.navigator.userAgent);
+/**
+ * The max URL length allowed by the current browser. Should be used to display warnings to users when query parameters
+ * cause URL to exceed this limit.
+ * @public
+ */
+export const URL_MAX_LENGTH = IS_IE ? 2000 : 25000;
+export const URL_WARNING_LENGTH = IS_IE ? 1000 : 24000;
+const ERROR_ROUTE = '/app/error';
+
+interface Deps {
+ basePath: IBasePath;
+ history: History;
+ toasts: IToasts;
+ uiSettings: IUiSettingsClient;
+}
+
+export const setupUrlOverflowDetection = ({ basePath, history, toasts, uiSettings }: Deps) =>
+ history.listen((location: Location) => {
+ // Bail if storeInSessionStorage is set or we're already on the error page
+ if (
+ uiSettings.get('state:storeInSessionStorage') ||
+ history.location.pathname.startsWith(ERROR_ROUTE)
+ ) {
+ return;
+ }
+
+ const absUrl = history.createHref(location);
+ const absUrlLength = absUrl.length;
+
+ if (absUrlLength > URL_MAX_LENGTH) {
+ const href = history.createHref({
+ pathname: ERROR_ROUTE,
+ search: `errorType=urlOverflow`,
+ });
+ // Force the browser to reload so that any potentially unstable state is unloaded
+ window.location.assign(href);
+ // window.location.href = href;
+ // window.location.reload();
+ } else if (absUrlLength >= URL_WARNING_LENGTH) {
+ toasts.addWarning({
+ title: i18n.translate('core.ui.errorUrlOverflow.bigUrlWarningNotificationTitle', {
+ defaultMessage: 'The URL is big and Kibana might stop working',
+ }),
+ text: mountReactNode(
+
+ state:storeInSessionStorage
+
+ option in
+
+ advanced settings
+
+ or simplify the onscreen visuals.
+
+
-
+
-
+
state:storeInSessionStorage, + kibanaSettingsLink: ( + + + + ), + }} + /> +
+ -
+
+
+ {IS_IE && (
+ -
+
+
+ )}
+
-
-
-
diff --git a/src/legacy/ui/public/error_url_overflow/error_url_overflow.js b/src/legacy/ui/public/error_url_overflow/error_url_overflow.js
deleted file mode 100644
index 223b81fa36fde..0000000000000
--- a/src/legacy/ui/public/error_url_overflow/error_url_overflow.js
+++ /dev/null
@@ -1,58 +0,0 @@
-/*
- * Licensed to Elasticsearch B.V. under one or more contributor
- * license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright
- * ownership. Elasticsearch B.V. licenses this file to you under
- * the Apache License, Version 2.0 (the "License"); you may
- * not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import { i18n } from '@kbn/i18n';
-import uiRoutes from '../routes';
-import { KbnUrlProvider } from '../url';
-
-import template from './error_url_overflow.html';
-import { UrlOverflowService } from '../../../../plugins/kibana_legacy/public';
-
-export { UrlOverflowService };
-
-uiRoutes.when('/error/url-overflow', {
- template,
- k7Breadcrumbs: () => [
- {
- text: i18n.translate('common.ui.errorUrlOverflow.breadcrumbs.errorText', {
- defaultMessage: 'Error',
- }),
- },
- ],
- controllerAs: 'controller',
- controller: class OverflowController {
- constructor(Private, $scope) {
- const kbnUrl = Private(KbnUrlProvider);
- const urlOverflow = new UrlOverflowService();
-
- if (!urlOverflow.get()) {
- kbnUrl.redirectPath('/');
- return;
- }
-
- this.url = urlOverflow.get();
- this.limit = urlOverflow.failLength();
- this.advancedSettingsLabel = i18n.translate(
- 'common.ui.errorUrlOverflow.howTofixError.enableOptionText.advancedSettingsLinkText',
- { defaultMessage: 'advanced settings' }
- );
- $scope.$on('$destroy', () => urlOverflow.clear());
- }
- },
-});
diff --git a/src/legacy/ui/public/styles/_legacy/_base.scss b/src/legacy/ui/public/styles/_legacy/_base.scss
index fd0a1335f9685..877ae033ae584 100644
--- a/src/legacy/ui/public/styles/_legacy/_base.scss
+++ b/src/legacy/ui/public/styles/_legacy/_base.scss
@@ -64,10 +64,6 @@ input[type='checkbox'],
padding-bottom: $euiSizeS;
}
- .globalQueryBar {
- padding: 0px $euiSizeS $euiSizeS $euiSizeS;
- }
-
> nav,
> navbar {
z-index: 2 !important;
diff --git a/src/plugins/dashboard/public/application/dashboard_app_controller.tsx b/src/plugins/dashboard/public/application/dashboard_app_controller.tsx
index a59d1e8c546d4..206ef4f3d4313 100644
--- a/src/plugins/dashboard/public/application/dashboard_app_controller.tsx
+++ b/src/plugins/dashboard/public/application/dashboard_app_controller.tsx
@@ -19,8 +19,9 @@
import _, { uniq } from 'lodash';
import { i18n } from '@kbn/i18n';
-import { EUI_MODAL_CANCEL_BUTTON } from '@elastic/eui';
-import React from 'react';
+import { EUI_MODAL_CANCEL_BUTTON, EuiCheckboxGroup } from '@elastic/eui';
+import { EuiCheckboxGroupIdToSelectedMap } from '@elastic/eui/src/components/form/checkbox/checkbox_group';
+import React, { useState, ReactElement } from 'react';
import ReactDOM from 'react-dom';
import angular from 'angular';
@@ -94,6 +95,25 @@ export interface DashboardAppControllerDependencies extends RenderDeps {
navigation: NavigationStart;
}
+enum UrlParams {
+ SHOW_TOP_MENU = 'show-top-menu',
+ SHOW_QUERY_INPUT = 'show-query-input',
+ SHOW_TIME_FILTER = 'show-time-filter',
+ SHOW_FILTER_BAR = 'show-filter-bar',
+ HIDE_FILTER_BAR = 'hide-filter-bar',
+}
+
+interface UrlParamsSelectedMap {
+ [UrlParams.SHOW_TOP_MENU]: boolean;
+ [UrlParams.SHOW_QUERY_INPUT]: boolean;
+ [UrlParams.SHOW_TIME_FILTER]: boolean;
+ [UrlParams.SHOW_FILTER_BAR]: boolean;
+}
+
+interface UrlParamValues extends Omit- - - -
- - - - - - --
-
-
-
-
-
-
- -
-