From af58ee866d79bd6bf3cb39d17ffb0047ab098c46 Mon Sep 17 00:00:00 2001 From: Jonathan Budzenski Date: Wed, 3 Aug 2022 14:14:40 -0400 Subject: [PATCH] [build/canvas] Fix runtime generation (#137972) This fixes an issue with the CI stats plugin using `tapAsync` instead of `tapPromise`. It appears that if callback() is not called in `tapAsync`, the entrypoint is not written to disk. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../plugins/canvas/shareable_runtime/webpack/ci_stats_plugin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/canvas/shareable_runtime/webpack/ci_stats_plugin.ts b/x-pack/plugins/canvas/shareable_runtime/webpack/ci_stats_plugin.ts index 20facc666f47c..fb1e93ddbe956 100644 --- a/x-pack/plugins/canvas/shareable_runtime/webpack/ci_stats_plugin.ts +++ b/x-pack/plugins/canvas/shareable_runtime/webpack/ci_stats_plugin.ts @@ -41,7 +41,7 @@ export class CiStatsPlugin { return; } - compiler.hooks.emit.tapAsync('CiStatsPlugin', async (compilation) => { + compiler.hooks.emit.tapPromise('CiStatsPlugin', async (compilation) => { const { entryName } = this.options; const assets = Object.entries(compilation.assets)