From a649b03e6a79e35556721ca4d13548de4b9b2ff9 Mon Sep 17 00:00:00 2001 From: Nick Peihl Date: Fri, 3 May 2024 11:50:35 -0400 Subject: [PATCH] Type fixes --- src/plugins/dashboard/public/index.ts | 1 - .../components/dashboard_link/dashboard_link_component.test.tsx | 2 +- .../components/dashboard_link/dashboard_link_component.tsx | 2 +- .../dashboard_link/dashboard_link_destination_picker.tsx | 2 +- src/plugins/links/public/components/editor/link_destination.tsx | 2 +- src/plugins/links/public/components/editor/link_editor.tsx | 2 +- src/plugins/links/public/components/editor/links_editor.tsx | 2 +- .../links/public/components/editor/links_editor_single_link.tsx | 2 +- src/plugins/links/public/editor/open_editor_flyout.tsx | 2 +- src/plugins/links/public/editor/open_link_editor_flyout.tsx | 2 +- src/plugins/links/public/embeddable/links_embeddable.tsx | 2 +- src/plugins/links/public/embeddable/links_embeddable_factory.ts | 2 +- src/plugins/links/public/plugin.ts | 2 +- 13 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/plugins/dashboard/public/index.ts b/src/plugins/dashboard/public/index.ts index 92c9f9043bc1f..91731174eff76 100644 --- a/src/plugins/dashboard/public/index.ts +++ b/src/plugins/dashboard/public/index.ts @@ -23,7 +23,6 @@ export { DASHBOARD_CONTAINER_TYPE, type DashboardCreationOptions, type DashboardLocatorParams, - type DashboardContainer, type IProvidesLegacyPanelPlacementSettings, } from './dashboard_container'; export type { DashboardSetup, DashboardStart, DashboardFeatureFlagConfig } from './plugin'; diff --git a/src/plugins/links/public/components/dashboard_link/dashboard_link_component.test.tsx b/src/plugins/links/public/components/dashboard_link/dashboard_link_component.test.tsx index 4e6eb32319baf..84e358fdb381c 100644 --- a/src/plugins/links/public/components/dashboard_link/dashboard_link_component.test.tsx +++ b/src/plugins/links/public/components/dashboard_link/dashboard_link_component.test.tsx @@ -9,7 +9,7 @@ import React from 'react'; import { getDashboardLocatorParamsFromEmbeddable } from '@kbn/dashboard-plugin/public'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { DEFAULT_DASHBOARD_DRILLDOWN_OPTIONS } from '@kbn/presentation-util-plugin/public'; import { createEvent, fireEvent, render, screen, waitFor, within } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; diff --git a/src/plugins/links/public/components/dashboard_link/dashboard_link_component.tsx b/src/plugins/links/public/components/dashboard_link/dashboard_link_component.tsx index 57d881cecd705..202a697cd7160 100644 --- a/src/plugins/links/public/components/dashboard_link/dashboard_link_component.tsx +++ b/src/plugins/links/public/components/dashboard_link/dashboard_link_component.tsx @@ -17,7 +17,7 @@ import { DashboardLocatorParams, getDashboardLocatorParamsFromEmbeddable, } from '@kbn/dashboard-plugin/public'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { DashboardDrilldownOptions, DEFAULT_DASHBOARD_DRILLDOWN_OPTIONS, diff --git a/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx b/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx index 137d604c2e01e..fea0a5239ba0d 100644 --- a/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx +++ b/src/plugins/links/public/components/dashboard_link/dashboard_link_destination_picker.tsx @@ -20,7 +20,7 @@ import { EuiFlexGroup, EuiComboBoxOptionOption, } from '@elastic/eui'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { DashboardItem } from '../../embeddable/types'; import { DashboardLinkStrings } from './dashboard_link_strings'; diff --git a/src/plugins/links/public/components/editor/link_destination.tsx b/src/plugins/links/public/components/editor/link_destination.tsx index bd33b6245ab51..5eb2d67a0d882 100644 --- a/src/plugins/links/public/components/editor/link_destination.tsx +++ b/src/plugins/links/public/components/editor/link_destination.tsx @@ -8,7 +8,7 @@ import React, { useState } from 'react'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { EuiFormRow } from '@elastic/eui'; import { diff --git a/src/plugins/links/public/components/editor/link_editor.tsx b/src/plugins/links/public/components/editor/link_editor.tsx index 7af2ddf1c57d5..ca3aeda7224bb 100644 --- a/src/plugins/links/public/components/editor/link_editor.tsx +++ b/src/plugins/links/public/components/editor/link_editor.tsx @@ -26,7 +26,7 @@ import { EuiFlyoutHeader, EuiRadioGroupOption, } from '@elastic/eui'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { LinkType, diff --git a/src/plugins/links/public/components/editor/links_editor.tsx b/src/plugins/links/public/components/editor/links_editor.tsx index 2a146ab5430cd..bd2da0041499d 100644 --- a/src/plugins/links/public/components/editor/links_editor.tsx +++ b/src/plugins/links/public/components/editor/links_editor.tsx @@ -28,7 +28,7 @@ import { EuiSwitch, EuiTitle, } from '@elastic/eui'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { Link, diff --git a/src/plugins/links/public/components/editor/links_editor_single_link.tsx b/src/plugins/links/public/components/editor/links_editor_single_link.tsx index e13913f1e349d..c69c33662c014 100644 --- a/src/plugins/links/public/components/editor/links_editor_single_link.tsx +++ b/src/plugins/links/public/components/editor/links_editor_single_link.tsx @@ -21,7 +21,7 @@ import { EuiSkeletonTitle, DraggableProvidedDragHandleProps, } from '@elastic/eui'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { LinkInfo } from '../../embeddable/types'; import { validateUrl } from '../external_link/external_link_tools'; diff --git a/src/plugins/links/public/editor/open_editor_flyout.tsx b/src/plugins/links/public/editor/open_editor_flyout.tsx index 3fc187a05be1c..8455ca16e604b 100644 --- a/src/plugins/links/public/editor/open_editor_flyout.tsx +++ b/src/plugins/links/public/editor/open_editor_flyout.tsx @@ -11,7 +11,7 @@ import { skip, take } from 'rxjs'; import { v4 as uuidv4 } from 'uuid'; import { EuiLoadingSpinner, EuiPanel } from '@elastic/eui'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { toMountPoint } from '@kbn/react-kibana-mount'; import { withSuspense } from '@kbn/shared-ux-utility'; diff --git a/src/plugins/links/public/editor/open_link_editor_flyout.tsx b/src/plugins/links/public/editor/open_link_editor_flyout.tsx index f8176d6e7e245..d3406264db4ad 100644 --- a/src/plugins/links/public/editor/open_link_editor_flyout.tsx +++ b/src/plugins/links/public/editor/open_link_editor_flyout.tsx @@ -10,7 +10,7 @@ import React from 'react'; import ReactDOM from 'react-dom'; import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { coreServices } from '../services/kibana_services'; import { Link } from '../../common/content_management'; diff --git a/src/plugins/links/public/embeddable/links_embeddable.tsx b/src/plugins/links/public/embeddable/links_embeddable.tsx index d803b9df9e8c5..dcc49a7265a43 100644 --- a/src/plugins/links/public/embeddable/links_embeddable.tsx +++ b/src/plugins/links/public/embeddable/links_embeddable.tsx @@ -11,7 +11,7 @@ import React, { createContext } from 'react'; import { unmountComponentAtNode } from 'react-dom'; import { distinctUntilChanged, skip, Subject, Subscription, switchMap } from 'rxjs'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { AttributeService, Embeddable, diff --git a/src/plugins/links/public/embeddable/links_embeddable_factory.ts b/src/plugins/links/public/embeddable/links_embeddable_factory.ts index eba91fe75770b..9ff3877b8a42e 100644 --- a/src/plugins/links/public/embeddable/links_embeddable_factory.ts +++ b/src/plugins/links/public/embeddable/links_embeddable_factory.ts @@ -7,7 +7,7 @@ */ import { DASHBOARD_GRID_COLUMN_COUNT, PanelPlacementStrategy } from '@kbn/dashboard-plugin/public'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { IProvidesLegacyPanelPlacementSettings } from '@kbn/dashboard-plugin/public'; import { EmbeddableStateWithType } from '@kbn/embeddable-plugin/common'; import { diff --git a/src/plugins/links/public/plugin.ts b/src/plugins/links/public/plugin.ts index ca13281fd2512..32788a2a283c1 100644 --- a/src/plugins/links/public/plugin.ts +++ b/src/plugins/links/public/plugin.ts @@ -12,7 +12,7 @@ import { } from '@kbn/content-management-plugin/public'; import { CoreSetup, CoreStart, Plugin } from '@kbn/core/public'; import { DashboardStart } from '@kbn/dashboard-plugin/public'; -import { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; +import type { DashboardContainer } from '@kbn/dashboard-plugin/public/dashboard_container'; import { EmbeddableSetup, EmbeddableStart } from '@kbn/embeddable-plugin/public'; import { PresentationUtilPluginStart } from '@kbn/presentation-util-plugin/public'; import { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';