From a3cbb4e75b3423a84723e49160147e1a605dc318 Mon Sep 17 00:00:00 2001 From: Stratoula Kalafateli Date: Fri, 27 Jan 2023 16:50:18 +0200 Subject: [PATCH] [Lens] Display the metric title on the dashboard panel (#149662) ## Summary Closes https://github.com/elastic/kibana/issues/148563 After this [PR]( https://github.com/elastic/kibana/pull/148301) being merged, it will be easier to add the description info icon and the custom data range to the new metric. For this reason we decided to also allow the panel title for now. On the next minors we are going to hide it from the panel and display all the aforementioned info on the viz title. image ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --- .../lens/public/visualizations/metric/visualization.test.ts | 2 +- .../plugins/lens/public/visualizations/metric/visualization.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/lens/public/visualizations/metric/visualization.test.ts b/x-pack/plugins/lens/public/visualizations/metric/visualization.test.ts index 314c175d24fbe..32f6ecf38ab8f 100644 --- a/x-pack/plugins/lens/public/visualizations/metric/visualization.test.ts +++ b/x-pack/plugins/lens/public/visualizations/metric/visualization.test.ts @@ -1099,7 +1099,7 @@ describe('metric visualization', () => { it('implements custom display options', () => { expect(visualization.getDisplayOptions!()).toEqual({ - noPanelTitle: true, + noPanelTitle: false, noPadding: true, }); }); diff --git a/x-pack/plugins/lens/public/visualizations/metric/visualization.tsx b/x-pack/plugins/lens/public/visualizations/metric/visualization.tsx index 380c63975a977..8bc4b61e446be 100644 --- a/x-pack/plugins/lens/public/visualizations/metric/visualization.tsx +++ b/x-pack/plugins/lens/public/visualizations/metric/visualization.tsx @@ -636,7 +636,7 @@ export const getMetricVisualization = ({ getDisplayOptions() { return { - noPanelTitle: true, + noPanelTitle: false, noPadding: true, }; },