From a0e0ad4ea805263d48833380c87173fc215da22d Mon Sep 17 00:00:00 2001
From: Jean-Louis Leysens <jloleysens@gmail.com>
Date: Fri, 6 Mar 2020 13:55:12 +0100
Subject: [PATCH] logic: slight update to when the index closed callout is
 shown

We only show the index closed callout in the flyout when the
reindex operation is not considered "completed"
---
 .../deprecations/reindex/flyout/container.tsx | 21 ++++++++++---------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/deprecations/reindex/flyout/container.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/deprecations/reindex/flyout/container.tsx
index 8cb102d75f083..42f8a8c4a1717 100644
--- a/x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/deprecations/reindex/flyout/container.tsx
+++ b/x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/deprecations/reindex/flyout/container.tsx
@@ -9,16 +9,16 @@ import { DocLinksStart } from 'kibana/public';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
 import {
+  EuiCallOut,
   EuiFlyout,
   EuiFlyoutHeader,
-  EuiPortal,
-  EuiTitle,
-  EuiCallOut,
   EuiLink,
+  EuiPortal,
   EuiSpacer,
+  EuiTitle,
 } from '@elastic/eui';
 
-import { EnrichedDeprecationInfo } from '../../../../../../../../common/types';
+import { EnrichedDeprecationInfo, ReindexStatus } from '../../../../../../../../common/types';
 
 import { ReindexState } from '../polling_service';
 import { ChecklistFlyoutStep } from './checklist_step';
@@ -117,13 +117,16 @@ export class ReindexFlyout extends React.Component<ReindexFlyoutProps, ReindexFl
     const { currentFlyoutStep } = this.state;
 
     let flyoutContents: React.ReactNode;
+
+    const globalCallout =
+      reindexBlocker === 'index-closed' && reindexState.status !== ReindexStatus.completed
+        ? getIndexClosedCallout(docLinks)
+        : undefined;
     switch (currentFlyoutStep) {
       case ReindexFlyoutStep.reindexWarnings:
         flyoutContents = (
           <WarningsFlyoutStep
-            renderGlobalCallouts={() =>
-              reindexBlocker === 'index-closed' ? getIndexClosedCallout(docLinks) : undefined
-            }
+            renderGlobalCallouts={() => globalCallout}
             closeFlyout={closeFlyout}
             warnings={reindexState.reindexWarnings!}
             advanceNextStep={this.advanceNextStep}
@@ -133,9 +136,7 @@ export class ReindexFlyout extends React.Component<ReindexFlyoutProps, ReindexFl
       case ReindexFlyoutStep.checklist:
         flyoutContents = (
           <ChecklistFlyoutStep
-            renderGlobalCallouts={() =>
-              reindexBlocker === 'index-closed' ? getIndexClosedCallout(docLinks) : undefined
-            }
+            renderGlobalCallouts={() => globalCallout}
             closeFlyout={closeFlyout}
             reindexState={reindexState}
             startReindex={startReindex}