From 9298c6f26863d783f0d4ccd23c906dc867c451f1 Mon Sep 17 00:00:00 2001 From: Abdul Wahab Zahid Date: Tue, 11 Jun 2024 20:29:43 +0200 Subject: [PATCH] [Dataset quality] Change Dataset Quality app's title and add description. (#184728) The PR changes the app's title from "Datasets" to "Data Set Quality". Note that the changed title "Data Set Quality" will also be used as a side nav menu item under Stack Management (in followups). The PR also adds an app description as suggested in the parent issue. ![image](https://github.com/elastic/kibana/assets/2748376/1d882f38-d062-40bc-b03f-717f9454b0cf) The link leads to Doc's ECS page: [Data Stream Fields](https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html). The PR also changes the breadcrumb and quick search entry to use "Data Set Quality" instead of "Data quality" or "Logs data quality". ![image](https://github.com/elastic/kibana/assets/2748376/10d53c25-e3bd-489c-8a4d-a93153eb5499) As per the [writing style guidelines](https://brand.elastic.co/302f66895/p/194a3b-writing-style-guide/t/889c93), any instance of "Dataest" is changed to either "Data Set" or "Data set". --- docs/developer/plugin-list.asciidoc | 4 +- packages/kbn-doc-links/src/get_doc_links.ts | 1 + packages/kbn-doc-links/src/types.ts | 1 + x-pack/plugins/data_quality/README.md | 2 +- x-pack/plugins/data_quality/common/index.ts | 2 +- x-pack/plugins/data_quality/public/plugin.ts | 9 +- .../public/routes/dataset_quality/index.tsx | 2 +- .../dataset_quality/README.md | 6 +- .../dataset_quality/common/translations.ts | 20 ++--- .../dataset_quality/kibana.jsonc | 2 +- .../dataset_quality/filters/filter_bar.tsx | 2 +- .../components/dataset_quality/header.tsx | 88 ++++++++++++------- .../dataset_quality/table/columns.tsx | 8 +- .../degraded_docs_trend/degraded_docs.tsx | 2 +- .../flyout/flyout_summary/flyout_summary.tsx | 2 +- .../flyout_summary/flyout_summary_header.tsx | 2 +- .../percentage_indicator.tsx | 2 +- .../src/notifications.ts | 8 +- .../dataset_quality/dataset_quality_flyout.ts | 2 +- .../dataset_quality/dataset_quality_table.ts | 16 ++-- .../dataset_quality_table_filters.ts | 14 +-- .../page_objects/dataset_quality.ts | 14 +-- .../dataset_quality/dataset_quality_flyout.ts | 2 +- .../dataset_quality/dataset_quality_table.ts | 14 +-- .../dataset_quality_table_filters.ts | 14 +-- 25 files changed, 134 insertions(+), 105 deletions(-) diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc index 451d978c04828..8bd8e4b00040e 100644 --- a/docs/developer/plugin-list.asciidoc +++ b/docs/developer/plugin-list.asciidoc @@ -536,11 +536,11 @@ Plugin server-side only. Plugin has three main functions: |{kib-repo}blob/{branch}/x-pack/plugins/data_quality/README.md[dataQuality] -|Page where users can see the quality of their log datasets. +|Page where users can see the quality of their log data sets. |{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/dataset_quality/README.md[datasetQuality] -|In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset quality, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others. +|In order to make ongoing maintenance of log collection easy we want to introduce the concept of data set quality, where users can easily get an overview on the data sets they have with information such as integration, size, last activity, among others. |{kib-repo}blob/{branch}/x-pack/plugins/data_visualizer/README.md[dataVisualizer] diff --git a/packages/kbn-doc-links/src/get_doc_links.ts b/packages/kbn-doc-links/src/get_doc_links.ts index 34895385bef9b..c79988f4ea964 100644 --- a/packages/kbn-doc-links/src/get_doc_links.ts +++ b/packages/kbn-doc-links/src/get_doc_links.ts @@ -863,6 +863,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D }, ecs: { guide: `${ELASTIC_WEBSITE_URL}guide/en/ecs/${ECS_VERSION}/index.html`, + dataStreams: `${ELASTIC_WEBSITE_URL}guide/en/ecs/${ECS_VERSION}/ecs-data_stream.html`, }, clients: { /** Changes to these URLs must also be synched in src/plugins/custom_integrations/server/language_clients/index.ts */ diff --git a/packages/kbn-doc-links/src/types.ts b/packages/kbn-doc-links/src/types.ts index 554e26ccd7685..0f6070c4016e3 100644 --- a/packages/kbn-doc-links/src/types.ts +++ b/packages/kbn-doc-links/src/types.ts @@ -556,6 +556,7 @@ export interface DocLinks { }>; readonly ecs: { readonly guide: string; + readonly dataStreams: string; }; readonly clients: { readonly guide: string; diff --git a/x-pack/plugins/data_quality/README.md b/x-pack/plugins/data_quality/README.md index 31582a332a2fd..84e317edce7ac 100755 --- a/x-pack/plugins/data_quality/README.md +++ b/x-pack/plugins/data_quality/README.md @@ -1,2 +1,2 @@ # dataQuality -Page where users can see the quality of their log datasets. +Page where users can see the quality of their log data sets. diff --git a/x-pack/plugins/data_quality/common/index.ts b/x-pack/plugins/data_quality/common/index.ts index e92f9084edac7..79bbe59ff35d2 100644 --- a/x-pack/plugins/data_quality/common/index.ts +++ b/x-pack/plugins/data_quality/common/index.ts @@ -9,7 +9,7 @@ import { i18n } from '@kbn/i18n'; export const PLUGIN_ID = 'data_quality'; export const PLUGIN_NAME = i18n.translate('xpack.dataQuality.name', { - defaultMessage: 'Logs data quality', + defaultMessage: 'Data Set Quality', }); export { DATA_QUALITY_URL_STATE_KEY, datasetQualityUrlSchemaV1 } from './url_schema'; diff --git a/x-pack/plugins/data_quality/public/plugin.ts b/x-pack/plugins/data_quality/public/plugin.ts index 7d0893bbe4b22..d1ae2cd748f13 100644 --- a/x-pack/plugins/data_quality/public/plugin.ts +++ b/x-pack/plugins/data_quality/public/plugin.ts @@ -38,7 +38,14 @@ export class DataQualityPlugin id: PLUGIN_ID, title: PLUGIN_NAME, order: 2, - keywords: ['data', 'quality', 'data quality', 'datasets', 'datasets quality'], + keywords: [ + 'data', + 'quality', + 'data quality', + 'datasets', + 'datasets quality', + 'data set quality', + ], async mount(params: ManagementAppMountParams) { const [{ renderApp }, [coreStart, pluginsStartDeps, pluginStart]] = await Promise.all([ import('./application'), diff --git a/x-pack/plugins/data_quality/public/routes/dataset_quality/index.tsx b/x-pack/plugins/data_quality/public/routes/dataset_quality/index.tsx index 6dfb2a5d052fe..346c72cfdefb3 100644 --- a/x-pack/plugins/data_quality/public/routes/dataset_quality/index.tsx +++ b/x-pack/plugins/data_quality/public/routes/dataset_quality/index.tsx @@ -46,7 +46,7 @@ const ConnectedContent = React.memo(() => { title={ } /> diff --git a/x-pack/plugins/observability_solution/dataset_quality/README.md b/x-pack/plugins/observability_solution/dataset_quality/README.md index afa09dc5781aa..d000c5697b1d3 100755 --- a/x-pack/plugins/observability_solution/dataset_quality/README.md +++ b/x-pack/plugins/observability_solution/dataset_quality/README.md @@ -1,12 +1,12 @@ -# Dataset Quality +# Data Set Quality -In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset quality, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others. +In order to make ongoing maintenance of log collection easy we want to introduce the concept of data set quality, where users can easily get an overview on the data sets they have with information such as integration, size, last activity, among others. ## Development ### Unit Tests -Kibana primarily uses Jest for unit testing. Each plugin or package defines a `jest.config.js` that extends a preset provided by the `@kbn/test` package. The following command runs all Dataset quality unit tests: +Kibana primarily uses Jest for unit testing. Each plugin or package defines a `jest.config.js` that extends a preset provided by the `@kbn/test` package. The following command runs all Data Set Quality unit tests: ``` yarn jest --config x-pack/plugins/observability_solution/dataset_quality/jest.config.js diff --git a/x-pack/plugins/observability_solution/dataset_quality/common/translations.ts b/x-pack/plugins/observability_solution/dataset_quality/common/translations.ts index 3e411930ae9d4..616cfb295a21f 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/common/translations.ts +++ b/x-pack/plugins/observability_solution/dataset_quality/common/translations.ts @@ -8,7 +8,7 @@ import { i18n } from '@kbn/i18n'; export const datasetQualityAppTitle = i18n.translate('xpack.datasetQuality.appTitle', { - defaultMessage: 'Datasets', + defaultMessage: 'Data Set Quality', }); export const noDatasetsDescription = i18n.translate('xpack.datasetQuality.noDatasetsDescription', { @@ -56,7 +56,7 @@ export const flyoutOpenInDiscoverText = i18n.translate( export const flyoutDatasetDetailsText = i18n.translate( 'xpack.datasetQuality.flyoutDatasetDetailsText', { - defaultMessage: 'Dataset details', + defaultMessage: 'Data set details', } ); @@ -154,7 +154,7 @@ export const flyoutImprovementText = i18n.translate( export const flyoutImprovementTooltip = i18n.translate( 'xpack.datasetQuality.flyoutDegradedFieldsSectionTooltip', { - defaultMessage: 'A partial list of degraded fields found in your dataset.', + defaultMessage: 'A partial list of degraded fields found in your data set.', } ); @@ -185,14 +185,14 @@ export const summaryPanelLast24hText = i18n.translate( export const summaryPanelQualityText = i18n.translate( 'xpack.datasetQuality.summaryPanelQualityText', { - defaultMessage: 'Datasets Quality', + defaultMessage: 'Data Sets Quality', } ); export const summaryPanelQualityTooltipText = i18n.translate( 'xpack.datasetQuality.summaryPanelQualityTooltipText', { - defaultMessage: 'Quality is based on the percentage of degraded docs in a dataset.', + defaultMessage: 'Quality is based on the percentage of degraded docs in a data set.', } ); @@ -220,14 +220,14 @@ export const summaryPanelQualityGoodText = i18n.translate( export const summaryPanelDatasetsActivityText = i18n.translate( 'xpack.datasetQuality.summaryPanelDatasetsActivityText', { - defaultMessage: 'Active Datasets', + defaultMessage: 'Active Data Sets', } ); export const summaryPanelDatasetsActivityTooltipText = i18n.translate( 'xpack.datasetQuality.summaryPanelDatasetsActivityTooltipText', { - defaultMessage: 'The number of datasets with activity in the selected time range.', + defaultMessage: 'The number of data sets with activity in the selected time range.', } ); @@ -246,7 +246,7 @@ export const summaryPanelEstimatedDataTooltipText = i18n.translate( ); export const inactiveDatasetsLabel = i18n.translate('xpack.datasetQuality.inactiveDatasetsLabel', { - defaultMessage: 'Show inactive datasets', + defaultMessage: 'Show inactive data sets', }); export const inactiveDatasetsDescription = i18n.translate( @@ -258,12 +258,12 @@ export const inactiveDatasetsDescription = i18n.translate( ); export const fullDatasetNameLabel = i18n.translate('xpack.datasetQuality.fullDatasetNameLabel', { - defaultMessage: 'Show full dataset names', + defaultMessage: 'Show full data set names', }); export const fullDatasetNameDescription = i18n.translate( 'xpack.datasetQuality.fullDatasetNameDescription', { - defaultMessage: 'Turn on to show the actual dataset names used to store the documents.', + defaultMessage: 'Turn on to show the actual data set names used to store the documents.', } ); diff --git a/x-pack/plugins/observability_solution/dataset_quality/kibana.jsonc b/x-pack/plugins/observability_solution/dataset_quality/kibana.jsonc index af5a48748fb0e..c45b3c756d119 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/kibana.jsonc +++ b/x-pack/plugins/observability_solution/dataset_quality/kibana.jsonc @@ -2,7 +2,7 @@ "type": "plugin", "id": "@kbn/dataset-quality-plugin", "owner": "@elastic/obs-ux-logs-team", - "description": "This plugin introduces the concept of dataset quality, where users can easily get an overview on the datasets they have.", + "description": "This plugin introduces the concept of data set quality, where users can easily get an overview on the data sets they have.", "plugin": { "id": "datasetQuality", "server": true, diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/filters/filter_bar.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/filters/filter_bar.tsx index 6ed24eaba8c3f..25c1298c69221 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/filters/filter_bar.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/filters/filter_bar.tsx @@ -10,7 +10,7 @@ import { EuiFieldSearch } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; const placeholder = i18n.translate('xpack.datasetQuality.filterBar.placeholder', { - defaultMessage: 'Filter datasets', + defaultMessage: 'Filter data sets', }); export interface FilterBarComponentProps { diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/header.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/header.tsx index 494d3f324f276..b217b8972e4b2 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/header.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/header.tsx @@ -5,46 +5,66 @@ * 2.0. */ -import { - EuiBetaBadge, - EuiFlexGroup, - EuiFlexItem, - EuiPageHeader, - EuiPageHeaderSection, - EuiText, -} from '@elastic/eui'; -import { i18n } from '@kbn/i18n'; import React from 'react'; -import { datasetQualityAppTitle } from '../../../common/translations'; - -export const betaBadgeLabel = i18n.translate('xpack.datasetQuality.betaBadgeLabel', { - defaultMessage: 'Beta', -}); +import { EuiBetaBadge, EuiLink, EuiPageHeader, EuiCode } from '@elastic/eui'; +import { i18n } from '@kbn/i18n'; +import { FormattedMessage } from '@kbn/i18n-react'; -export const betaBadgeDescription = i18n.translate('xpack.datasetQuality.betaBadgeDescription', { - defaultMessage: - 'This feature is currently in beta. If you encounter any bugs or have feedback, we’d love to hear from you. Please open a support issue and/or visit our discussion forum.', -}); +import { useKibanaContextForPlugin } from '../../utils'; +import { datasetQualityAppTitle } from '../../../common/translations'; // Allow for lazy loading // eslint-disable-next-line import/no-default-export export default function Header() { + const { + services: { docLinks }, + } = useKibanaContextForPlugin(); + return ( - - - - -

{datasetQualityAppTitle}

- - - - - - - + + {datasetQualityAppTitle} +   + + + } + description={ + logs-*, + ecsNamingSchemeLink: ( + + + + ), + }} + /> + } + /> ); } + +const betaBadgeLabel = i18n.translate('xpack.datasetQuality.betaBadgeLabel', { + defaultMessage: 'Beta', +}); + +const betaBadgeDescription = i18n.translate('xpack.datasetQuality.betaBadgeDescription', { + defaultMessage: + 'This feature is currently in beta. If you encounter any bugs or have feedback, we’d love to hear from you. Please open a support issue and/or visit our discussion forum.', +}); diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/columns.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/columns.tsx index 6f61883719098..cc944c5e3986a 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/columns.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/columns.tsx @@ -44,7 +44,7 @@ const collapseDatasetAriaLabel = i18n.translate('xpack.datasetQuality.collapseLa defaultMessage: 'Collapse', }); const nameColumnName = i18n.translate('xpack.datasetQuality.nameColumnName', { - defaultMessage: 'Dataset Name', + defaultMessage: 'Data Set Name', }); const namespaceColumnName = i18n.translate('xpack.datasetQuality.namespaceColumnName', { @@ -60,7 +60,7 @@ const degradedDocsColumnName = i18n.translate('xpack.datasetQuality.degradedDocs }); const datasetQualityColumnName = i18n.translate('xpack.datasetQuality.datasetQualityColumnName', { - defaultMessage: 'Dataset Quality', + defaultMessage: 'Data Set Quality', }); const lastActivityColumnName = i18n.translate('xpack.datasetQuality.lastActivityColumnName', { @@ -102,7 +102,7 @@ const degradedDocsDescription = ( const degradedDocsColumnTooltip = ( @@ -116,7 +116,7 @@ const degradedDocsColumnTooltip = ( const datasetQualityColumnTooltip = ( diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/degraded_docs_trend/degraded_docs.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/degraded_docs_trend/degraded_docs.tsx index 89087a26a1960..5a13b717ca336 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/degraded_docs_trend/degraded_docs.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/degraded_docs_trend/degraded_docs.tsx @@ -101,7 +101,7 @@ export function DegradedDocs({ const degradedDocsTooltip = ( diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/flyout_summary/flyout_summary.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/flyout_summary/flyout_summary.tsx index 4977f6b0d7732..353e7f353b6db 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/flyout_summary/flyout_summary.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/flyout_summary/flyout_summary.tsx @@ -50,7 +50,7 @@ const nonAggregatableWarningDescription = (dataset: string) => ( howToFixIt: ( ); diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/quality_indicator/percentage_indicator.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/quality_indicator/percentage_indicator.tsx index d99a47dcf1ada..c10a96672598a 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/quality_indicator/percentage_indicator.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/quality_indicator/percentage_indicator.tsx @@ -34,7 +34,7 @@ const DatasetWithFewDegradedDocs = ({ degradedDocsCount }: { degradedDocsCount?: ~0%{' '} { toasts.addDanger({ title: i18n.translate('xpack.datasetQuality.fetchDatasetStatsFailed', { - defaultMessage: "We couldn't get your datasets.", + defaultMessage: "We couldn't get your data sets.", }), text: error.message, }); @@ -20,7 +20,7 @@ export const fetchDatasetStatsFailedNotifier = (toasts: IToasts, error: Error) = export const fetchDatasetDetailsFailedNotifier = (toasts: IToasts, error: Error) => { toasts.addDanger({ title: i18n.translate('xpack.datasetQuality.fetchDatasetDetailsFailed', { - defaultMessage: "We couldn't get your dataset details.", + defaultMessage: "We couldn't get your data set details.", }), text: error.message, }); @@ -29,7 +29,7 @@ export const fetchDatasetDetailsFailedNotifier = (toasts: IToasts, error: Error) export const fetchDatasetSettingsFailedNotifier = (toasts: IToasts, error: Error) => { toasts.addDanger({ title: i18n.translate('xpack.datasetQuality.fetchDatasetSettingsFailed', { - defaultMessage: "Dataset settings couldn't be loaded.", + defaultMessage: "Data set settings couldn't be loaded.", }), text: error.message, }); @@ -74,6 +74,6 @@ export const fetchIntegrationsFailedNotifier = (toasts: IToasts, error: Error) = export const noDatasetSelected = i18n.translate( 'xpack.datasetQuality.fetchDatasetDetailsFailed.noDatasetSelected', { - defaultMessage: 'No dataset have been selected', + defaultMessage: 'No data set have been selected', } ); diff --git a/x-pack/test/functional/apps/dataset_quality/dataset_quality_flyout.ts b/x-pack/test/functional/apps/dataset_quality/dataset_quality_flyout.ts index 09e6c9abc44be..b3a80bd673d8a 100644 --- a/x-pack/test/functional/apps/dataset_quality/dataset_quality_flyout.ts +++ b/x-pack/test/functional/apps/dataset_quality/dataset_quality_flyout.ts @@ -69,7 +69,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); const testDatasetRowIndex = datasetNameColCellTexts.findIndex( diff --git a/x-pack/test/functional/apps/dataset_quality/dataset_quality_table.ts b/x-pack/test/functional/apps/dataset_quality/dataset_quality_table.ts index 99318a63578fe..51707db1f852c 100644 --- a/x-pack/test/functional/apps/dataset_quality/dataset_quality_table.ts +++ b/x-pack/test/functional/apps/dataset_quality/dataset_quality_table.ts @@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('shows the right number of rows in correct order', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('descending'); const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql([...datasetNames].reverse()); @@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('shows degraded docs percentage', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('ascending'); const degradedDocsCol = cols['Degraded Docs (%)']; @@ -89,7 +89,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('shows the updated size of the index', async () => { const testDatasetIndex = 2; const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('ascending'); const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); @@ -122,9 +122,9 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid }); it('sorts by dataset name', async () => { - // const header = await PageObjects.datasetQuality.getDatasetTableHeader('Dataset Name'); + // const header = await PageObjects.datasetQuality.getDatasetTableHeader('Data Set Name'); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Sort ascending await datasetNameCol.sort('ascending'); @@ -152,7 +152,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Sort ascending await datasetNameCol.sort('ascending'); @@ -169,7 +169,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('goes to log explorer page when opened', async () => { const rowIndexToOpen = 1; const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const actionsCol = cols.Actions; const datasetName = (await datasetNameCol.getCellTexts())[rowIndexToOpen]; @@ -185,7 +185,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); const lastActivityCol = cols['Last Activity']; - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Set time range to Last 1 minute const filtersContainer = await testSubjects.find( diff --git a/x-pack/test/functional/apps/dataset_quality/dataset_quality_table_filters.ts b/x-pack/test/functional/apps/dataset_quality/dataset_quality_table_filters.ts index 168a0631ec28a..ac118a5c1d1cc 100644 --- a/x-pack/test/functional/apps/dataset_quality/dataset_quality_table_filters.ts +++ b/x-pack/test/functional/apps/dataset_quality/dataset_quality_table_filters.ts @@ -48,7 +48,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('shows full dataset names when toggled', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql(datasetNames); @@ -65,7 +65,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid it('searches the datasets', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql(datasetNames); @@ -76,7 +76,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid ); const colsAfterSearch = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameColAfterSearch = colsAfterSearch['Dataset Name']; + const datasetNameColAfterSearch = colsAfterSearch['Data Set Name']; const datasetNameColCellTextsAfterSearch = await datasetNameColAfterSearch.getCellTexts(); expect(datasetNameColCellTextsAfterSearch).to.eql([datasetNames[2]]); await testSubjects.setValue( @@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql([apacheAccessDatasetHumanName, ...datasetNames]); @@ -111,7 +111,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid await PageObjects.datasetQuality.filterForIntegrations([apacheIntegrationName]); const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameColAfterFilter = colsAfterFilter['Dataset Name']; + const datasetNameColAfterFilter = colsAfterFilter['Data Set Name']; const datasetNameColCellTextsAfterFilter = await datasetNameColAfterFilter.getCellTexts(); expect(datasetNameColCellTextsAfterFilter).to.eql([apacheAccessDatasetHumanName]); }); @@ -174,7 +174,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid // Get default quality const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetQuality = cols['Dataset Quality']; + const datasetQuality = cols['Data Set Quality']; const datasetQualityCellTexts = await datasetQuality.getCellTexts(); expect(datasetQualityCellTexts).to.contain(expectedQuality); @@ -182,7 +182,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid await PageObjects.datasetQuality.filterForQualities([expectedQuality]); const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetQualityAfterFilter = colsAfterFilter['Dataset Quality']; + const datasetQualityAfterFilter = colsAfterFilter['Data Set Quality']; const datasetQualityCellTextsAfterFilter = await datasetQualityAfterFilter.getCellTexts(); expect(datasetQualityCellTextsAfterFilter).to.eql([expectedQuality]); diff --git a/x-pack/test/functional/page_objects/dataset_quality.ts b/x-pack/test/functional/page_objects/dataset_quality.ts index 3ccccc0e97986..c91ce73a05d49 100644 --- a/x-pack/test/functional/page_objects/dataset_quality.ts +++ b/x-pack/test/functional/page_objects/dataset_quality.ts @@ -62,9 +62,9 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv datasetQualityTable: '[data-test-subj="datasetQualityTable"]', datasetQualityTableColumn: (column: number) => `[data-test-subj="datasetQualityTable"] .euiTableRowCell:nth-child(${column})`, - datasetSearchInput: '[placeholder="Filter datasets"]', - showFullDatasetNamesSwitch: 'button[aria-label="Show full dataset names"]', - showInactiveDatasetsNamesSwitch: 'button[aria-label="Show inactive datasets"]', + datasetSearchInput: '[placeholder="Filter data sets"]', + showFullDatasetNamesSwitch: 'button[aria-label="Show full data set names"]', + showInactiveDatasetsNamesSwitch: 'button[aria-label="Show inactive data sets"]', superDatePickerApplyButton: '.euiQuickSelect__applyButton', }; @@ -215,10 +215,10 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv const table = await this.getDatasetsTable(); return parseDatasetTable(table, [ '0', - 'Dataset Name', + 'Data Set Name', 'Namespace', 'Size', - 'Dataset Quality', + 'Data Set Quality', 'Degraded Docs (%)', 'Last Activity', 'Actions', @@ -264,7 +264,7 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv async openDatasetFlyout(datasetName: string) { const cols = await this.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); const testDatasetRowIndex = datasetNameColCellTexts.findIndex( (dName) => dName === datasetName @@ -534,7 +534,7 @@ const texts = { datasetHealthPoor: 'Poor', datasetHealthDegraded: 'Degraded', datasetHealthGood: 'Good', - activeDatasets: 'Active Datasets', + activeDatasets: 'Active Data Sets', estimatedData: 'Estimated Data', docsCountTotal: 'Docs count (total)', size: 'Size', diff --git a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_flyout.ts b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_flyout.ts index a08037a5e810a..0ca26b296fe13 100644 --- a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_flyout.ts +++ b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_flyout.ts @@ -77,7 +77,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); const testDatasetRowIndex = datasetNameColCellTexts.findIndex( diff --git a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table.ts b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table.ts index 6180a7286d3d5..b86bf82a6266a 100644 --- a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table.ts +++ b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table.ts @@ -39,7 +39,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('shows the right number of rows in correct order', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('descending'); const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql([...datasetNames].reverse()); @@ -63,7 +63,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('shows degraded docs percentage', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('ascending'); const degradedDocsCol = cols['Degraded Docs (%)']; @@ -94,7 +94,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it.skip('shows the updated size of the index', async () => { const testDatasetIndex = 2; const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; await datasetNameCol.sort('ascending'); const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); @@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('sorts by dataset name', async () => { // const header = await PageObjects.datasetQuality.getDatasetTableHeader('Dataset Name'); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Sort ascending await datasetNameCol.sort('ascending'); @@ -157,7 +157,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Sort ascending await datasetNameCol.sort('ascending'); @@ -174,7 +174,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('goes to log explorer page when opened', async () => { const rowIndexToOpen = 1; const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const actionsCol = cols.Actions; const datasetName = (await datasetNameCol.getCellTexts())[rowIndexToOpen]; @@ -190,7 +190,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); const lastActivityCol = cols['Last Activity']; - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; // Set time range to Last 1 minute const filtersContainer = await testSubjects.find( diff --git a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts index c64eb37630ff9..239e4322876b0 100644 --- a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts +++ b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/dataset_quality_table_filters.ts @@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('shows full dataset names when toggled', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql(datasetNames); @@ -69,7 +69,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('searches the datasets', async () => { const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql(datasetNames); @@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ); const colsAfterSearch = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameColAfterSearch = colsAfterSearch['Dataset Name']; + const datasetNameColAfterSearch = colsAfterSearch['Data Set Name']; const datasetNameColCellTextsAfterSearch = await datasetNameColAfterSearch.getCellTexts(); expect(datasetNameColCellTextsAfterSearch).to.eql([datasetNames[2]]); await testSubjects.setValue( @@ -107,7 +107,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.datasetQuality.navigateTo(); const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameCol = cols['Dataset Name']; + const datasetNameCol = cols['Data Set Name']; const datasetNameColCellTexts = await datasetNameCol.getCellTexts(); expect(datasetNameColCellTexts).to.eql([apacheAccessDatasetHumanName, ...datasetNames]); @@ -115,7 +115,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.datasetQuality.filterForIntegrations([apacheIntegrationName]); const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetNameColAfterFilter = colsAfterFilter['Dataset Name']; + const datasetNameColAfterFilter = colsAfterFilter['Data Set Name']; const datasetNameColCellTextsAfterFilter = await datasetNameColAfterFilter.getCellTexts(); expect(datasetNameColCellTextsAfterFilter).to.eql([apacheAccessDatasetHumanName]); }); @@ -178,7 +178,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { // Get default quality const cols = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetQuality = cols['Dataset Quality']; + const datasetQuality = cols['Data Set Quality']; const datasetQualityCellTexts = await datasetQuality.getCellTexts(); expect(datasetQualityCellTexts).to.contain(expectedQuality); @@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.datasetQuality.filterForQualities([expectedQuality]); const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable(); - const datasetQualityAfterFilter = colsAfterFilter['Dataset Quality']; + const datasetQualityAfterFilter = colsAfterFilter['Data Set Quality']; const datasetQualityCellTextsAfterFilter = await datasetQualityAfterFilter.getCellTexts(); expect(datasetQualityCellTextsAfterFilter).to.eql([expectedQuality]);