From 91c437d72803037ed7f8f8d1e8720a1e196afc82 Mon Sep 17 00:00:00 2001 From: Robert Oskamp Date: Fri, 27 Mar 2020 14:59:04 +0100 Subject: [PATCH] [ML] Functional tests - stabilize advanced wizard tests (#61579) This PR stabilizes the anomaly detection wizard tests by adding a retry to the wizard navigation. --- .../anomaly_detection/advanced_job.ts | 4 +-- .../machine_learning/job_wizard_common.ts | 34 ++++++++++++------- 2 files changed, 22 insertions(+), 16 deletions(-) diff --git a/x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job.ts b/x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job.ts index 1e40cdd80ac0a..3669ed3ab579b 100644 --- a/x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job.ts +++ b/x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job.ts @@ -274,9 +274,7 @@ export default function({ getService }: FtrProviderContext) { }, ]; - // FLAKY: https://github.com/elastic/kibana/issues/61562 - // FLAKY: https://github.com/elastic/kibana/issues/61563 - describe.skip('advanced job', function() { + describe('advanced job', function() { this.tags(['smoke', 'mlqa']); before(async () => { await esArchiver.load('ml/ecommerce'); diff --git a/x-pack/test/functional/services/machine_learning/job_wizard_common.ts b/x-pack/test/functional/services/machine_learning/job_wizard_common.ts index 70d576a3d847b..36181b66786d5 100644 --- a/x-pack/test/functional/services/machine_learning/job_wizard_common.ts +++ b/x-pack/test/functional/services/machine_learning/job_wizard_common.ts @@ -34,23 +34,23 @@ export function MachineLearningJobWizardCommonProvider( }, async assertTimeRangeSectionExists() { - await testSubjects.existOrFail('mlJobWizardStepTitleTimeRange'); + await testSubjects.existOrFail('mlJobWizardStepTitleTimeRange', { timeout: 5000 }); }, async assertPickFieldsSectionExists() { - await testSubjects.existOrFail('mlJobWizardStepTitlePickFields'); + await testSubjects.existOrFail('mlJobWizardStepTitlePickFields', { timeout: 5000 }); }, async assertJobDetailsSectionExists() { - await testSubjects.existOrFail('mlJobWizardStepTitleJobDetails'); + await testSubjects.existOrFail('mlJobWizardStepTitleJobDetails', { timeout: 5000 }); }, async assertValidationSectionExists() { - await testSubjects.existOrFail('mlJobWizardStepTitleValidation'); + await testSubjects.existOrFail('mlJobWizardStepTitleValidation', { timeout: 5000 }); }, async assertSummarySectionExists() { - await testSubjects.existOrFail('mlJobWizardStepTitleSummary'); + await testSubjects.existOrFail('mlJobWizardStepTitleSummary', { timeout: 5000 }); }, async assertConfigureDatafeedSectionExists() { @@ -58,23 +58,31 @@ export function MachineLearningJobWizardCommonProvider( }, async advanceToPickFieldsSection() { - await this.clickNextButton(); - await this.assertPickFieldsSectionExists(); + await retry.tryForTime(15 * 1000, async () => { + await this.clickNextButton(); + await this.assertPickFieldsSectionExists(); + }); }, async advanceToJobDetailsSection() { - await this.clickNextButton(); - await this.assertJobDetailsSectionExists(); + await retry.tryForTime(15 * 1000, async () => { + await this.clickNextButton(); + await this.assertJobDetailsSectionExists(); + }); }, async advanceToValidationSection() { - await this.clickNextButton(); - await this.assertValidationSectionExists(); + await retry.tryForTime(15 * 1000, async () => { + await this.clickNextButton(); + await this.assertValidationSectionExists(); + }); }, async advanceToSummarySection() { - await this.clickNextButton(); - await this.assertSummarySectionExists(); + await retry.tryForTime(15 * 1000, async () => { + await this.clickNextButton(); + await this.assertSummarySectionExists(); + }); }, async assertEventRateChartExists() {