From 8a2ecc3b4f4a05d1f83190560191cc6b1264c729 Mon Sep 17 00:00:00 2001 From: Cee Chen <549407+cee-chen@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:03:56 -0800 Subject: [PATCH] Upgrade EUI to v74.0.1 (#149457) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([#6547](https://github.com/elastic/eui/pull/6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([#6530](https://github.com/elastic/eui/pull/6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([#6530](https://github.com/elastic/eui/pull/6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([#6538](https://github.com/elastic/eui/pull/6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([#6530](https://github.com/elastic/eui/pull/6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([#6535](https://github.com/elastic/eui/pull/6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([#6543](https://github.com/elastic/eui/pull/6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([#6539](https://github.com/elastic/eui/pull/6539)) - Added a new `RenderWithEuiTheme` render prop utility ([#6539](https://github.com/elastic/eui/pull/6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- package.json | 2 +- .../src/list_header/edit_modal/index.tsx | 2 +- src/dev/license_checker/config.ts | 2 +- .../copy_to_dashboard_modal.tsx | 4 +- .../listing/confirm_overlays.tsx | 4 +- .../__snapshots__/data_view.test.tsx.snap | 12 ++-- .../url/__snapshots__/url.test.tsx.snap | 10 +-- .../table/__snapshots__/table.test.tsx.snap | 12 ++-- .../components/table/table.tsx | 10 ++- .../customize_title/customize_panel_modal.tsx | 8 ++- .../public/markdown/markdown.test.tsx | 9 +-- .../saved_object_save_modal.test.tsx.snap | 72 +++++++++---------- .../save_modal/saved_object_save_modal.tsx | 12 ++-- .../not_found_errors.test.tsx.snap | 8 +-- .../apply_filter_popover_content.tsx | 10 ++- .../text_languages_transition_modal.tsx | 14 ++-- .../agg_based_selection.tsx | 10 ++- .../group_selection/group_selection.tsx | 10 ++- .../search_selection/search_selection.tsx | 22 +++--- .../service_group_save/group_details.tsx | 20 +++--- .../service_group_save/select_services.tsx | 13 ++-- .../custom_element_modal.tsx | 4 +- .../api/__snapshots__/shareable.test.tsx.snap | 10 +-- .../markdown_editor/plugins/lens/plugin.tsx | 44 ++++++------ .../analytics_collection_table.test.tsx | 4 +- .../components/crawl_requests_table.test.tsx | 4 +- .../crawler/components/domains_table.test.tsx | 9 +-- .../credentials_list.test.tsx | 8 +-- .../audit_logs_modal/audit_logs_modal.tsx | 4 +- .../tables/meta_engines_table.test.tsx | 11 +-- .../meta_engines_table_expanded_row.test.tsx | 5 +- .../tables/test_helpers/shared_columns.tsx | 5 +- .../components/synonym_modal.test.tsx | 4 +- .../synonyms/components/synonym_modal.tsx | 4 +- .../crawl_requests_table.test.tsx | 4 +- .../domain_management/domains_table.test.tsx | 9 +-- .../views/content_sources/sources_view.tsx | 28 ++++---- .../screens/detail/overview/license_modal.tsx | 4 +- .../screens/detail/overview/notice_modal.tsx | 4 +- .../request_trial_extension.test.js.snap | 16 ++--- .../revert_to_basic.test.js.snap | 6 +- .../__snapshots__/start_trial.test.js.snap | 8 +-- .../custom_icon_modal.test.tsx.snap | 16 ++--- .../components/symbol/custom_icon_modal.tsx | 4 +- .../delete_space_aware_item_check_modal.tsx | 10 ++- .../validate_job/validate_job_view.js | 4 +- .../add_to_dashboard_controls.tsx | 4 +- .../close_jobs_confirm_modal.tsx | 4 +- .../stop_datafeeds_confirm_modal.tsx | 4 +- .../delete_job_modal/delete_job_modal.tsx | 18 +++-- .../edit_job_flyout/tabs/custom_urls.tsx | 10 ++- .../reset_job_modal/reset_job_modal.tsx | 18 +++-- .../start_datafeed_modal.js | 18 +++-- .../components/data_view/change_data_view.tsx | 10 ++- .../advanced_detector_modal/modal_wrapper.tsx | 10 ++- .../__snapshots__/import_modal.test.js.snap | 12 ++-- .../edit/import_modal/import_modal.js | 10 ++- .../edit/new_event_modal/new_event_modal.js | 10 ++- .../components/forecasting_modal/modal.js | 10 ++- .../models_management/delete_models_modal.tsx | 18 +++-- .../models_management/deployment_setup.tsx | 41 ++++------- .../anomaly_charts_initializer.tsx | 10 ++- .../anomaly_swimlane_initializer.tsx | 10 ++- .../public/alerts/enable_alerts_modal.tsx | 10 ++- .../__snapshots__/exporters.test.js.snap | 6 +- .../__snapshots__/reason_found.test.js.snap | 6 +- .../update_default_data_view_modal.tsx | 4 +- .../authentications_host_table.test.tsx.snap | 6 +- .../authentications_user_table.test.tsx.snap | 6 +- .../__snapshots__/expanded_row.test.tsx.snap | 2 +- .../rules_setting/rules_settings_modal.tsx | 12 ++-- .../connector_add_modal.tsx | 61 ++++++++-------- .../field_browser/field_browser_modal.tsx | 4 +- .../components/bulk_snooze_modal.tsx | 2 +- .../components/bulk_snooze_schedule_modal.tsx | 2 +- yarn.lock | 8 +-- 76 files changed, 377 insertions(+), 464 deletions(-) diff --git a/package.json b/package.json index 42b2c256c33c4..124c77a6829d7 100644 --- a/package.json +++ b/package.json @@ -104,7 +104,7 @@ "@elastic/datemath": "5.0.3", "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@8.6.0-canary.3", "@elastic/ems-client": "8.4.0", - "@elastic/eui": "73.0.0", + "@elastic/eui": "74.0.1", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/packages/kbn-securitysolution-exception-list-components/src/list_header/edit_modal/index.tsx b/packages/kbn-securitysolution-exception-list-components/src/list_header/edit_modal/index.tsx index 2db02aefd3af7..51b18adfbea32 100644 --- a/packages/kbn-securitysolution-exception-list-components/src/list_header/edit_modal/index.tsx +++ b/packages/kbn-securitysolution-exception-list-components/src/list_header/edit_modal/index.tsx @@ -43,7 +43,7 @@ const EditModalComponent: FC = ({ listDetails, onSave, onCancel )} -

{i18n.EXCEPTION_LIST_HEADER_EDIT_MODAL_TITLE(listDetails.name)}

+ {i18n.EXCEPTION_LIST_HEADER_EDIT_MODAL_TITLE(listDetails.name)} diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 4c8c7067e2ceb..eb4c5d4d8b484 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -84,6 +84,6 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.4.0': ['Elastic License 2.0'], - '@elastic/eui@73.0.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@74.0.1': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry }; diff --git a/src/plugins/dashboard/public/dashboard_actions/copy_to_dashboard_modal.tsx b/src/plugins/dashboard/public/dashboard_actions/copy_to_dashboard_modal.tsx index dbabf2f1ee76b..2a41cc5a2bd8e 100644 --- a/src/plugins/dashboard/public/dashboard_actions/copy_to_dashboard_modal.tsx +++ b/src/plugins/dashboard/public/dashboard_actions/copy_to_dashboard_modal.tsx @@ -98,8 +98,8 @@ export function CopyToDashboardModal({ > - -

{dashboardCopyToDashboardActionStrings.getDisplayName()}

+ + {dashboardCopyToDashboardActionStrings.getDisplayName()} diff --git a/src/plugins/dashboard/public/dashboard_app/listing/confirm_overlays.tsx b/src/plugins/dashboard/public/dashboard_app/listing/confirm_overlays.tsx index e1bd8c339e228..b8d6f436c38ba 100644 --- a/src/plugins/dashboard/public/dashboard_app/listing/confirm_overlays.tsx +++ b/src/plugins/dashboard/public/dashboard_app/listing/confirm_overlays.tsx @@ -73,8 +73,8 @@ export const confirmCreateWithUnsaved = ( aria-describedby={descriptionId} > - -

{createConfirmStrings.getCreateTitle()}

+ + {createConfirmStrings.getCreateTitle()} diff --git a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap index 56cda90c489b6..f65b08fc632bc 100644 --- a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap +++ b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap @@ -255,7 +255,7 @@ Array [ @@ -290,7 +290,9 @@ Array [ - + @@ -595,7 +597,7 @@ Array [
@@ -631,7 +633,9 @@ Array [ - + diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap index 5cc6ef3f937f9..cbd533689169a 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap @@ -172,7 +172,7 @@ exports[`UrlFormatEditor should render normally 1`] = ` @@ -237,7 +237,7 @@ exports[`UrlFormatEditor should render normally 1`] = ` @@ -298,7 +298,7 @@ exports[`UrlFormatEditor should render normally 1`] = `
@@ -343,7 +343,9 @@ exports[`UrlFormatEditor should render normally 1`] = ` - + diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap index 2062e11dfd28b..ac6ab1172a535 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap @@ -4,13 +4,11 @@ exports[`Table render conflict summary modal 1`] = ` -

- -

+ diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx index ab6e82b301f01..a7b6cf621bb64 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx @@ -297,12 +297,10 @@ export const getConflictModalContent = ({ <> -

- -

+ diff --git a/src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/customize_title/customize_panel_modal.tsx b/src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/customize_title/customize_panel_modal.tsx index 16c216248a5da..4360f74310f9f 100644 --- a/src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/customize_title/customize_panel_modal.tsx +++ b/src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/customize_title/customize_panel_modal.tsx @@ -79,8 +79,12 @@ export class CustomizePanelModal extends Component { }} > - -

Customize panel

+ + Customize panel diff --git a/src/plugins/kibana_react/public/markdown/markdown.test.tsx b/src/plugins/kibana_react/public/markdown/markdown.test.tsx index c1329540596fe..1657fa5e3ba58 100644 --- a/src/plugins/kibana_react/public/markdown/markdown.test.tsx +++ b/src/plugins/kibana_react/public/markdown/markdown.test.tsx @@ -32,7 +32,7 @@ test('should render links with parentheses correctly', () => { ); }); -test('should add `noreferrer` and `nooopener` to unknown links in new tabs', () => { +test('should add `noreferrer` and `nooopener` to all links in new tabs', () => { const component = shallow( { - const component = shallow( - - ); - expect(component.render().find('a').prop('rel')).toBe('noopener'); -}); - describe('props', () => { const markdown = 'I am *some* [content](https://en.wikipedia.org/wiki/Content) with `markdown`'; diff --git a/src/plugins/saved_objects/public/save_modal/__snapshots__/saved_object_save_modal.test.tsx.snap b/src/plugins/saved_objects/public/save_modal/__snapshots__/saved_object_save_modal.test.tsx.snap index 1c4864ab139e5..0f2367910cefd 100644 --- a/src/plugins/saved_objects/public/save_modal/__snapshots__/saved_object_save_modal.test.tsx.snap +++ b/src/plugins/saved_objects/public/save_modal/__snapshots__/saved_object_save_modal.test.tsx.snap @@ -8,17 +8,15 @@ exports[`SavedObjectSaveModal should render matching snapshot 1`] = ` > -

- -

+ } + /> @@ -109,17 +107,15 @@ exports[`SavedObjectSaveModal should render matching snapshot when custom isVali > -

- -

+ } + /> @@ -210,17 +206,15 @@ exports[`SavedObjectSaveModal should render matching snapshot when custom isVali > -

- -

+ } + /> @@ -311,17 +305,15 @@ exports[`SavedObjectSaveModal should render matching snapshot when given options > -

- -

+ } + /> diff --git a/src/plugins/saved_objects/public/save_modal/saved_object_save_modal.tsx b/src/plugins/saved_objects/public/save_modal/saved_object_save_modal.tsx index d4fc8faa126c2..68dc426d234d4 100644 --- a/src/plugins/saved_objects/public/save_modal/saved_object_save_modal.tsx +++ b/src/plugins/saved_objects/public/save_modal/saved_object_save_modal.tsx @@ -135,13 +135,11 @@ export class SavedObjectSaveModal extends React.Component > -

- -

+ diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap index 3ea072d0499c4..0155059029f4e 100644 --- a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap @@ -27,7 +27,7 @@ exports[`NotFoundErrors component renders correctly for index-pattern type 1`] = aria-label="Saved objects APIs" class="euiLink emotion-euiLink-primary" href="https://www.elastic.co/guide/en/kibana/mocked-test-branch/saved-objects-api.html#saved-objects-api" - rel="noopener" + rel="noopener noreferrer" target="_blank" > Saved objects APIs @@ -76,7 +76,7 @@ exports[`NotFoundErrors component renders correctly for index-pattern-field type aria-label="Saved objects APIs" class="euiLink emotion-euiLink-primary" href="https://www.elastic.co/guide/en/kibana/mocked-test-branch/saved-objects-api.html#saved-objects-api" - rel="noopener" + rel="noopener noreferrer" target="_blank" > Saved objects APIs @@ -125,7 +125,7 @@ exports[`NotFoundErrors component renders correctly for search type 1`] = ` aria-label="Saved objects APIs" class="euiLink emotion-euiLink-primary" href="https://www.elastic.co/guide/en/kibana/mocked-test-branch/saved-objects-api.html#saved-objects-api" - rel="noopener" + rel="noopener noreferrer" target="_blank" > Saved objects APIs @@ -172,7 +172,7 @@ exports[`NotFoundErrors component renders correctly for unknown type 1`] = ` aria-label="Saved objects APIs" class="euiLink emotion-euiLink-primary" href="https://www.elastic.co/guide/en/kibana/mocked-test-branch/saved-objects-api.html#saved-objects-api" - rel="noopener" + rel="noopener noreferrer" target="_blank" > Saved objects APIs diff --git a/src/plugins/unified_search/public/apply_filters/apply_filter_popover_content.tsx b/src/plugins/unified_search/public/apply_filters/apply_filter_popover_content.tsx index cb61703fed5ac..492db78fbabc7 100644 --- a/src/plugins/unified_search/public/apply_filters/apply_filter_popover_content.tsx +++ b/src/plugins/unified_search/public/apply_filters/apply_filter_popover_content.tsx @@ -87,12 +87,10 @@ export default class ApplyFiltersPopoverContent extends Component -

- -

+ diff --git a/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx b/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx index f7e8b11671556..f7eb0c4a74a22 100644 --- a/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx +++ b/src/plugins/unified_search/public/dataview_picker/text_languages_transition_modal.tsx @@ -41,14 +41,12 @@ export default function TextBasedLanguagesTransitionModal({ setIsTextLangTransitionModalVisible(false)} style={{ width: 700 }}> -

- {i18n.translate( - 'unifiedSearch.query.queryBar.indexPattern.textBasedLanguagesTransitionModalTitle', - { - defaultMessage: 'Your query will be removed', - } - )} -

+ {i18n.translate( + 'unifiedSearch.query.queryBar.indexPattern.textBasedLanguagesTransitionModalTitle', + { + defaultMessage: 'Your query will be removed', + } + )} diff --git a/src/plugins/visualizations/public/wizard/agg_based_selection/agg_based_selection.tsx b/src/plugins/visualizations/public/wizard/agg_based_selection/agg_based_selection.tsx index 8ee63361321ef..d4d2c1505bf8a 100644 --- a/src/plugins/visualizations/public/wizard/agg_based_selection/agg_based_selection.tsx +++ b/src/plugins/visualizations/public/wizard/agg_based_selection/agg_based_selection.tsx @@ -57,12 +57,10 @@ class AggBasedSelection extends React.Component -

- -

+ diff --git a/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx b/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx index 908c1a621ebc8..6bc982a824de1 100644 --- a/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx +++ b/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx @@ -67,12 +67,10 @@ function GroupSelection(props: GroupSelectionProps) { <> -

- -

+ diff --git a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx index 89814c0a474a1..5771747794273 100644 --- a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx +++ b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx @@ -33,18 +33,16 @@ export class SearchSelection extends React.Component { -

- {' '} - /{' '} - -

+ {' '} + /{' '} + diff --git a/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/group_details.tsx b/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/group_details.tsx index af67d9abcee5d..36f429b634092 100644 --- a/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/group_details.tsx +++ b/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/group_details.tsx @@ -75,17 +75,15 @@ export function GroupDetails({ <> -

- {isEdit - ? i18n.translate( - 'xpack.apm.serviceGroups.groupDetailsForm.edit.title', - { defaultMessage: 'Edit group' } - ) - : i18n.translate( - 'xpack.apm.serviceGroups.groupDetailsForm.create.title', - { defaultMessage: 'Create group' } - )} -

+ {isEdit + ? i18n.translate( + 'xpack.apm.serviceGroups.groupDetailsForm.edit.title', + { defaultMessage: 'Edit group' } + ) + : i18n.translate( + 'xpack.apm.serviceGroups.groupDetailsForm.create.title', + { defaultMessage: 'Create group' } + )} diff --git a/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx b/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx index 96b0b47a38a1b..ce60f7c461b61 100644 --- a/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx +++ b/x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx @@ -113,13 +113,15 @@ export function SelectServices({ return ( - -

+
+ {i18n.translate( 'xpack.apm.serviceGroups.selectServicesForm.title', - { defaultMessage: 'Select services' } + { + defaultMessage: 'Select services', + } )} -

+ {i18n.translate( @@ -135,6 +137,7 @@ export function SelectServices({ {kueryValidationMessage} )} + )} - + { initialFocus=".canvasCustomElementForm__name" > - -

{title}

- + {title} diff --git a/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap b/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap index 381b9ce329d00..b8d7412279336 100644 --- a/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap +++ b/x-pack/plugins/canvas/shareable_runtime/api/__snapshots__/shareable.test.tsx.snap @@ -141,7 +141,7 @@ exports[`Canvas Shareable Workpad API Placed successfully with default propertie - - - + + + - - - - - - - - + + + + + + + + { @@ -44,6 +42,6 @@ describe('AnalyticsCollectionTable', () => { expect(rows).toHaveLength(1); expect(rows[0]).toMatchObject(analyticsCollections[0]); - expect(wrapper.dive().find(EuiLinkTo).first().prop('to')).toBe('/collections/example/events'); + expect(wrapper.render().find('a').attr('href')).toContain('/collections/example/events'); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx index c2b36f24d7582..42cb988a7bb68 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx @@ -12,7 +12,7 @@ import React from 'react'; import { shallow, ShallowWrapper } from 'enzyme'; -import { EuiBasicTable, EuiEmptyPrompt } from '@elastic/eui'; +import { EuiBasicTable } from '@elastic/eui'; import { mountWithIntl } from '../../../../test_helpers'; @@ -128,7 +128,7 @@ describe('CrawlRequestsTable', () => { wrapper = shallow(); - expect(wrapper.find(EuiBasicTable).dive().find(EuiEmptyPrompt)).toHaveLength(1); + expect(wrapper.render().find('.euiEmptyPrompt')).toHaveLength(1); }); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx index 5115308350066..defa71847a183 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx @@ -84,6 +84,9 @@ describe('DomainsTable', () => { .text(); }); + const getTableBody = () => + wrapper.find(EuiBasicTable).dive().find('RenderWithEuiTheme').renderProp('children')(); + it('renders', () => { expect(wrapper.find(EuiBasicTable)).toHaveLength(1); @@ -104,8 +107,7 @@ describe('DomainsTable', () => { }); it('renders a clickable domain url', () => { - const basicTable = wrapper.find(EuiBasicTable).dive(); - const link = basicTable.find('[data-test-subj="CrawlerDomainURL"]').at(0); + const link = getTableBody().find('[data-test-subj="CrawlerDomainURL"]').at(0); expect(link.dive().text()).toContain('elastic.co'); expect(link.props()).toEqual( @@ -126,8 +128,7 @@ describe('DomainsTable', () => { }); describe('actions column', () => { - const getTable = () => wrapper.find(EuiBasicTable).dive(); - const getActions = () => getTable().find('ExpandedItemActions'); + const getActions = () => getTableBody().find('ExpandedItemActions'); const getActionItems = () => getActions().first().dive().find('DefaultItemAction'); it('will hide the action buttons if the user cannot manage/delete engines', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx index 8a0539b70d542..ebfd1d7eadb96 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx @@ -11,7 +11,7 @@ import React from 'react'; import { shallow } from 'enzyme'; -import { EuiBasicTable, EuiCopy, EuiEmptyPrompt } from '@elastic/eui'; +import { EuiBasicTable, EuiCopy } from '@elastic/eui'; import { HiddenText } from '../../../../shared/hidden_text'; import { ApiTokenTypes } from '../constants'; @@ -93,10 +93,8 @@ describe('CredentialsList', () => { apiTokens: [], }); - const wrapper = shallow() - .find(EuiBasicTable) - .dive(); - expect(wrapper.find(EuiEmptyPrompt)).toHaveLength(1); + const wrapper = shallow(); + expect(wrapper.render().find('.euiEmptyPrompt')).toHaveLength(1); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/audit_logs_modal/audit_logs_modal.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/audit_logs_modal/audit_logs_modal.tsx index da76fefece518..595d881be7b9e 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/audit_logs_modal/audit_logs_modal.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/audit_logs_modal/audit_logs_modal.tsx @@ -43,9 +43,7 @@ export const AuditLogsModal: React.FC = () => { return !isModalVisible ? null : ( - -

{engineName}

- + {engineName} diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table.test.tsx index 2a8a861dfbc37..c23197e6505dc 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table.test.tsx @@ -84,9 +84,10 @@ describe('MetaEnginesTable', () => { it('is hidden by default', () => { const wrapper = shallow(); const table = wrapper.find(EuiBasicTable).dive(); + const tableBody = table.find('RenderWithEuiTheme').renderProp('children')(); - expect(table.find(MetaEnginesTableNameColumnContent)).toHaveLength(1); - expect(table.find(MetaEnginesTableExpandedRow)).toHaveLength(0); + expect(tableBody.find(MetaEnginesTableNameColumnContent)).toHaveLength(1); + expect(tableBody.find(MetaEnginesTableExpandedRow)).toHaveLength(0); }); it('is visible when the row has been expanded', () => { @@ -95,8 +96,10 @@ describe('MetaEnginesTable', () => { expandedSourceEngines: { 'test-engine': true }, }); const wrapper = shallow(); - const table = wrapper.find(EuiBasicTable); - expect(table.dive().find(MetaEnginesTableExpandedRow)).toHaveLength(1); + const table = wrapper.find(EuiBasicTable).dive(); + const tableBody = table.find('RenderWithEuiTheme').renderProp('children')(); + + expect(tableBody.find(MetaEnginesTableExpandedRow)).toHaveLength(1); }); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table_expanded_row.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table_expanded_row.test.tsx index 26c8c0fddcd11..2f329c991076a 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table_expanded_row.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table_expanded_row.test.tsx @@ -62,8 +62,9 @@ describe('MetaEnginesTableExpandedRow', () => { conflictingEngines={new Set(['source-engine-1', 'source-engine-2'])} /> ); + const table = wrapper.find(EuiBasicTable).dive(); + const tableBody = table.find('RenderWithEuiTheme').renderProp('children')(); - const table = wrapper.find(EuiBasicTable); - expect(table.dive().find(EuiHealth)).toHaveLength(2); + expect(tableBody.find(EuiHealth)).toHaveLength(2); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx index d67f2bd776db2..e00497a419a3c 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx @@ -22,7 +22,8 @@ export const runSharedColumnsTests = ( tableContent: string, values: object = {} ) => { - const getTable = () => wrapper.find(EuiBasicTable).dive(); + const getTableBody = () => + wrapper.find(EuiBasicTable).dive().find('RenderWithEuiTheme').renderProp('children')(); describe('name column', () => { it('renders', () => { @@ -54,7 +55,7 @@ export const runSharedColumnsTests = ( }); describe('actions column', () => { - const getActions = () => getTable().find('ExpandedItemActions'); + const getActions = () => getTableBody().find('ExpandedItemActions'); const getActionItems = () => getActions().dive().find('DefaultItemAction'); it('will hide the action buttons if the user cannot manage/delete engines', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.test.tsx index ec0dde74ecf32..074cfa6fce9bb 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.test.tsx @@ -59,7 +59,7 @@ describe('SynonymModal', () => { const wrapper = shallow(); it('renders', () => { - expect(wrapper.find('h1').text()).toEqual('Add a synonym set'); + expect(wrapper.find('EuiModalHeaderTitle').render().text()).toEqual('Add a synonym set'); }); it('populates MultiInputRows with two empty rows', () => { @@ -87,7 +87,7 @@ describe('SynonymModal', () => { }); it('renders', () => { - expect(wrapper.find('h1').text()).toEqual('Manage synonym set'); + expect(wrapper.find('EuiModalHeaderTitle').render().text()).toEqual('Manage synonym set'); }); it('populates MultiInputRows with ID & initial values', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.tsx index 5df254768faac..93dbc9cea4447 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/synonyms/components/synonym_modal.tsx @@ -48,9 +48,7 @@ export const SynonymModal: React.FC = () => { return isModalOpen ? ( - -

{modalTitle}

- + {modalTitle} diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawl_requests_panel/crawl_requests_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawl_requests_panel/crawl_requests_table.test.tsx index 71f37fcaf19cd..9302c234ba491 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawl_requests_panel/crawl_requests_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawl_requests_panel/crawl_requests_table.test.tsx @@ -12,7 +12,7 @@ import React from 'react'; import { shallow, ShallowWrapper } from 'enzyme'; -import { EuiBasicTable, EuiEmptyPrompt } from '@elastic/eui'; +import { EuiBasicTable } from '@elastic/eui'; import { mountWithIntl } from '@kbn/test-jest-helpers'; import { CrawlEvent, CrawlerStatus, CrawlType } from '../../../../api/crawler/types'; @@ -125,7 +125,7 @@ describe('CrawlRequestsTable', () => { wrapper = shallow(); - expect(wrapper.find(EuiBasicTable).dive().find(EuiEmptyPrompt)).toHaveLength(1); + expect(wrapper.render().find('.euiEmptyPrompt')).toHaveLength(1); }); }); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx index 46b3ed3ba6058..350ef6ba68672 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx @@ -91,6 +91,9 @@ describe('DomainsTable', () => { .text(); }); + const getTableBody = () => + wrapper.find(EuiBasicTable).dive().find('RenderWithEuiTheme').renderProp('children')(); + it('renders', () => { expect(wrapper.find(EuiBasicTable)).toHaveLength(1); @@ -111,8 +114,7 @@ describe('DomainsTable', () => { }); it('renders a clickable domain url', () => { - const basicTable = wrapper.find(EuiBasicTable).dive(); - const link = basicTable.find('[data-test-subj="CrawlerDomainURL"]').at(0); + const link = getTableBody().find('[data-test-subj="CrawlerDomainURL"]').at(0); expect(link.dive().text()).toContain('elastic.co'); expect(link.props()).toEqual( @@ -133,8 +135,7 @@ describe('DomainsTable', () => { }); describe('actions column', () => { - const getTable = () => wrapper.find(EuiBasicTable).dive(); - const getActions = () => getTable().find('ExpandedItemActions'); + const getActions = () => getTableBody().find('ExpandedItemActions'); const getActionItems = () => getActions().first().dive().find('DefaultItemAction'); describe('when the user can manage/delete engines', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/sources_view.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/sources_view.tsx index a7c981dad9103..6e1e2d8f6e545 100644 --- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/sources_view.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/sources_view.tsx @@ -54,24 +54,24 @@ export const SourcesView: React.FC = ({ children }) => { }) => ( - - - - - - + + + + + + {i18n.translate('xpack.enterpriseSearch.workplaceSearch.sourcesView.modal.heading', { defaultMessage: '{addedSourceName} requires additional configuration', values: { addedSourceName }, })} - - - + + + diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/license_modal.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/license_modal.tsx index eafdbfb2debe2..51aa501b71b42 100644 --- a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/license_modal.tsx +++ b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/license_modal.tsx @@ -53,9 +53,7 @@ export const LicenseModal: React.FunctionComponent = ({ return ( - -

{licenseName}

- + {licenseName} diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/notice_modal.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/notice_modal.tsx index f933912754889..4ef6dde3fb2f6 100644 --- a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/notice_modal.tsx +++ b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/notice_modal.tsx @@ -48,9 +48,7 @@ export const NoticeModal: React.FunctionComponent = ({ noticePath, onClos return ( - -

NOTICE.txt

- + NOTICE.txt diff --git a/x-pack/plugins/license_management/__jest__/__snapshots__/request_trial_extension.test.js.snap b/x-pack/plugins/license_management/__jest__/__snapshots__/request_trial_extension.test.js.snap index 16119656ce53b..abaa2ffaccd0d 100644 --- a/x-pack/plugins/license_management/__jest__/__snapshots__/request_trial_extension.test.js.snap +++ b/x-pack/plugins/license_management/__jest__/__snapshots__/request_trial_extension.test.js.snap @@ -33,7 +33,7 @@ exports[`RequestTrialExtension component should display when enterprise license subscription features @@ -61,7 +61,7 @@ exports[`RequestTrialExtension component should display when enterprise license class="euiButton emotion-euiButtonDisplay-m-defaultMinWidth-m-base-primary" data-test-subj="extendTrialButton" href="https://www.elastic.co/trialextension" - rel="noopener" + rel="noopener noreferrer" target="_blank" > subscription features @@ -137,7 +137,7 @@ exports[`RequestTrialExtension component should display when license is active a class="euiButton emotion-euiButtonDisplay-m-defaultMinWidth-m-base-primary" data-test-subj="extendTrialButton" href="https://www.elastic.co/trialextension" - rel="noopener" + rel="noopener noreferrer" target="_blank" > subscription features @@ -213,7 +213,7 @@ exports[`RequestTrialExtension component should display when license is not acti class="euiButton emotion-euiButtonDisplay-m-defaultMinWidth-m-base-primary" data-test-subj="extendTrialButton" href="https://www.elastic.co/trialextension" - rel="noopener" + rel="noopener noreferrer" target="_blank" > subscription features @@ -289,7 +289,7 @@ exports[`RequestTrialExtension component should display when platinum license is class="euiButton emotion-euiButtonDisplay-m-defaultMinWidth-m-base-primary" data-test-subj="extendTrialButton" href="https://www.elastic.co/trialextension" - rel="noopener" + rel="noopener noreferrer" target="_blank" > subscription features @@ -107,7 +107,7 @@ exports[`RevertToBasic component should display when license is expired 1`] = ` subscription features @@ -181,7 +181,7 @@ exports[`RevertToBasic component should display when trial is active 1`] = ` subscription features diff --git a/x-pack/plugins/license_management/__jest__/__snapshots__/start_trial.test.js.snap b/x-pack/plugins/license_management/__jest__/__snapshots__/start_trial.test.js.snap index 0f13544c3ee1b..1caa3ed2851d8 100644 --- a/x-pack/plugins/license_management/__jest__/__snapshots__/start_trial.test.js.snap +++ b/x-pack/plugins/license_management/__jest__/__snapshots__/start_trial.test.js.snap @@ -33,7 +33,7 @@ exports[`StartTrial component when trial is allowed display for basic license 1` subscription features @@ -107,7 +107,7 @@ exports[`StartTrial component when trial is allowed should display for expired e subscription features @@ -181,7 +181,7 @@ exports[`StartTrial component when trial is allowed should display for expired p subscription features @@ -255,7 +255,7 @@ exports[`StartTrial component when trial is allowed should display for gold lice subscription features diff --git a/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/__snapshots__/custom_icon_modal.test.tsx.snap b/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/__snapshots__/custom_icon_modal.test.tsx.snap index b21e9b36d89ff..ea6691fa10021 100644 --- a/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/__snapshots__/custom_icon_modal.test.tsx.snap +++ b/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/__snapshots__/custom_icon_modal.test.tsx.snap @@ -8,10 +8,10 @@ exports[`should render a custom icon modal with an existing icon 1`] = ` onClose={[Function]} > - -

- Edit custom icon -

+ + Edit custom icon @@ -230,10 +230,10 @@ exports[`should render an empty custom icon modal 1`] = ` onClose={[Function]} > - -

- Custom Icon -

+ + Custom Icon diff --git a/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/custom_icon_modal.tsx b/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/custom_icon_modal.tsx index 76659ba9c50bc..6b29efe840945 100644 --- a/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/custom_icon_modal.tsx +++ b/x-pack/plugins/maps/public/classes/styles/vector/components/symbol/custom_icon_modal.tsx @@ -328,9 +328,7 @@ export class CustomIconModal extends Component { initialFocus=".mapsCustomIconForm__image" > - -

{title}

- + {title} diff --git a/x-pack/plugins/ml/public/application/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx b/x-pack/plugins/ml/public/application/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx index 8ac2a22be5a93..4b576695c981a 100644 --- a/x-pack/plugins/ml/public/application/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx +++ b/x-pack/plugins/ml/public/application/components/delete_space_aware_item_check_modal/delete_space_aware_item_check_modal.tsx @@ -339,12 +339,10 @@ export const DeleteSpaceAwareItemCheckModal: FC = ({ <> -

- -

+ diff --git a/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js b/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js index cc76a708fc77b..64910f5abfd21 100644 --- a/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js +++ b/x-pack/plugins/ml/public/application/components/validate_job/validate_job_view.js @@ -84,9 +84,7 @@ const LoadingSpinner = () => ( const Modal = ({ close, title, children }) => ( - -

{title}

- + {title} {children} diff --git a/x-pack/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx b/x-pack/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx index a5b24a2290d67..d030cfc9b92b6 100644 --- a/x-pack/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx +++ b/x-pack/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx @@ -81,9 +81,7 @@ export const AddToDashboardControl: FC = ({ return ( - -

{title}

- + {title} {children} diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx index e1ec74412990b..f0c78c3828aeb 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/confirm_modals/close_jobs_confirm_modal.tsx @@ -87,9 +87,7 @@ export const CloseJobsConfirmModal: FC = ({ return ( - -

{title}

- + {title} = ({ return ( - -

{title}

- + {title} = ({ setShowFunction, unsetShowFunction, -

- -

+ diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx index d77ed5c3bb2db..9a7508c634c6b 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/tabs/custom_urls.tsx @@ -288,12 +288,10 @@ class CustomUrlsUI extends Component { > -

- -

+ diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx index 55891b3b3b579..335b19bd3a794 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/reset_job_modal/reset_job_modal.tsx @@ -87,16 +87,14 @@ export const ResetJobModal: FC = ({ setShowFunction, unsetShowFunction, r -

- -

+ diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js index 3a2728a810427..c4c53b00591f4 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/start_datafeed_modal/start_datafeed_modal.js @@ -149,16 +149,14 @@ export class StartDatafeedModal extends Component { > -

- -

+ diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx index 9617458c6e811..cc3b20966935b 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx @@ -129,12 +129,10 @@ export const ChangeDataViewModal: FC = ({ onClose }) => { -

- -

+ diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx index 3ab60cd8225cc..12344c651bd11 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/modal_wrapper.tsx @@ -34,12 +34,10 @@ export const ModalWrapper: FC = ({ onCreateClick, closeModal, saveEnabled > -

- -

+ diff --git a/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/__snapshots__/import_modal.test.js.snap b/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/__snapshots__/import_modal.test.js.snap index 61449ab5168d9..16074e3849d02 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/__snapshots__/import_modal.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/calendars/edit/import_modal/__snapshots__/import_modal.test.js.snap @@ -15,13 +15,11 @@ exports[`ImportModal Renders import modal 1`] = ` grow={false} > -

- -

+ -

- -

+ diff --git a/x-pack/plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js b/x-pack/plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js index 255405c8cd265..ae2815ebb5cd6 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js +++ b/x-pack/plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js @@ -266,12 +266,10 @@ export class NewEventModal extends Component { > -

- -

+ diff --git a/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js b/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js index 1ae5ee2b05604..9b7adcf2bce32 100644 --- a/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js +++ b/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/modal.js @@ -33,12 +33,10 @@ export function Modal(props) { -

- -

+ diff --git a/x-pack/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx b/x-pack/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx index f6799469fd1e6..b4f0bc0ec505e 100644 --- a/x-pack/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx +++ b/x-pack/plugins/ml/public/application/trained_models/models_management/delete_models_modal.tsx @@ -69,16 +69,14 @@ export const DeleteModelsModal: FC = ({ modelIds, onClos > -

- -

+ diff --git a/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx b/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx index c999376eebeaf..4c4bd6293bc8a 100644 --- a/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx +++ b/x-pack/plugins/ml/public/application/trained_models/models_management/deployment_setup.tsx @@ -23,10 +23,7 @@ import { EuiCallOut, EuiSpacer, EuiDescribedFormGroup, - EuiFlexGroup, - EuiFlexItem, EuiLink, - EuiTitle, } from '@elastic/eui'; import { toMountPoint, wrapWithTheme } from '@kbn/kibana-react-plugin/public'; import type { Observable } from 'rxjs'; @@ -285,30 +282,20 @@ export const StartUpdateDeploymentModal: FC = ({ data-test-subj="mlModelsStartDeploymentModal" > - - - - -

- {isUpdate ? ( - - ) : ( - - )} -

- - - - - + + {isUpdate ? ( + + ) : ( + + )} diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx b/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx index 9c2c373a3c1e2..70f263e6283ea 100644 --- a/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx +++ b/x-pack/plugins/ml/public/embeddables/anomaly_charts/anomaly_charts_initializer.tsx @@ -53,12 +53,10 @@ export const AnomalyChartsInitializer: FC = ({ > -

- -

+ diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx index c4c2fc7262eac..e5e2c2fd3b6be 100644 --- a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx +++ b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/anomaly_swimlane_initializer.tsx @@ -93,12 +93,10 @@ export const AnomalySwimlaneInitializer: FC = ( -

- -

+ diff --git a/x-pack/plugins/monitoring/public/alerts/enable_alerts_modal.tsx b/x-pack/plugins/monitoring/public/alerts/enable_alerts_modal.tsx index ca1af4d464efa..ad2d029296538 100644 --- a/x-pack/plugins/monitoring/public/alerts/enable_alerts_modal.tsx +++ b/x-pack/plugins/monitoring/public/alerts/enable_alerts_modal.tsx @@ -84,12 +84,10 @@ export const EnableAlertsModal: React.FC = ({ alerts }: Props) => { -

- -

+ diff --git a/x-pack/plugins/monitoring/public/components/no_data/explanations/exporters/__snapshots__/exporters.test.js.snap b/x-pack/plugins/monitoring/public/components/no_data/explanations/exporters/__snapshots__/exporters.test.js.snap index adb64f6bec54c..dc54838631c06 100644 --- a/x-pack/plugins/monitoring/public/components/no_data/explanations/exporters/__snapshots__/exporters.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/no_data/explanations/exporters/__snapshots__/exporters.test.js.snap @@ -82,7 +82,7 @@ Array [ Elasticsearch Service Console @@ -102,7 +102,7 @@ Array [ Logs and metrics @@ -122,7 +122,7 @@ Array [ the documentation page. diff --git a/x-pack/plugins/monitoring/public/components/no_data/reasons/__snapshots__/reason_found.test.js.snap b/x-pack/plugins/monitoring/public/components/no_data/reasons/__snapshots__/reason_found.test.js.snap index 76dc6356116ae..f0cd3be053d26 100644 --- a/x-pack/plugins/monitoring/public/components/no_data/reasons/__snapshots__/reason_found.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/no_data/reasons/__snapshots__/reason_found.test.js.snap @@ -149,7 +149,7 @@ Array [ Elasticsearch Service Console @@ -169,7 +169,7 @@ Array [ Logs and metrics @@ -189,7 +189,7 @@ Array [ the documentation page. diff --git a/x-pack/plugins/security_solution/public/common/components/sourcerer/update_default_data_view_modal.tsx b/x-pack/plugins/security_solution/public/common/components/sourcerer/update_default_data_view_modal.tsx index 29cace7f075de..53b9e035a5357 100644 --- a/x-pack/plugins/security_solution/public/common/components/sourcerer/update_default_data_view_modal.tsx +++ b/x-pack/plugins/security_solution/public/common/components/sourcerer/update_default_data_view_modal.tsx @@ -45,9 +45,7 @@ export const UpdateDefaultDataViewModal = React.memo( isShowing ? ( - -

{i18n.UPDATE_SECURITY_DATA_VIEW}

- + {i18n.UPDATE_SECURITY_DATA_VIEW} diff --git a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap index 08ca630fc3d67..e99916498b22d 100644 --- a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap @@ -180,7 +180,7 @@ exports[`Authentication Host Table Component rendering it renders the host authe
@@ -346,7 +346,9 @@ exports[`Authentication Host Table Component rendering it renders the host authe - + diff --git a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_user_table.test.tsx.snap b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_user_table.test.tsx.snap index 38a6936e156ca..dfcedad275512 100644 --- a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_user_table.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_user_table.test.tsx.snap @@ -180,7 +180,7 @@ exports[`Authentication User Table Component rendering it renders the user authe
@@ -346,7 +346,9 @@ exports[`Authentication User Table Component rendering it renders the user authe - + diff --git a/x-pack/plugins/synthetics/public/legacy_uptime/components/monitor/ping_list/__snapshots__/expanded_row.test.tsx.snap b/x-pack/plugins/synthetics/public/legacy_uptime/components/monitor/ping_list/__snapshots__/expanded_row.test.tsx.snap index 5be2524c6ebce..7b8cb38a08d11 100644 --- a/x-pack/plugins/synthetics/public/legacy_uptime/components/monitor/ping_list/__snapshots__/expanded_row.test.tsx.snap +++ b/x-pack/plugins/synthetics/public/legacy_uptime/components/monitor/ping_list/__snapshots__/expanded_row.test.tsx.snap @@ -172,7 +172,7 @@ exports[`PingListExpandedRow renders link to docs if body is not recorded but it docs diff --git a/x-pack/plugins/triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx b/x-pack/plugins/triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx index 702fbad50a85c..b80a5361f4d5e 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx @@ -261,13 +261,11 @@ export const RulesSettingsModal = memo((props: RulesSettingsModalProps) => { return ( - -

- -

+ + diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx index 0fefaef24129e..4f704af65827d 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx @@ -15,7 +15,6 @@ import { EuiModalHeaderTitle, EuiModalBody, EuiModalFooter, - EuiTitle, EuiFlexItem, EuiIcon, EuiFlexGroup, @@ -135,40 +134,36 @@ const ConnectorAddModal = ({ return ( - - - {actionTypeModel && actionTypeModel.iconClass ? ( - - - - ) : null} + + {actionTypeModel && actionTypeModel.iconClass ? ( - - - -

- -

- - - {actionTypeModel && actionTypeModel.isExperimental && ( - - - - )} - + - - + ) : null} + + + + + + + + {actionTypeModel && actionTypeModel.isExperimental && ( + + + + )} + + + diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/field_browser_modal.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/field_browser_modal.tsx index 2a6a8634ba666..cff489c3c15be 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/field_browser_modal.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/field_browser_modal.tsx @@ -133,9 +133,7 @@ const FieldBrowserModalComponent: React.FC = ({
- -

{i18n.FIELDS_BROWSER}

- + {i18n.FIELDS_BROWSER} diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/bulk_snooze_modal.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/bulk_snooze_modal.tsx index fb50934e4d6b1..5e6dcf3ab0d2d 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/bulk_snooze_modal.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/bulk_snooze_modal.tsx @@ -166,8 +166,8 @@ export const BulkSnoozeModal = (props: BulkSnoozeModalProps) => { id="xpack.triggersActionsUI.sections.rulesList.bulkSnoozeModal.modalTitle" defaultMessage="Add snooze now" /> - + id="xpack.triggersActionsUI.sections.rulesList.bulkSnoozeScheduleModal.modalTitle" defaultMessage="Add snooze schedule" /> - +