From 8265ebc1c63e9fb11926d56fb7a08bc80be064c8 Mon Sep 17 00:00:00 2001
From: Shahzad <shahzad.muhammad@elastic.co>
Date: Thu, 2 Apr 2020 19:00:34 +0200
Subject: [PATCH] =?UTF-8?q?[Uptime]=20Convert=20anomaly=20Jobs=20name=20to?=
 =?UTF-8?q?=20lowercase=20to=20comply=20with=E2=80=A6=20(#62293)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* converted ml job name to lower case

* update type
---
 .../__snapshots__/ml_job_link.test.tsx.snap   |  2 +-
 .../ml/ml_flyout_container.tsx                |  8 +++---
 .../uptime/public/state/api/ml_anomaly.ts     | 25 +++++++++++++------
 3 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap
index 85988af04a939..9957f13fc1334 100644
--- a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap
+++ b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`ML JobLink renders without errors 1`] = `
 <a
   class="euiButtonEmpty euiButtonEmpty--primary euiButtonEmpty--small"
-  href="/app/ml#/explorer?_g=(ml:(jobIds:!(testMonitor_high_latency_by_geo)),refreshInterval:(pause:!t,value:0),time:(from:'',to:''))&_a=(mlExplorerFilter:(filterActive:!t,filteredFields:!(monitor.id,testMonitor)),mlExplorerSwimlane:(viewByFieldName:observer.geo.name))"
+  href="/app/ml#/explorer?_g=(ml:(jobIds:!(testmonitor_high_latency_by_geo)),refreshInterval:(pause:!t,value:0),time:(from:'',to:''))&_a=(mlExplorerFilter:(filterActive:!t,filteredFields:!(monitor.id,testMonitor)),mlExplorerSwimlane:(viewByFieldName:observer.geo.name))"
   rel="noopener noreferrer"
   target="_blank"
 >
diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx
index fad12de94fd81..8ebd69a2d503b 100644
--- a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx
+++ b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx
@@ -48,13 +48,13 @@ const showMLJobNotification = (
           </MLJobLink>
         </p>
       ),
-      toastLifeTimeMs: 5000,
+      toastLifeTimeMs: 10000,
     });
   } else {
-    notifications.toasts.warning({
+    notifications.toasts.danger({
       title: <p>{labels.JOB_CREATION_FAILED}</p>,
       body: message ?? <p>{labels.JOB_CREATION_FAILED_MESSAGE}</p>,
-      toastLifeTimeMs: 5000,
+      toastLifeTimeMs: 10000,
     });
   }
 };
@@ -108,7 +108,7 @@ export const MachineLearningFlyout: React.FC<Props> = ({ onClose }) => {
           basePath,
           { to: dateRangeEnd, from: dateRangeStart },
           false,
-          error?.body?.message
+          error?.message || error?.body?.message
         );
       }
       setIsCreatingJob(false);
diff --git a/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts b/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts
index 80b97783769b5..1a945512f7cd9 100644
--- a/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts
+++ b/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts
@@ -13,7 +13,7 @@ import { CreateMLJobSuccess, DeleteJobResults, MonitorIdParam } from '../actions
 import { DataRecognizerConfigResponse } from '../../../../../../plugins/ml/common/types/modules';
 import { JobExistResult } from '../../../../../../plugins/ml/common/types/data_recognizer';
 
-export const getMLJobId = (monitorId: string) => `${monitorId}_${ML_JOB_ID}`;
+export const getMLJobId = (monitorId: string) => `${monitorId}_${ML_JOB_ID}`.toLowerCase();
 
 export const getMLCapabilities = async (): Promise<PrivilegesResponse> => {
   return await apiService.get(API_URLS.ML_CAPABILITIES);
@@ -28,8 +28,11 @@ export const createMLJob = async ({
 }: MonitorIdParam): Promise<CreateMLJobSuccess | null> => {
   const url = API_URLS.ML_SETUP_MODULE + ML_MODULE_ID;
 
+  // ML App doesn't support upper case characters in job name
+  const lowerCaseMonitorId = monitorId.toLowerCase();
+
   const data = {
-    prefix: `${monitorId}_`,
+    prefix: `${lowerCaseMonitorId}_`,
     useDedicatedIndex: false,
     startDatafeed: true,
     start: moment()
@@ -41,7 +44,7 @@ export const createMLJob = async ({
         filter: [
           {
             term: {
-              'monitor.id': monitorId,
+              'monitor.id': lowerCaseMonitorId,
             },
           },
         ],
@@ -50,11 +53,17 @@ export const createMLJob = async ({
   };
 
   const response: DataRecognizerConfigResponse = await apiService.post(url, data);
-  if (response?.jobs?.[0]?.id === getMLJobId(monitorId) && response?.jobs?.[0]?.success) {
-    return {
-      count: 1,
-      jobId: response?.jobs?.[0]?.id,
-    };
+  if (response?.jobs?.[0]?.id === getMLJobId(monitorId)) {
+    const jobResponse = response.jobs[0];
+    if (jobResponse.success) {
+      return {
+        count: 1,
+        jobId: jobResponse.id,
+      };
+    } else {
+      const { error } = jobResponse;
+      throw new Error(error?.msg);
+    }
   } else {
     return null;
   }