diff --git a/.eslintrc.js b/.eslintrc.js index 5b5ef73ed3806..6657ba3cb1f01 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -909,11 +909,15 @@ module.exports = { { files: [ 'x-pack/plugins/apm/**/*.{js,mjs,ts,tsx}', - 'x-pack/plugins/observability/**/*.{js,mjs,ts,tsx}', 'x-pack/plugins/exploratory_view/**/*.{js,mjs,ts,tsx}', - 'x-pack/plugins/ux/**/*.{js,mjs,ts,tsx}', - 'x-pack/plugins/synthetics/**/*.{js,mjs,ts,tsx}', 'x-pack/plugins/infra/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/observability/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/observability_ai_assistant/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/observability_onboarding/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/observability_shared/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/profiling/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/synthetics/**/*.{js,mjs,ts,tsx}', + 'x-pack/plugins/ux/**/*.{js,mjs,ts,tsx}', ], rules: { '@kbn/telemetry/event_generating_elements_should_be_instrumented': 'error', diff --git a/packages/kbn-eslint-plugin-telemetry/helpers/check_node_for_existing_data_test_subj_prop.ts b/packages/kbn-eslint-plugin-telemetry/helpers/check_node_for_existing_data_test_subj_prop.ts index b739dc5116c1c..ef0e32c1d2755 100644 --- a/packages/kbn-eslint-plugin-telemetry/helpers/check_node_for_existing_data_test_subj_prop.ts +++ b/packages/kbn-eslint-plugin-telemetry/helpers/check_node_for_existing_data_test_subj_prop.ts @@ -37,7 +37,7 @@ export function checkNodeForExistingDataTestSubjProp( const variable = getScope().variables.find((v) => v.name === name); // the variable definition of the spreaded variable return variable && variable.defs.length > 0 - ? variable.defs[0].node.init.properties.find((property: TSESTree.Property) => { + ? variable.defs[0].node.init?.properties.find((property: TSESTree.Property) => { if ('value' in property.key) { return property.key.value === 'data-test-subj'; } diff --git a/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.test.ts b/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.test.ts index c8829f05efd21..f08cfa26cbc90 100644 --- a/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.test.ts +++ b/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.test.ts @@ -63,7 +63,8 @@ for (const [name, tester] of [tsTester, babelTester]) { ], output: `<${element} data-test-subj="Value${element .replace('Eui', '') - .replace('Empty', '')}">Value`, + .replace('Empty', '') + .replace('Icon', '')}">Value`, })), } ); diff --git a/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.ts b/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.ts index d2069d2845e59..7242ff1645f5e 100644 --- a/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.ts +++ b/packages/kbn-eslint-plugin-telemetry/rules/event_generating_elements_should_be_instrumented.ts @@ -17,6 +17,7 @@ import { getFunctionName } from '../helpers/get_function_name'; export const EVENT_GENERATING_ELEMENTS = [ 'EuiButton', 'EuiButtonEmpty', + 'EuiButtonIcon', 'EuiLink', 'EuiFieldText', 'EuiFieldSearch', @@ -74,7 +75,7 @@ export const EventGeneratingElementsShouldBeInstrumented: Rule.RuleModule = { const intent = getIntentFromNode(parent); // 4. The element name that generates the events - const element = name.replace('Eui', '').replace('Empty', ''); + const element = name.replace('Eui', '').replace('Empty', '').replace('Icon', ''); const suggestion = `${appName}${componentName}${intent}${element}`; // 'o11yHeaderActionsSubmitButton' diff --git a/x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx b/x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx index 3a972b44f9a41..c883376cac4e1 100644 --- a/x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx +++ b/x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx @@ -51,6 +51,7 @@ export function HelpPopoverButton({ return ( {value && ( {value && ( ( ( setConfigToBeDeleted(config)} diff --git a/x-pack/plugins/apm/public/components/app/settings/agent_keys/create_agent_key/agent_key_callout.tsx b/x-pack/plugins/apm/public/components/app/settings/agent_keys/create_agent_key/agent_key_callout.tsx index 7f5d83f5beb1a..535bd2ed6b4f0 100644 --- a/x-pack/plugins/apm/public/components/app/settings/agent_keys/create_agent_key/agent_key_callout.tsx +++ b/x-pack/plugins/apm/public/components/app/settings/agent_keys/create_agent_key/agent_key_callout.tsx @@ -58,6 +58,7 @@ export function AgentKeyCallOut({ name, token }: Props) { {(copy) => ( { @@ -108,6 +109,7 @@ export function DiscoveryRule({ { diff --git a/x-pack/plugins/apm/public/components/shared/popover_tooltip/index.tsx b/x-pack/plugins/apm/public/components/shared/popover_tooltip/index.tsx index 4e119c52c8046..df3330a12c590 100644 --- a/x-pack/plugins/apm/public/components/shared/popover_tooltip/index.tsx +++ b/x-pack/plugins/apm/public/components/shared/popover_tooltip/index.tsx @@ -28,6 +28,7 @@ export function PopoverTooltip({ closePopover={() => setIsPopoverOpen(false)} button={ ) => { setIsPopoverOpen(!isPopoverOpen); diff --git a/x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx b/x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx index f223cf0036114..167ce52572dc8 100644 --- a/x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx +++ b/x-pack/plugins/apm/public/components/shared/span_links/span_links_table.tsx @@ -142,6 +142,7 @@ export function SpanLinksTable({ items }: Props) { { diff --git a/x-pack/plugins/apm/public/tutorial/config_agent/opentelemetry_instructions.tsx b/x-pack/plugins/apm/public/tutorial/config_agent/opentelemetry_instructions.tsx index 2ea2a993816b7..0b105d0550143 100644 --- a/x-pack/plugins/apm/public/tutorial/config_agent/opentelemetry_instructions.tsx +++ b/x-pack/plugins/apm/public/tutorial/config_agent/opentelemetry_instructions.tsx @@ -83,6 +83,7 @@ export function OpenTelemetryInstructions({ {value && ( closePopover()} aria-label={i18n.translate('xpack.exploratoryView.search.url.close', { diff --git a/x-pack/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/columns/series_actions.tsx b/x-pack/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/columns/series_actions.tsx index a2e78fb36c41f..fec7360b253f2 100644 --- a/x-pack/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/columns/series_actions.tsx +++ b/x-pack/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/columns/series_actions.tsx @@ -72,6 +72,7 @@ export function SeriesActions({ seriesId, series, seriesConfig, onEditClick }: P const popoverButton = ( setIsEditingEnabled(!isEditingEnabled)} iconType="pencil" aria-label={i18n.translate('xpack.exploratoryView.expView.seriesEditor.editName', { diff --git a/x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx b/x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx index f06335145877d..340c00b9f48cc 100644 --- a/x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx +++ b/x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx @@ -578,6 +578,7 @@ export const ExpressionRow: React.FC = (props) => { = (props) => { /> = (props) => { {canDelete && ( {children} {children} = ({ {canDelete && ( {children} {children} = (props) => { /> = (props) => { {canDelete && ( ({ return ( = ({ = ({ = ({ {page} {page} - + diff --git a/x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx b/x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx index 197e0ae1cb2a1..01b047f2e3664 100644 --- a/x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx +++ b/x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/properties/table.tsx @@ -65,6 +65,7 @@ export const Table = (props: Props) => { )} > onEdit(metric)} aria-label={i18n.translate( @@ -55,6 +56,7 @@ export const MetricsEditMode = withTheme( onDelete(metric)} diff --git a/x-pack/plugins/infra/public/pages/metrics/metric_detail/components/metadata_details.tsx b/x-pack/plugins/infra/public/pages/metrics/metric_detail/components/metadata_details.tsx index edd760bc17f64..e1596f52aa3c3 100644 --- a/x-pack/plugins/infra/public/pages/metrics/metric_detail/components/metadata_details.tsx +++ b/x-pack/plugins/infra/public/pages/metrics/metric_detail/components/metadata_details.tsx @@ -142,6 +142,7 @@ export const MetadataDetails = (props: Props) => { {filteredFields.length > NUMBER_OF_COLUMNS ? ( {children} = (props) => { {canDelete && ( setIsPopoverOpen(true)} color={'text'} @@ -110,6 +111,7 @@ export function WebCoreVitalsTitle({ isOpen={isBrowserPopoverOpen} button={ setIsBrowserPopoverOpen(true)} color={'text'} diff --git a/x-pack/plugins/observability/public/pages/slo_edit/components/custom_metric/metric_indicator.tsx b/x-pack/plugins/observability/public/pages/slo_edit/components/custom_metric/metric_indicator.tsx index f451d5d98007c..a333a353f97d9 100644 --- a/x-pack/plugins/observability/public/pages/slo_edit/components/custom_metric/metric_indicator.tsx +++ b/x-pack/plugins/observability/public/pages/slo_edit/components/custom_metric/metric_indicator.tsx @@ -213,6 +213,7 @@ export function MetricIndicator({ type, indexFields, isLoadingIndex }: MetricInd { lens.navigateToPrefilledEditor(lensEmbeddableInput); @@ -101,6 +102,7 @@ function Lens({ { setIsSaveModalOpen(() => true); diff --git a/x-pack/plugins/observability_onboarding/public/components/app/custom_logs/wizard/api_key_banner.tsx b/x-pack/plugins/observability_onboarding/public/components/app/custom_logs/wizard/api_key_banner.tsx index c55f554fc4845..b0d6b5f9e6c26 100644 --- a/x-pack/plugins/observability_onboarding/public/components/app/custom_logs/wizard/api_key_banner.tsx +++ b/x-pack/plugins/observability_onboarding/public/components/app/custom_logs/wizard/api_key_banner.tsx @@ -93,6 +93,7 @@ export function ApiKeyBanner({ {(copy) => ( void }) { return ( , 0 && ( removeLogFilePath(index)} @@ -265,7 +268,11 @@ export function ConfigureLogs() { gutterSize="xs" > - + {i18n.translate( 'xpack.observability_onboarding.configureLogs.logFile.addRow', { @@ -313,6 +320,7 @@ export function ConfigureLogs() { } > setCustomConfigurations(event.target.value) @@ -514,6 +526,7 @@ export function ConfigureLogs() { error={integrationNameError} > , - + {i18n.translate( 'xpack.observability_onboarding.steps.inspect', { defaultMessage: 'Inspect' } @@ -242,6 +245,7 @@ export function InstallElasticAgent() { + {i18n.translate('xpack.observability_onboarding.steps.back', { defaultMessage: 'Back', })} @@ -183,6 +187,7 @@ export function SelectLogs() { { diff --git a/x-pack/plugins/observability_onboarding/public/components/app/home/index.tsx b/x-pack/plugins/observability_onboarding/public/components/app/home/index.tsx index 6dcb343b222cb..13aec2ff31c06 100644 --- a/x-pack/plugins/observability_onboarding/public/components/app/home/index.tsx +++ b/x-pack/plugins/observability_onboarding/public/components/app/home/index.tsx @@ -334,6 +334,7 @@ export function Home() { + {i18n.translate( 'xpack.observability_onboarding.systemLogs.back', { defaultMessage: 'Back' } diff --git a/x-pack/plugins/observability_onboarding/public/components/shared/install_elastic_agent_steps.tsx b/x-pack/plugins/observability_onboarding/public/components/shared/install_elastic_agent_steps.tsx index 282591e0a1487..2d5a42f7c287e 100644 --- a/x-pack/plugins/observability_onboarding/public/components/shared/install_elastic_agent_steps.tsx +++ b/x-pack/plugins/observability_onboarding/public/components/shared/install_elastic_agent_steps.tsx @@ -221,6 +221,7 @@ export function InstallElasticAgentSteps({ values={{ hostRequirementsLink: ( diff --git a/x-pack/plugins/observability_onboarding/public/components/shared/troubleshooting_link.tsx b/x-pack/plugins/observability_onboarding/public/components/shared/troubleshooting_link.tsx index 5b6a1588d643c..71ab94a9bade8 100644 --- a/x-pack/plugins/observability_onboarding/public/components/shared/troubleshooting_link.tsx +++ b/x-pack/plugins/observability_onboarding/public/components/shared/troubleshooting_link.tsx @@ -13,6 +13,7 @@ export function TroubleshootingLink() { return ( @@ -152,6 +153,7 @@ export function CheckSetup({ children }: { children: React.ReactElement }) { }, button: ( { event.preventDefault(); diff --git a/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx b/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx index ae37ebf65c9f0..7a3b661cdac6d 100644 --- a/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx +++ b/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx @@ -160,7 +160,12 @@ export function FlameGraphTooltip({ style={{ background: theme.euiTheme.border.color }} /> - + {i18n.translate('xpack.profiling.flameGraphTooltip.showMoreButton', { defaultMessage: `Show more information`, diff --git a/x-pack/plugins/profiling/public/components/frame_information_window/missing_symbols_callout.tsx b/x-pack/plugins/profiling/public/components/frame_information_window/missing_symbols_callout.tsx index 1f9d40d23a648..ac2c2e7a2407b 100644 --- a/x-pack/plugins/profiling/public/components/frame_information_window/missing_symbols_callout.tsx +++ b/x-pack/plugins/profiling/public/components/frame_information_window/missing_symbols_callout.tsx @@ -41,6 +41,7 @@ export function MissingSymbolsCallout({ frameType }: Props) { values={{ readMore: ( @@ -54,6 +55,7 @@ export function MissingSymbolsCallout({ frameType }: Props) { />

- + {i18n.translate( 'xpack.profiling.frameInformationWindow.missingSymbols.interpreted.reportProblem', { defaultMessage: 'Report a problem' } diff --git a/x-pack/plugins/profiling/public/components/license_prompt/index.tsx b/x-pack/plugins/profiling/public/components/license_prompt/index.tsx index 5ec11800d176e..43af8257efea3 100644 --- a/x-pack/plugins/profiling/public/components/license_prompt/index.tsx +++ b/x-pack/plugins/profiling/public/components/license_prompt/index.tsx @@ -38,7 +38,11 @@ export function LicensePrompt() {

} actions={[ - + {i18n.translate('xpack.profiling.invalidLicense.subscriptionManagementLink', { defaultMessage: 'Upgrade subscription', })} diff --git a/x-pack/plugins/profiling/public/components/normalization_menu/index.tsx b/x-pack/plugins/profiling/public/components/normalization_menu/index.tsx index 3d80d43bbe89c..da17c339814e4 100644 --- a/x-pack/plugins/profiling/public/components/normalization_menu/index.tsx +++ b/x-pack/plugins/profiling/public/components/normalization_menu/index.tsx @@ -95,6 +95,7 @@ export function NormalizationMenu(props: Props) { prepend={NORMALIZE_BY_LABEL} append={ {SCALE_LABEL}} > {SCALE_LABEL}} > { props.onChange(mode, options); setIsPopoverOpen(false); diff --git a/x-pack/plugins/profiling/public/components/primary_and_comparison_search_bar.tsx b/x-pack/plugins/profiling/public/components/primary_and_comparison_search_bar.tsx index 12375925bb606..e5a60a7d95149 100644 --- a/x-pack/plugins/profiling/public/components/primary_and_comparison_search_bar.tsx +++ b/x-pack/plugins/profiling/public/components/primary_and_comparison_search_bar.tsx @@ -91,6 +91,7 @@ export function PrimaryAndComparisonSearchBar() { { diff --git a/x-pack/plugins/profiling/public/components/profiling_app_page_template/index.tsx b/x-pack/plugins/profiling/public/components/profiling_app_page_template/index.tsx index a62d342b3919e..e094038e2f190 100644 --- a/x-pack/plugins/profiling/public/components/profiling_app_page_template/index.tsx +++ b/x-pack/plugins/profiling/public/components/profiling_app_page_template/index.tsx @@ -70,6 +70,7 @@ export function ProfilingAppPageTemplate({ 'data-test-subj': 'profilingPageTemplate', rightSideItems: [ { setPrivilegesWarningDismissed(true); }} diff --git a/x-pack/plugins/profiling/public/components/stack_frame_summary/index.tsx b/x-pack/plugins/profiling/public/components/stack_frame_summary/index.tsx index 5533df8479d4e..d73c382962a59 100644 --- a/x-pack/plugins/profiling/public/components/stack_frame_summary/index.tsx +++ b/x-pack/plugins/profiling/public/components/stack_frame_summary/index.tsx @@ -39,7 +39,7 @@ export function StackFrameSummary({ frame, onFrameClick }: Props) {
{onFrameClick ? ( - + ) : ( diff --git a/x-pack/plugins/profiling/public/components/subchart.tsx b/x-pack/plugins/profiling/public/components/subchart.tsx index ee388b851d0ed..4100425cb05d6 100644 --- a/x-pack/plugins/profiling/public/components/subchart.tsx +++ b/x-pack/plugins/profiling/public/components/subchart.tsx @@ -135,7 +135,7 @@ export function SubChart({ {hasMoreFrames && !!onShowMoreClick && ( - + {i18n.translate('xpack.profiling.stackTracesView.showMoreTracesButton', { defaultMessage: 'Show more', })} @@ -185,13 +185,13 @@ export function SubChart({ {showFrames ? ( - onShowMoreClick?.()}> + onShowMoreClick?.()}> {label} ) : category === OTHER_BUCKET_LABEL ? ( {label} ) : ( - + {label} )} diff --git a/x-pack/plugins/profiling/public/components/topn_functions/index.tsx b/x-pack/plugins/profiling/public/components/topn_functions/index.tsx index ec99236cb135f..4ec9bb8631327 100644 --- a/x-pack/plugins/profiling/public/components/topn_functions/index.tsx +++ b/x-pack/plugins/profiling/public/components/topn_functions/index.tsx @@ -227,6 +227,7 @@ export const TopNFunctionsGrid = forwardRef( } return ( @@ -430,6 +432,7 @@ EOF`} values={{ link: ( @@ -493,6 +496,7 @@ EOF`} versionTo: 6.4, linuxLink: ( @@ -503,6 +507,7 @@ EOF`} ), debianLink: ( @@ -513,6 +518,7 @@ EOF`} ), fedoraLink: ( @@ -523,6 +529,7 @@ EOF`} ), advancedLink: ( diff --git a/x-pack/plugins/profiling/public/views/delete_data_view/index.tsx b/x-pack/plugins/profiling/public/views/delete_data_view/index.tsx index 7e07ba4a1ec86..c4f1399edafe7 100644 --- a/x-pack/plugins/profiling/public/views/delete_data_view/index.tsx +++ b/x-pack/plugins/profiling/public/views/delete_data_view/index.tsx @@ -28,6 +28,7 @@ export function DeleteDataView() { footer={
diff --git a/x-pack/plugins/profiling/public/views/stack_traces_view/index.tsx b/x-pack/plugins/profiling/public/views/stack_traces_view/index.tsx index 0df1f9ae855f9..f024b8a21dcce 100644 --- a/x-pack/plugins/profiling/public/views/stack_traces_view/index.tsx +++ b/x-pack/plugins/profiling/public/views/stack_traces_view/index.tsx @@ -170,6 +170,7 @@ export function StackTracesView() { {(data?.charts.length ?? 0) > limit && ( { profilingRouter.push(routePath, { path, diff --git a/x-pack/plugins/profiling/public/views/storage_explorer/distinct_probabilistic_values_warning.tsx b/x-pack/plugins/profiling/public/views/storage_explorer/distinct_probabilistic_values_warning.tsx index 1427eed54de41..4c963c79a2e7a 100644 --- a/x-pack/plugins/profiling/public/views/storage_explorer/distinct_probabilistic_values_warning.tsx +++ b/x-pack/plugins/profiling/public/views/storage_explorer/distinct_probabilistic_values_warning.tsx @@ -43,6 +43,7 @@ export function DistinctProbabilisticValuesWarning({ = ({ cert }) => { {(copy) => ( { return ( - + ); }; diff --git a/x-pack/plugins/synthetics/public/apps/synthetics/components/common/links/view_errors.tsx b/x-pack/plugins/synthetics/public/apps/synthetics/components/common/links/view_errors.tsx index 0ca0b19a4f58e..e41b2be1a7c11 100644 --- a/x-pack/plugins/synthetics/public/apps/synthetics/components/common/links/view_errors.tsx +++ b/x-pack/plugins/synthetics/public/apps/synthetics/components/common/links/view_errors.tsx @@ -16,6 +16,7 @@ export const ErrorsLink = ({ disabled }: { disabled?: boolean }) => { return ( ( toggleDetails(item)} aria-label={expandedMap[item._id] ? 'Collapse' : 'Expand'} iconType={expandedMap[item._id] ? 'arrowDown' : 'arrowRight'} diff --git a/x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/fields/key_value_field.tsx b/x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/fields/key_value_field.tsx index 7d062fbde7548..58470a204ab51 100644 --- a/x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/fields/key_value_field.tsx +++ b/x-pack/plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/fields/key_value_field.tsx @@ -156,6 +156,7 @@ export const KeyValuePairsField = ({ append={ { const button = ( ( {testTime} - + diff --git a/x-pack/plugins/synthetics/public/apps/synthetics/components/settings/global_params/params_text.tsx b/x-pack/plugins/synthetics/public/apps/synthetics/components/settings/global_params/params_text.tsx index 71024bf9899a7..42bb72f541648 100644 --- a/x-pack/plugins/synthetics/public/apps/synthetics/components/settings/global_params/params_text.tsx +++ b/x-pack/plugins/synthetics/public/apps/synthetics/components/settings/global_params/params_text.tsx @@ -16,6 +16,7 @@ export const ParamsText = ({ text }: { text: string }) => {