From 735a286fac9443f710eb0cd77cdcf4bedb6b05c9 Mon Sep 17 00:00:00 2001
From: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Date: Fri, 5 Nov 2021 16:02:09 -0500
Subject: [PATCH] [Metrics UI] DIsable No Data checkboxes for doc count alerts
 (#117194)

---
 .../components/expression.tsx                 | 37 ++++++++++++++-----
 1 file changed, 28 insertions(+), 9 deletions(-)

diff --git a/x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx b/x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
index 4d57674c94dad..095ce9f78cdff 100644
--- a/x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
+++ b/x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
@@ -261,6 +261,11 @@ export const Expressions: React.FC<Props> = (props) => {
     [alertParams.groupBy]
   );
 
+  const disableNoData = useMemo(
+    () => alertParams.criteria?.every((c) => c.aggType === Aggregators.COUNT),
+    [alertParams.criteria]
+  );
+
   // Test to see if any of the group fields in groupBy are already filtered down to a single
   // group by the filterQuery. If this is the case, then a groupBy is unnecessary, as it would only
   // ever produce one group instance
@@ -358,6 +363,7 @@ export const Expressions: React.FC<Props> = (props) => {
       >
         <EuiPanel color="subdued">
           <EuiCheckbox
+            disabled={disableNoData}
             id="metrics-alert-no-data-toggle"
             label={
               <>
@@ -365,10 +371,13 @@ export const Expressions: React.FC<Props> = (props) => {
                   defaultMessage: "Alert me if there's no data",
                 })}{' '}
                 <EuiToolTip
-                  content={i18n.translate('xpack.infra.metrics.alertFlyout.noDataHelpText', {
-                    defaultMessage:
-                      'Enable this to trigger the action if the metric(s) do not report any data over the expected time period, or if the alert fails to query Elasticsearch',
-                  })}
+                  content={
+                    (disableNoData ? `${docCountNoDataDisabledHelpText} ` : '') +
+                    i18n.translate('xpack.infra.metrics.alertFlyout.noDataHelpText', {
+                      defaultMessage:
+                        'Enable this to trigger the action if the metric(s) do not report any data over the expected time period, or if the alert fails to query Elasticsearch',
+                    })
+                  }
                 >
                   <EuiIcon type="questionInCircle" color="subdued" />
                 </EuiToolTip>
@@ -488,16 +497,19 @@ export const Expressions: React.FC<Props> = (props) => {
               defaultMessage: 'Alert me if a group stops reporting data',
             })}{' '}
             <EuiToolTip
-              content={i18n.translate('xpack.infra.metrics.alertFlyout.groupDisappearHelpText', {
-                defaultMessage:
-                  'Enable this to trigger the action if a previously detected group begins to report no results. This is not recommended for dynamically scaling infrastructures that may rapidly start and stop nodes automatically.',
-              })}
+              content={
+                (disableNoData ? `${docCountNoDataDisabledHelpText} ` : '') +
+                i18n.translate('xpack.infra.metrics.alertFlyout.groupDisappearHelpText', {
+                  defaultMessage:
+                    'Enable this to trigger the action if a previously detected group begins to report no results. This is not recommended for dynamically scaling infrastructures that may rapidly start and stop nodes automatically.',
+                })
+              }
             >
               <EuiIcon type="questionInCircle" color="subdued" />
             </EuiToolTip>
           </>
         }
-        disabled={!hasGroupBy}
+        disabled={disableNoData || !hasGroupBy}
         checked={Boolean(hasGroupBy && alertParams.alertOnGroupDisappear)}
         onChange={(e) => setAlertParams('alertOnGroupDisappear', e.target.checked)}
       />
@@ -506,6 +518,13 @@ export const Expressions: React.FC<Props> = (props) => {
   );
 };
 
+const docCountNoDataDisabledHelpText = i18n.translate(
+  'xpack.infra.metrics.alertFlyout.docCountNoDataDisabledHelpText',
+  {
+    defaultMessage: '[This setting is not applicable to the Document Count aggregator.]',
+  }
+);
+
 // required for dynamic import
 // eslint-disable-next-line import/no-default-export
 export default Expressions;