diff --git a/src/plugins/dashboard/public/dashboard_container/state/diffing/dashboard_diffing_utils.ts b/src/plugins/dashboard/public/dashboard_container/state/diffing/dashboard_diffing_utils.ts index bb0c157017a12..0b6d2db559b5a 100644 --- a/src/plugins/dashboard/public/dashboard_container/state/diffing/dashboard_diffing_utils.ts +++ b/src/plugins/dashboard/public/dashboard_container/state/diffing/dashboard_diffing_utils.ts @@ -56,9 +56,7 @@ export const getPanelLayoutsAreEqual = ( ]; for (const key of keys) { if (key === undefined) continue; - if (!defaultDiffFunction(originalObj[key], newObj[key])) { - differences[key] = newObj[key]; - } + if (!defaultDiffFunction(originalObj[key], newObj[key])) differences[key] = newObj[key]; } return differences; }; diff --git a/src/plugins/links/kibana.jsonc b/src/plugins/links/kibana.jsonc index a139bbf18a201..5f0796d55b43a 100644 --- a/src/plugins/links/kibana.jsonc +++ b/src/plugins/links/kibana.jsonc @@ -2,7 +2,7 @@ "type": "plugin", "id": "@kbn/links-plugin", "owner": "@elastic/kibana-presentation", - "description": "An dashboard panel for creating links to dashboards or external links.", + "description": "A dashboard panel for creating links to dashboards or external links.", "plugin": { "id": "links", "server": true, diff --git a/src/plugins/links/public/embeddable/links_embeddable.tsx b/src/plugins/links/public/embeddable/links_embeddable.tsx index a7c1dcc0632a3..d7f1b3955289a 100644 --- a/src/plugins/links/public/embeddable/links_embeddable.tsx +++ b/src/plugins/links/public/embeddable/links_embeddable.tsx @@ -52,6 +52,10 @@ export class LinksEmbeddable private subscriptions: Subscription = new Subscription(); // state management + /** + * TODO: Keep track of the necessary state without the redux embeddable tools; it's kind of overkill here. + * Related issue: https://github.com/elastic/kibana/issues/167577 + */ public select: LinksReduxEmbeddableTools['select']; public getState: LinksReduxEmbeddableTools['getState']; public dispatch: LinksReduxEmbeddableTools['dispatch']; diff --git a/src/plugins/links/public/embeddable/links_reducers.ts b/src/plugins/links/public/embeddable/links_reducers.ts index ff96b51fddc5f..659b19058adbb 100644 --- a/src/plugins/links/public/embeddable/links_reducers.ts +++ b/src/plugins/links/public/embeddable/links_reducers.ts @@ -14,11 +14,6 @@ import { LinksReduxState } from './types'; import { LinksAttributes } from '../../common/content_management'; export const linksReducers = { - /** - * TODO: Right now, we aren't using any reducers - but, I'm keeping this here as a draft - * just in case we need them later on. As a final cleanup, we could remove this if we never - * end up using reducers - */ setLoading: (state: WritableDraft, action: PayloadAction) => { state.output.loading = action.payload; },