From 66012c227ef3f318b1dd5bff6fc3358b3f65c48a Mon Sep 17 00:00:00 2001
From: Christos Nasikas <christos.nasikas@elastic.co>
Date: Wed, 10 Apr 2024 15:52:09 +0300
Subject: [PATCH] PR feedback

---
 .../__snapshots__/connector_types.test.ts.snap               | 5 +++++
 x-pack/plugins/cases/server/connectors/cases/README.md       | 2 +-
 .../plugins/cases/server/saved_object_types/cases_rules.ts   | 3 ---
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap b/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
index ec969e6696b11..e20376ff26420 100644
--- a/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
+++ b/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
@@ -655,6 +655,11 @@ Object {
             "error": [Function],
             "presence": "optional",
           },
+          "metas": Array [
+            Object {
+              "x-oas-get-additional-properties": [Function],
+            },
+          ],
           "rules": Array [
             Object {
               "args": Object {
diff --git a/x-pack/plugins/cases/server/connectors/cases/README.md b/x-pack/plugins/cases/server/connectors/cases/README.md
index 703ea76627b2e..de04640dcf181 100644
--- a/x-pack/plugins/cases/server/connectors/cases/README.md
+++ b/x-pack/plugins/cases/server/connectors/cases/README.md
@@ -145,7 +145,7 @@ The deduplication ID will be constructed as
 
 where
 
-`<rule_id>`: The ID of the rule. It can be optional to support two different rules attaching alerts to the same case. The rule id must be included if the grouping definition is not defined.
+`<rule_id>`: The ID of the rule. Including it in the deduplication ID ensures all cases created are at least rule-specific.
 `<space_id>`: The space ID of the rule. Space ID is a required field.
 `<owner>`: The owner of the Case. This will be set to the application from which the rule was created from. Owner is a required field.
 `<grouping_definition>`: The grouping field and the grouping value. It can be optional to support attaching all alerts of a rule to the same case.
diff --git a/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts b/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts
index 75bf0183a53a9..98bf10dc9d76b 100644
--- a/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts
+++ b/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts
@@ -14,9 +14,6 @@ export const casesRulesSavedObjectType: SavedObjectsType = {
   name: CASE_RULES_SAVED_OBJECT,
   indexPattern: ALERTING_CASES_SAVED_OBJECT_INDEX,
   hidden: true,
-  /**
-   * TODO: Verify
-   */
   namespaceType: 'agnostic',
   mappings: {
     dynamic: false,