Skip to content

Commit

Permalink
[Discover] Add a deprecation badge to legacy stats setting (#155688)
Browse files Browse the repository at this point in the history
## Summary

We are adding a deprecation badge in 8.8 and removing this setting in
8.9 #155503

<img width="946" alt="Screenshot 2023-04-25 at 10 28 21"
src="https://user-images.githubusercontent.com/1415710/234220005-401bb636-df3f-44a1-ae83-4a30df99ec87.png">
  • Loading branch information
jughosta authored Apr 25, 2023
1 parent b6a91f3 commit 61b56ce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/kbn-doc-links/src/get_doc_links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ export const getDocLinks = ({ kibanaBranch }: GetDocLinkOptions): DocLinks => {
dashboardSettings: `${KIBANA_DOCS}advanced-options.html#kibana-dashboard-settings`,
indexManagement: `${ELASTICSEARCH_DOCS}index-mgmt.html`,
kibanaSearchSettings: `${KIBANA_DOCS}advanced-options.html#kibana-search-settings`,
discoverSettings: `${KIBANA_DOCS}advanced-options.html#kibana-discover-settings`,
visualizationSettings: `${KIBANA_DOCS}advanced-options.html#kibana-visualization-settings`,
timelionSettings: `${KIBANA_DOCS}advanced-options.html#kibana-timelion-settings`,
savedObjectsApiList: `${KIBANA_DOCS}saved-objects-api.html#saved-objects-api`,
Expand Down
6 changes: 6 additions & 0 deletions src/plugins/discover/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ export const getUiSettings: (docLinks: DocLinksServiceSetup) => Record<string, U
}),
category: ['discover'],
schema: schema.boolean(),
deprecation: {
message: i18n.translate('discover.advancedSettings.showLegacyFieldStatsTextDeprecation', {
defaultMessage: 'This setting is deprecated and will not be supported in a future version.',
}),
docLinksKey: 'discoverSettings',
},
},
[DOC_HIDE_TIME_COLUMN_SETTING]: {
name: i18n.translate('discover.advancedSettings.docTableHideTimeColumnTitle', {
Expand Down

0 comments on commit 61b56ce

Please sign in to comment.