From 60fb1832be623b5475b8980d674b7a4b4c8c0857 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Wed, 24 Apr 2024 09:35:20 -0400
Subject: [PATCH] [8.14] [Embeddable rebuild] ML anomaly swim lane embeddable:
 ensure dashboard reset works correctly (#181346) (#181490)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Embeddable rebuild] ML anomaly swim lane embeddable: ensure
dashboard reset works correctly
(#181346)](https://github.com/elastic/kibana/pull/181346)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2024-04-23T19:28:03Z","message":"[Embeddable
rebuild] ML anomaly swim lane embeddable: ensure dashboard reset works
correctly (#181346)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181210\r\nThe reset
functionality was not reverting the embeddable values. This
PR\r\nensures the embeddable values are reset on dashboard
reset.\r\n\r\nComparators require the `next` functionality to be wrapped
in a function\r\nin order to maintain `this` being defined.\r\nThe
problem is that BehaviourSubjects are class instances, and if
you\r\npass in the next method like `[someSubject$, someSubject$.next]`
you\r\nlose the this context.\r\n\r\nNOTE: This needs the `8.14.1` label
when it's available\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d4047fe716ad946310d3327a95cac58dbb06c152","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix",":ml","Team:Presentation","loe:small","impact:low","Feature:Embeddables","project:embeddableRebuild","v8.14.0","v8.15.0"],"title":"[Embeddable
rebuild] ML anomaly swim lane embeddable: ensure dashboard reset works
correctly","number":181346,"url":"https://github.com/elastic/kibana/pull/181346","mergeCommit":{"message":"[Embeddable
rebuild] ML anomaly swim lane embeddable: ensure dashboard reset works
correctly (#181346)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181210\r\nThe reset
functionality was not reverting the embeddable values. This
PR\r\nensures the embeddable values are reset on dashboard
reset.\r\n\r\nComparators require the `next` functionality to be wrapped
in a function\r\nin order to maintain `this` being defined.\r\nThe
problem is that BehaviourSubjects are class instances, and if
you\r\npass in the next method like `[someSubject$, someSubject$.next]`
you\r\nlose the this context.\r\n\r\nNOTE: This needs the `8.14.1` label
when it's available\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d4047fe716ad946310d3327a95cac58dbb06c152"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181346","number":181346,"mergeCommit":{"message":"[Embeddable
rebuild] ML anomaly swim lane embeddable: ensure dashboard reset works
correctly (#181346)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/181210\r\nThe reset
functionality was not reverting the embeddable values. This
PR\r\nensures the embeddable values are reset on dashboard
reset.\r\n\r\nComparators require the `next` functionality to be wrapped
in a function\r\nin order to maintain `this` being defined.\r\nThe
problem is that BehaviourSubjects are class instances, and if
you\r\npass in the next method like `[someSubject$, someSubject$.next]`
you\r\nlose the this context.\r\n\r\nNOTE: This needs the `8.14.1` label
when it's available\r\n\r\n### Checklist\r\n\r\nDelete any items that
are not applicable to this PR.\r\n\r\n- [ ] Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is
usable by keyboard only (learn more\r\nabout [keyboard
accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI
touched in this PR does not create any new axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d4047fe716ad946310d3327a95cac58dbb06c152"}}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
---
 .../anomaly_swimlane/initialize_swim_lane_controls.ts     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/initialize_swim_lane_controls.ts b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/initialize_swim_lane_controls.ts
index 218b937b25277..1301b29f80661 100644
--- a/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/initialize_swim_lane_controls.ts
+++ b/x-pack/plugins/ml/public/embeddables/anomaly_swimlane/initialize_swim_lane_controls.ts
@@ -60,10 +60,10 @@ export const initializeSwimLaneControls = (
   };
 
   const swimLaneComparators: StateComparators<AnomalySwimLaneControlsState> = {
-    jobIds: [jobIds, jobIds.next, fastIsEqual],
-    swimlaneType: [swimlaneType, swimlaneType.next],
-    viewBy: [viewBy, viewBy.next],
-    perPage: [perPage, perPage.next],
+    jobIds: [jobIds, (arg) => jobIds.next(arg), fastIsEqual],
+    swimlaneType: [swimlaneType, (arg) => swimlaneType.next(arg)],
+    viewBy: [viewBy, (arg) => viewBy.next(arg)],
+    perPage: [perPage, (arg) => perPage.next(arg)],
   };
 
   return {