From 5e002d54fc05d27e4728348f0806c2af90b18c25 Mon Sep 17 00:00:00 2001
From: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
Date: Mon, 1 Jul 2024 11:06:36 +0100
Subject: [PATCH] [Security Solution][Detection Engine] fixes flaky Detections
 > Callouts cypress (missing_privileges_callout.cy) tests (#186482)

## Summary

- addresses https://github.com/elastic/kibana/issues/178176
- I ran test 400 times on flaky test runner, no failures. So this PR is
to unskip test. If it happen to fail again, we would need to look
further
- also refactored tests a bit, to remove duplicate one command tests
---
 .../callouts/missing_privileges_callout.cy.ts | 149 ++++++++----------
 1 file changed, 67 insertions(+), 82 deletions(-)

diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/callouts/missing_privileges_callout.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/callouts/missing_privileges_callout.cy.ts
index bcb29a456bdd2..69e6bb8b35253 100644
--- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/callouts/missing_privileges_callout.cy.ts
+++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/detection_alerts/callouts/missing_privileges_callout.cy.ts
@@ -44,106 +44,91 @@ const waitForPageTitleToBeShown = () => {
   cy.get(PAGE_TITLE).should('be.visible');
 };
 
-// FLAKY: https://github.com/elastic/kibana/issues/178176
-describe.skip(
-  'Detections > Callouts',
-  { tags: ['@ess', '@serverless', '@skipInServerless'] },
-  () => {
-    before(() => {
-      // First, we have to open the app on behalf of a privileged user in order to initialize it.
-      // Otherwise the app will be disabled and show a "welcome"-like page.
-      login();
-      visit(ALERTS_URL);
-      waitForPageTitleToBeShown();
-    });
-
-    context('indicating read-only access to resources', () => {
-      context('On Detections home page', () => {
-        beforeEach(() => {
-          loadPageAsReadOnlyUser(ALERTS_URL);
-        });
-
-        it('We show one primary callout', () => {
-          waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
-        });
-
-        context('When a user clicks Dismiss on the callout', () => {
-          it('We hide it and persist the dismissal', () => {
-            waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
-            dismissCallOut(MISSING_PRIVILEGES_CALLOUT);
-            reloadPage();
-            getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
-          });
-        });
+describe('Detections > Callouts', { tags: ['@ess', '@serverless', '@skipInServerless'] }, () => {
+  before(() => {
+    // First, we have to open the app on behalf of a privileged user in order to initialize it.
+    // Otherwise the app will be disabled and show a "welcome"-like page.
+    login();
+    visit(ALERTS_URL);
+    waitForPageTitleToBeShown();
+  });
+
+  context('indicating read-only access to resources', () => {
+    context('On Detections home page', () => {
+      beforeEach(() => {
+        loadPageAsReadOnlyUser(ALERTS_URL);
       });
 
-      // FYI: Rules Management check moved to ../detection_rules/all_rules_read_only.spec.ts
+      it('dismisses callout and persists its state', () => {
+        waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
 
-      context('On Rule Details page', () => {
-        beforeEach(() => {
-          createRule(getNewRule()).then((rule) =>
-            loadPageAsReadOnlyUser(ruleDetailsUrl(rule.body.id))
-          );
-        });
+        dismissCallOut(MISSING_PRIVILEGES_CALLOUT);
+        reloadPage();
 
-        afterEach(() => {
-          deleteCustomRule();
-        });
+        getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
+      });
+    });
+
+    // FYI: Rules Management check moved to ../detection_rules/all_rules_read_only.spec.ts
+
+    context('On Rule Details page', () => {
+      beforeEach(() => {
+        createRule(getNewRule()).then((rule) =>
+          loadPageAsReadOnlyUser(ruleDetailsUrl(rule.body.id))
+        );
+      });
 
-        it('We show one primary callout', () => {
-          waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
-        });
+      afterEach(() => {
+        deleteCustomRule();
+      });
 
-        context('When a user clicks Dismiss on the callouts', () => {
-          it('We hide them and persist the dismissal', () => {
-            waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
+      it('dismisses callout and persists its state', () => {
+        waitForCallOutToBeShown(MISSING_PRIVILEGES_CALLOUT, 'primary');
 
-            dismissCallOut(MISSING_PRIVILEGES_CALLOUT);
-            reloadPage();
+        dismissCallOut(MISSING_PRIVILEGES_CALLOUT);
+        reloadPage();
 
-            getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
-          });
-        });
+        getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
       });
     });
+  });
 
-    context('indicating read-write access to resources', () => {
-      context('On Detections home page', () => {
-        beforeEach(() => {
-          loadPageAsPlatformEngineer(ALERTS_URL);
-        });
+  context('indicating read-write access to resources', () => {
+    context('On Detections home page', () => {
+      beforeEach(() => {
+        loadPageAsPlatformEngineer(ALERTS_URL);
+      });
 
-        it('We show no callout', () => {
-          getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
-        });
+      it('We show no callout', () => {
+        getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
       });
+    });
 
-      context('On Rules Management page', () => {
-        beforeEach(() => {
-          login(ROLES.platform_engineer);
-          loadPageAsPlatformEngineer(RULES_MANAGEMENT_URL);
-        });
+    context('On Rules Management page', () => {
+      beforeEach(() => {
+        login(ROLES.platform_engineer);
+        loadPageAsPlatformEngineer(RULES_MANAGEMENT_URL);
+      });
 
-        it('We show no callout', () => {
-          getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
-        });
+      it('We show no callout', () => {
+        getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
       });
+    });
 
-      context('On Rule Details page', () => {
-        beforeEach(() => {
-          createRule(getNewRule()).then((rule) =>
-            loadPageAsPlatformEngineer(ruleDetailsUrl(rule.body.id))
-          );
-        });
+    context('On Rule Details page', () => {
+      beforeEach(() => {
+        createRule(getNewRule()).then((rule) =>
+          loadPageAsPlatformEngineer(ruleDetailsUrl(rule.body.id))
+        );
+      });
 
-        afterEach(() => {
-          deleteCustomRule();
-        });
+      afterEach(() => {
+        deleteCustomRule();
+      });
 
-        it('We show no callouts', () => {
-          getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
-        });
+      it('We show no callouts', () => {
+        getCallOut(MISSING_PRIVILEGES_CALLOUT).should('not.exist');
       });
     });
-  }
-);
+  });
+});