diff --git a/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/deprecations_list.test.ts b/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/deprecations_list.test.ts index 7e30ab1c169ea..3b8a756b8e64c 100644 --- a/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/deprecations_list.test.ts +++ b/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/deprecations_list.test.ts @@ -62,7 +62,7 @@ describe('ES deprecations table', () => { const mlDeprecation = esDeprecationsMockResponse.deprecations[0]; const reindexDeprecation = esDeprecationsMockResponse.deprecations[3]; - // Since upgradeStatusMockResponse includes ML and reindex actions (which require fetching status), there will be 3 requests made + // Since upgradeStatusMockResponse includes ML and reindex actions (which require fetching status), there will be 4 requests made expect(server.requests.length).toBe(totalRequests + 4); expect(server.requests[server.requests.length - 4].url).toBe( `${API_BASE_PATH}/es_deprecations` @@ -75,6 +75,10 @@ describe('ES deprecations table', () => { expect(server.requests[server.requests.length - 2].url).toBe( `${API_BASE_PATH}/reindex/${reindexDeprecation.index}` ); + + expect(server.requests[server.requests.length - 1].url).toBe( + `${API_BASE_PATH}/ml_upgrade_mode` + ); }); it('shows critical and warning deprecations count', () => { diff --git a/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/ml_snapshots_deprecation_flyout.test.ts b/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/ml_snapshots_deprecation_flyout.test.ts index 85515d2d00d62..6bcb3fa95985c 100644 --- a/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/ml_snapshots_deprecation_flyout.test.ts +++ b/x-pack/plugins/upgrade_assistant/__jest__/client_integration/es_deprecations/ml_snapshots_deprecation_flyout.test.ts @@ -133,7 +133,7 @@ describe('Machine learning deprecation flyout', () => { expect(find('mlSnapshotDetails.upgradeSnapshotButton').text()).toEqual('Retry upgrade'); }); - it('Doesnt allow to take actions if ml_upgrade_mode is enabled', async () => { + it('Disables actions if ml_upgrade_mode is enabled', async () => { httpRequestsMockHelpers.setLoadMlUpgradeModeResponse({ mlUpgradeModeEnabled: true }); await act(async () => { diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/ml_snapshots/flyout.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/ml_snapshots/flyout.tsx index 9b3adc9b3ef83..06542744c2ac8 100644 --- a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/ml_snapshots/flyout.tsx +++ b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/ml_snapshots/flyout.tsx @@ -114,7 +114,7 @@ const i18nTexts = { ), diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx index 981e57a88c52f..3d9b554913c5b 100644 --- a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx +++ b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx @@ -160,7 +160,7 @@ export const EsDeprecationsTable: React.FunctionComponent = ({ services: { api }, } = useAppContext(); - const { data } = api.useLoadMLUpgradeMode(); + const { data } = api.useLoadMlUpgradeMode(); const mlUpgradeModeEnabled = !!data?.mlUpgradeModeEnabled; const [sortConfig, setSortConfig] = useState({ diff --git a/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts b/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts index b3926c6db1c9c..da4f87f497467 100644 --- a/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts +++ b/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts @@ -181,7 +181,7 @@ export class ApiService { }); } - public useLoadMLUpgradeMode() { + public useLoadMlUpgradeMode() { return this.useRequest<{ mlUpgradeModeEnabled: boolean; }>({ diff --git a/x-pack/plugins/upgrade_assistant/server/routes/ml_snapshots.test.ts b/x-pack/plugins/upgrade_assistant/server/routes/ml_snapshots.test.ts index bb4323a9bddb4..995e3a46cef0e 100644 --- a/x-pack/plugins/upgrade_assistant/server/routes/ml_snapshots.test.ts +++ b/x-pack/plugins/upgrade_assistant/server/routes/ml_snapshots.test.ts @@ -176,7 +176,7 @@ describe('ML snapshots APIs', () => { }); describe('GET /api/upgrade_assistant/ml_upgrade_mode', () => { - it('Knows how to retrieve ml upgrade mode', async () => { + it('Retrieves ml upgrade mode', async () => { ( routeHandlerContextMock.core.elasticsearch.client.asCurrentUser.ml.info as jest.Mock ).mockResolvedValue({