From 58474aeae862e3cca2758b6f37f3a1ec73b94747 Mon Sep 17 00:00:00 2001 From: Hannah Mudge Date: Fri, 20 Sep 2024 10:24:09 -0600 Subject: [PATCH] Review feedback --- .../control_group_renderer.test.tsx | 0 .../control_group_renderer.tsx | 0 .../control_group_renderer_lazy.tsx | 0 .../{external_api => control_group_renderer}/index.ts | 0 .../{external_api => control_group_renderer}/types.ts | 0 src/plugins/controls/public/index.ts | 2 +- .../create/controls/dashboard_control_group_integration.test.ts | 2 -- 7 files changed, 1 insertion(+), 3 deletions(-) rename src/plugins/controls/public/control_group/{external_api => control_group_renderer}/control_group_renderer.test.tsx (100%) rename src/plugins/controls/public/control_group/{external_api => control_group_renderer}/control_group_renderer.tsx (100%) rename src/plugins/controls/public/control_group/{external_api => control_group_renderer}/control_group_renderer_lazy.tsx (100%) rename src/plugins/controls/public/control_group/{external_api => control_group_renderer}/index.ts (100%) rename src/plugins/controls/public/control_group/{external_api => control_group_renderer}/types.ts (100%) diff --git a/src/plugins/controls/public/control_group/external_api/control_group_renderer.test.tsx b/src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer.test.tsx similarity index 100% rename from src/plugins/controls/public/control_group/external_api/control_group_renderer.test.tsx rename to src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer.test.tsx diff --git a/src/plugins/controls/public/control_group/external_api/control_group_renderer.tsx b/src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer.tsx similarity index 100% rename from src/plugins/controls/public/control_group/external_api/control_group_renderer.tsx rename to src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer.tsx diff --git a/src/plugins/controls/public/control_group/external_api/control_group_renderer_lazy.tsx b/src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer_lazy.tsx similarity index 100% rename from src/plugins/controls/public/control_group/external_api/control_group_renderer_lazy.tsx rename to src/plugins/controls/public/control_group/control_group_renderer/control_group_renderer_lazy.tsx diff --git a/src/plugins/controls/public/control_group/external_api/index.ts b/src/plugins/controls/public/control_group/control_group_renderer/index.ts similarity index 100% rename from src/plugins/controls/public/control_group/external_api/index.ts rename to src/plugins/controls/public/control_group/control_group_renderer/index.ts diff --git a/src/plugins/controls/public/control_group/external_api/types.ts b/src/plugins/controls/public/control_group/control_group_renderer/types.ts similarity index 100% rename from src/plugins/controls/public/control_group/external_api/types.ts rename to src/plugins/controls/public/control_group/control_group_renderer/types.ts diff --git a/src/plugins/controls/public/index.ts b/src/plugins/controls/public/index.ts index 2c12145a8f5ab..eaa800387759b 100644 --- a/src/plugins/controls/public/index.ts +++ b/src/plugins/controls/public/index.ts @@ -25,7 +25,7 @@ export { type ControlGroupCreationOptions, type ControlGroupRendererApi, type ControlGroupRendererProps, -} from './control_group/external_api'; +} from './control_group/control_group_renderer'; export { CONTROL_GROUP_TYPE, diff --git a/src/plugins/dashboard/public/dashboard_container/embeddable/create/controls/dashboard_control_group_integration.test.ts b/src/plugins/dashboard/public/dashboard_container/embeddable/create/controls/dashboard_control_group_integration.test.ts index 8bcb0f473c5f1..3a18acd242e4f 100644 --- a/src/plugins/dashboard/public/dashboard_container/embeddable/create/controls/dashboard_control_group_integration.test.ts +++ b/src/plugins/dashboard/public/dashboard_container/embeddable/create/controls/dashboard_control_group_integration.test.ts @@ -11,8 +11,6 @@ import { Filter } from '@kbn/es-query'; import { combineDashboardFiltersWithControlGroupFilters } from './dashboard_control_group_integration'; import { BehaviorSubject } from 'rxjs'; -jest.mock('@kbn/controls-plugin/public/control_group/get_control_group_factory'); - const testFilter1: Filter = { meta: { key: 'testfield',