From 52f0bf0a6ab8df5d393630571b7c95535723f770 Mon Sep 17 00:00:00 2001
From: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
Date: Tue, 29 Mar 2022 09:16:00 +0100
Subject: [PATCH] Set metadata tab as default and display Stack Trace tab only
 if stackframes exist (#128598)

---
 .../waterfall/span_flyout/index.tsx           | 41 +++++++++++--------
 1 file changed, 23 insertions(+), 18 deletions(-)

diff --git a/x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx b/x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx
index 477098aa81d04..5d3c1d733e040 100644
--- a/x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx
+++ b/x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx
@@ -21,6 +21,7 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import React, { Fragment } from 'react';
+import { isEmpty } from 'lodash';
 import { CompositeSpanDurationSummaryItem } from '../../../../../../shared/summary/composite_span_duration_summary_item';
 import { euiStyled } from '../../../../../../../../../../../src/plugins/kibana_react/common';
 import { Span } from '../../../../../../../../typings/es_schemas/ui/span';
@@ -216,24 +217,6 @@ export function SpanFlyout({
           <SpanDatabase spanDb={spanDb} />
           <EuiTabbedContent
             tabs={[
-              {
-                id: 'stack-trace',
-                name: i18n.translate(
-                  'xpack.apm.transactionDetails.spanFlyout.stackTraceTabLabel',
-                  {
-                    defaultMessage: 'Stack Trace',
-                  }
-                ),
-                content: (
-                  <Fragment>
-                    <EuiSpacer size="l" />
-                    <Stacktrace
-                      stackframes={stackframes}
-                      codeLanguage={codeLanguage}
-                    />
-                  </Fragment>
-                ),
-              },
               {
                 id: 'metadata',
                 name: i18n.translate(
@@ -249,6 +232,28 @@ export function SpanFlyout({
                   </Fragment>
                 ),
               },
+              ...(!isEmpty(stackframes)
+                ? [
+                    {
+                      id: 'stack-trace',
+                      name: i18n.translate(
+                        'xpack.apm.transactionDetails.spanFlyout.stackTraceTabLabel',
+                        {
+                          defaultMessage: 'Stack Trace',
+                        }
+                      ),
+                      content: (
+                        <Fragment>
+                          <EuiSpacer size="l" />
+                          <Stacktrace
+                            stackframes={stackframes}
+                            codeLanguage={codeLanguage}
+                          />
+                        </Fragment>
+                      ),
+                    },
+                  ]
+                : []),
             ]}
           />
         </EuiFlyoutBody>