From 452e34fe6b837f06a210b5015c859909f8fd73b7 Mon Sep 17 00:00:00 2001 From: Timothy Sullivan Date: Wed, 9 Aug 2023 15:48:21 -0700 Subject: [PATCH] note about semantic html; --- .../core-chrome-browser-internal/src/ui/project/header.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx index fc914c17455be..de7c42e6b41bf 100644 --- a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx +++ b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx @@ -278,6 +278,11 @@ export const ProjectHeader = ({ + {/* NOTE: It would be better to house this content in a location closer to the main page content, + rather than in the header area. Using the header to mount this content offers the convenience of + consistency, but could create accessbility issues if screenreaders announce this content as if it + were part of the header. Semantically, AppMenuBar is not part of the header. + See: https://github.com/elastic/kibana/pull/162002#discussion_r1287468143 */} {headerActionMenuMounter.mount && (