From 3c12119cb6ec7a8f56590401d0c6538c1fec1d95 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Wed, 20 Oct 2021 11:30:46 -0400
Subject: [PATCH] [buildkite] Add uptime playwright tests to PR pipeline
 (#115590) (#115727)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
---
 .buildkite/pipelines/pull_request/uptime.yml   | 11 +++++++++++
 .../scripts/pipelines/pull_request/pipeline.js |  4 ++++
 .buildkite/scripts/steps/functional/common.sh  |  2 ++
 .buildkite/scripts/steps/functional/uptime.sh  | 17 +++++++++++++++++
 x-pack/plugins/uptime/e2e/config.ts            |  2 +-
 x-pack/plugins/uptime/e2e/playwright_start.ts  | 15 +++++----------
 x-pack/plugins/uptime/scripts/e2e.js           | 18 +++++++++++++-----
 7 files changed, 53 insertions(+), 16 deletions(-)
 create mode 100644 .buildkite/pipelines/pull_request/uptime.yml
 create mode 100755 .buildkite/scripts/steps/functional/uptime.sh

diff --git a/.buildkite/pipelines/pull_request/uptime.yml b/.buildkite/pipelines/pull_request/uptime.yml
new file mode 100644
index 0000000000000..60fdea1add04c
--- /dev/null
+++ b/.buildkite/pipelines/pull_request/uptime.yml
@@ -0,0 +1,11 @@
+steps:
+  - command: .buildkite/scripts/steps/functional/uptime.sh
+    label: 'Uptime @elastic/synthetics Tests'
+    agents:
+      queue: ci-group-6
+    depends_on: build
+    timeout_in_minutes: 120
+    retry:
+      automatic:
+        - exit_status: '*'
+          limit: 1
diff --git a/.buildkite/scripts/pipelines/pull_request/pipeline.js b/.buildkite/scripts/pipelines/pull_request/pipeline.js
index 028c90020a0b8..7b5c944d31c1c 100644
--- a/.buildkite/scripts/pipelines/pull_request/pipeline.js
+++ b/.buildkite/scripts/pipelines/pull_request/pipeline.js
@@ -73,6 +73,10 @@ const uploadPipeline = (pipelineContent) => {
     //   pipeline.push(getPipeline('.buildkite/pipelines/pull_request/apm_cypress.yml'));
     // }
 
+    if (await doAnyChangesMatch([/^x-pack\/plugins\/uptime/])) {
+      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/uptime.yml'));
+    }
+
     pipeline.push(getPipeline('.buildkite/pipelines/pull_request/post_build.yml'));
 
     uploadPipeline(pipeline.join('\n'));
diff --git a/.buildkite/scripts/steps/functional/common.sh b/.buildkite/scripts/steps/functional/common.sh
index b60ed835799e5..bedd22c53c7ec 100755
--- a/.buildkite/scripts/steps/functional/common.sh
+++ b/.buildkite/scripts/steps/functional/common.sh
@@ -2,6 +2,8 @@
 
 set -euo pipefail
 
+# Note, changes here might also need to be made in other scripts, e.g. uptime.sh
+
 source .buildkite/scripts/common/util.sh
 
 .buildkite/scripts/bootstrap.sh
diff --git a/.buildkite/scripts/steps/functional/uptime.sh b/.buildkite/scripts/steps/functional/uptime.sh
new file mode 100755
index 0000000000000..5a59f4dfa48bd
--- /dev/null
+++ b/.buildkite/scripts/steps/functional/uptime.sh
@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+source .buildkite/scripts/common/util.sh
+
+.buildkite/scripts/bootstrap.sh
+.buildkite/scripts/download_build_artifacts.sh
+
+export JOB=kibana-uptime-playwright
+
+echo "--- Uptime @elastic/synthetics Tests"
+
+cd "$XPACK_DIR"
+
+checks-reporter-with-killswitch "Uptime @elastic/synthetics Tests" \
+  node plugins/uptime/scripts/e2e.js --kibana-install-dir "$KIBANA_BUILD_LOCATION"
diff --git a/x-pack/plugins/uptime/e2e/config.ts b/x-pack/plugins/uptime/e2e/config.ts
index 70cc57247d490..c5d573afccd96 100644
--- a/x-pack/plugins/uptime/e2e/config.ts
+++ b/x-pack/plugins/uptime/e2e/config.ts
@@ -39,7 +39,7 @@ async function config({ readConfigFile }: FtrConfigProviderContext) {
         '--csp.warnLegacyBrowsers=false',
         // define custom kibana server args here
         `--elasticsearch.ssl.certificateAuthorities=${CA_CERT_PATH}`,
-        `--elasticsearch.ignoreVersionMismatch=true`,
+        `--elasticsearch.ignoreVersionMismatch=${process.env.CI ? 'false' : 'true'}`,
         `--uiSettings.overrides.theme:darkMode=true`,
         `--elasticsearch.username=kibana_system`,
         `--elasticsearch.password=changeme`,
diff --git a/x-pack/plugins/uptime/e2e/playwright_start.ts b/x-pack/plugins/uptime/e2e/playwright_start.ts
index aedb255b058be..5949339c1ba25 100644
--- a/x-pack/plugins/uptime/e2e/playwright_start.ts
+++ b/x-pack/plugins/uptime/e2e/playwright_start.ts
@@ -15,15 +15,10 @@ import './journeys';
 
 export function playwrightRunTests() {
   return async ({ getService }: any) => {
-    try {
-      const result = await playwrightStart(getService);
-
-      if (result && result.uptime.status !== 'succeeded') {
-        process.exit(1);
-      }
-    } catch (error) {
-      console.error('errors: ', error);
-      process.exit(1);
+    const result = await playwrightStart(getService);
+
+    if (result && result.uptime.status !== 'succeeded') {
+      throw new Error('Tests failed');
     }
   };
 }
@@ -42,7 +37,7 @@ async function playwrightStart(getService: any) {
 
   const res = await playwrightRun({
     params: { kibanaUrl },
-    playwrightOptions: { chromiumSandbox: false, timeout: 60 * 1000 },
+    playwrightOptions: { headless: true, chromiumSandbox: false, timeout: 60 * 1000 },
   });
 
   console.log('Removing esArchiver...');
diff --git a/x-pack/plugins/uptime/scripts/e2e.js b/x-pack/plugins/uptime/scripts/e2e.js
index e2a8dfaf25c93..e7c0cb612646d 100644
--- a/x-pack/plugins/uptime/scripts/e2e.js
+++ b/x-pack/plugins/uptime/scripts/e2e.js
@@ -28,9 +28,14 @@ const { argv } = yargs(process.argv.slice(2))
     type: 'boolean',
     description: 'Opens the Playwright Test Runner',
   })
+  .option('kibana-install-dir', {
+    default: '',
+    type: 'string',
+    description: 'Path to the Kibana install directory',
+  })
   .help();
 
-const { server, runner, open } = argv;
+const { server, runner, open, kibanaInstallDir } = argv;
 
 const e2eDir = path.join(__dirname, '../e2e');
 
@@ -44,9 +49,12 @@ if (server) {
 const config = './playwright_run.ts';
 
 function executeRunner() {
-  childProcess.execSync(`node ../../../scripts/${ftrScript} --config ${config}`, {
-    cwd: e2eDir,
-    stdio: 'inherit',
-  });
+  childProcess.execSync(
+    `node ../../../scripts/${ftrScript} --config ${config} --kibana-install-dir '${kibanaInstallDir}'`,
+    {
+      cwd: e2eDir,
+      stdio: 'inherit',
+    }
+  );
 }
 executeRunner();