[ML] Add check to isPickFieldsStepValid and remove lodash/uniq

elastic · Aug 19, 2020 · 38edcdd · 38edcdd
1 parent cd59230
commit 38edcdd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/x-pack/plugins/ml/common/util/job_utils.ts b/x-pack/plugins/ml/common/util/job_utils.ts
@@ -8,7 +8,6 @@ import isEmpty from 'lodash/isEmpty';
 import isEqual from 'lodash/isEqual';
 import each from 'lodash/each';
 import pick from 'lodash/pick';
-import uniq from 'lodash/uniq';
 
 import semver from 'semver';
 import moment, { Duration } from 'moment';
@@ -430,11 +429,13 @@ export function basicJobValidation(
               d.over_field_name === MLCATEGORY ||
               d.partition_field_name === MLCATEGORY
           );
-          const uniqPartitions = uniq(
-            categorizationDetectors
-              .map((d) => d.partition_field_name)
-              .filter((name) => name !== undefined)
-          );
+          const uniqPartitions = [
+            ...new Set(
+              categorizationDetectors
+                .map((d) => d.partition_field_name)
+                .filter((name) => name !== undefined)
+            ),
+          ];
           if (uniqPartitions.length > 1) {
             valid = false;
             messages.push({

diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/common/job_validator/job_validator.ts b/x-pack/plugins/ml/public/application/jobs/new_job/common/job_validator/job_validator.ts
@@ -295,6 +295,8 @@ export class JobValidator {
         (this._jobCreator.type === JOB_TYPE.ADVANCED && this.modelMemoryLimit.valid)) &&
       this.bucketSpan.valid &&
       this.duplicateDetectors.valid &&
+      this.categorizerMissingPerPartition.valid &&
+      this.categorizerVaryingPerPartitionField.valid &&
       !this.validating &&
       (this._jobCreator.type !== JOB_TYPE.CATEGORIZATION ||
         (this._jobCreator.type === JOB_TYPE.CATEGORIZATION && this.categorizationField))