[ML] Fix Latest timestamp column in the Anomaly Detection jobs table (#…

…137280) * fix position of the AD and SMV buttons * show actions column header * remove unused class
elastic · Jul 27, 2022 · 34b5a2f · 34b5a2f
1 parent 52d52b1
commit 34b5a2f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 117 deletions.
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/_index.scss b/x-pack/plugins/ml/public/application/jobs/jobs_list/_index.scss
@@ -4,6 +4,5 @@
 @import 'components/job_details/index'; // SASSTODO: Dangerous EUI overwrites
 @import 'components/job_filter_bar/index'; // SASSTODO: Dangerous EUI overwrites
 @import 'components/job_group/index';
-@import 'components/jobs_list/index'; // SASSTODO: Dangerous EUI overwrites
 @import 'components/jobs_list_view/index';
 @import 'components/multi_job_actions/index'; // SASSTODO: Dangerous EUI overwrites
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js
@@ -75,7 +75,6 @@ export function ResultLinks({ jobs }) {
               href={timeSeriesExplorerLink}
               iconType="visLine"
               aria-label={openJobsInSingleMetricViewerText}
-              className="results-button"
               isDisabled={singleMetricEnabled === false || jobActionsDisabled === true}
               data-test-subj="mlOpenJobsInSingleMetricViewerButton"
             />
@@ -88,7 +87,6 @@ export function ResultLinks({ jobs }) {
             href={anomalyExplorerLink}
             iconType="visTable"
             aria-label={openJobsInAnomalyExplorerText}
-            className="results-button"
             isDisabled={jobActionsDisabled === true}
             data-test-subj="mlOpenJobsInAnomalyExplorerButton"
           />

diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/_index.scss b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/_index.scss
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/_jobs_list.scss b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/_jobs_list.scss
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js
@@ -137,6 +137,7 @@ export class JobsList extends Component {
             </p>
           </EuiScreenReaderOnly>
         ),
+        'data-test-subj': 'mlJobListColumnExpand',
         render: (item) => (
           <EuiButtonIcon
             onClick={() => this.toggleRow(item)}
@@ -195,6 +196,7 @@ export class JobsList extends Component {
       },
       {
         field: 'auditMessage',
+        'data-test-subj': 'mlJobListColumnIcons',
         name: (
           <EuiScreenReaderOnly>
             <p>
@@ -209,6 +211,7 @@ export class JobsList extends Component {
       },
       {
         field: 'alertingRules',
+        'data-test-subj': 'mlJobListColumnAlertingRuleIndicator',
         name: (
           <EuiScreenReaderOnly>
             <p>
@@ -292,13 +295,6 @@ export class JobsList extends Component {
         truncateText: false,
         width: '8%',
       },
-      {
-        name: i18n.translate('xpack.ml.jobsList.actionsLabel', {
-          defaultMessage: 'Actions',
-        }),
-        render: (item) => <ResultLinks jobs={[item]} />,
-        width: '8%',
-      },
       {
         name: i18n.translate('xpack.ml.jobsList.latestTimestampLabel', {
           defaultMessage: 'Latest timestamp',
@@ -328,6 +324,13 @@ export class JobsList extends Component {
             </p>
           </EuiScreenReaderOnly>
         ),
+        render: (item) => <ResultLinks jobs={[item]} />,
+        width: '64px',
+      },
+      {
+        name: i18n.translate('xpack.ml.jobsList.actionsLabel', {
+          defaultMessage: 'Actions',
+        }),
         actions: actionsMenuContent(
           this.props.showEditJobFlyout,
           this.props.showDatafeedChartFlyout,
@@ -339,7 +342,7 @@ export class JobsList extends Component {
           this.props.refreshJobs,
           this.props.showCreateAlertFlyout
         ),
-        width: '40px',
+        width: '5%',
       },
     ];