From 318fa14e1eb581b03fc786a73c3a0baee7f575e6 Mon Sep 17 00:00:00 2001
From: pgayvallet <pierre.gayvallet@elastic.co>
Date: Tue, 25 Feb 2020 11:49:00 +0100
Subject: [PATCH] use /internal prefix for migrate endpoint

---
 .../src/kbn_client/kbn_client_saved_objects.ts     |  2 +-
 packages/kbn-pm/dist/index.js                      |  2 +-
 src/core/server/saved_objects/routes/index.ts      |  5 ++++-
 .../routes/integration_tests/import.test.ts        | 14 +++++++-------
 4 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/packages/kbn-dev-utils/src/kbn_client/kbn_client_saved_objects.ts b/packages/kbn-dev-utils/src/kbn_client/kbn_client_saved_objects.ts
index bb87ff662b3c1..e671061b34352 100644
--- a/packages/kbn-dev-utils/src/kbn_client/kbn_client_saved_objects.ts
+++ b/packages/kbn-dev-utils/src/kbn_client/kbn_client_saved_objects.ts
@@ -73,7 +73,7 @@ export class KbnClientSavedObjects {
 
     return await this.requester.request<MigrateResponse>({
       description: 'migrate saved objects',
-      path: uriencode`/api/saved_objects/_migrate`,
+      path: uriencode`/internal/saved_objects/_migrate`,
       method: 'POST',
       body: {},
     });
diff --git a/packages/kbn-pm/dist/index.js b/packages/kbn-pm/dist/index.js
index b3e09e53f532b..fe0491870e4bd 100644
--- a/packages/kbn-pm/dist/index.js
+++ b/packages/kbn-pm/dist/index.js
@@ -43791,7 +43791,7 @@ class KbnClientSavedObjects {
         this.log.debug('Migrating saved objects');
         return await this.requester.request({
             description: 'migrate saved objects',
-            path: kbn_client_requester_1.uriencode `/api/saved_objects/_migrate`,
+            path: kbn_client_requester_1.uriencode `/internal/saved_objects/_migrate`,
             method: 'POST',
             body: {},
         });
diff --git a/src/core/server/saved_objects/routes/index.ts b/src/core/server/saved_objects/routes/index.ts
index b8cad1744f28c..0afa24b18760b 100644
--- a/src/core/server/saved_objects/routes/index.ts
+++ b/src/core/server/saved_objects/routes/index.ts
@@ -62,5 +62,8 @@ export function registerRoutes({
   registerExportRoute(router, config, importableExportableTypes);
   registerImportRoute(router, config, importableExportableTypes);
   registerResolveImportErrorsRoute(router, config, importableExportableTypes);
-  registerMigrateRoute(router, migratorPromise);
+
+  const internalRouter = http.createRouter('/internal/saved_objects/');
+
+  registerMigrateRoute(internalRouter, migratorPromise);
 }
diff --git a/src/core/server/saved_objects/routes/integration_tests/import.test.ts b/src/core/server/saved_objects/routes/integration_tests/import.test.ts
index 2c8d568b750c6..954e6d9e4831a 100644
--- a/src/core/server/saved_objects/routes/integration_tests/import.test.ts
+++ b/src/core/server/saved_objects/routes/integration_tests/import.test.ts
@@ -32,7 +32,7 @@ const config = {
   maxImportExportSize: 10000,
 } as SavedObjectConfig;
 
-describe('POST /api/saved_objects/_import', () => {
+describe('POST /internal/saved_objects/_import', () => {
   let server: setupServerReturn['server'];
   let httpSetup: setupServerReturn['httpSetup'];
   let handlerContext: setupServerReturn['handlerContext'];
@@ -51,7 +51,7 @@ describe('POST /api/saved_objects/_import', () => {
 
     savedObjectsClient.find.mockResolvedValue(emptyResponse);
 
-    const router = httpSetup.createRouter('/api/saved_objects/');
+    const router = httpSetup.createRouter('/internal/saved_objects/');
     registerImportRoute(router, config, allowedTypes);
 
     await server.start();
@@ -63,7 +63,7 @@ describe('POST /api/saved_objects/_import', () => {
 
   it('formats successful response', async () => {
     const result = await supertest(httpSetup.server.listener)
-      .post('/api/saved_objects/_import')
+      .post('/internal/saved_objects/_import')
       .set('content-Type', 'multipart/form-data; boundary=BOUNDARY')
       .send(
         [
@@ -99,7 +99,7 @@ describe('POST /api/saved_objects/_import', () => {
     });
 
     const result = await supertest(httpSetup.server.listener)
-      .post('/api/saved_objects/_import')
+      .post('/internal/saved_objects/_import')
       .set('content-Type', 'multipart/form-data; boundary=EXAMPLE')
       .send(
         [
@@ -148,7 +148,7 @@ describe('POST /api/saved_objects/_import', () => {
     });
 
     const result = await supertest(httpSetup.server.listener)
-      .post('/api/saved_objects/_import')
+      .post('/internal/saved_objects/_import')
       .set('content-Type', 'multipart/form-data; boundary=EXAMPLE')
       .send(
         [
@@ -199,7 +199,7 @@ describe('POST /api/saved_objects/_import', () => {
     });
 
     const result = await supertest(httpSetup.server.listener)
-      .post('/api/saved_objects/_import')
+      .post('/internal/saved_objects/_import')
       .set('content-Type', 'multipart/form-data; boundary=EXAMPLE')
       .send(
         [
@@ -249,7 +249,7 @@ describe('POST /api/saved_objects/_import', () => {
     });
 
     const result = await supertest(httpSetup.server.listener)
-      .post('/api/saved_objects/_import')
+      .post('/internal/saved_objects/_import')
       .set('content-Type', 'multipart/form-data; boundary=EXAMPLE')
       .send(
         [