Refactor schema

elastic · Mar 17, 2020 · 2a831fc · 2a831fc
1 parent b1ea620
commit 2a831fc
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts
@@ -39,21 +39,20 @@ export const UserSchema = schema.object({
   username: schema.string(),
 });
 
-export const EntityInformationSchema = schema.object({
+const EntityInformationSchemaProps = {
   createdAt: schema.string(),
   createdBy: UserSchema,
   updatedAt: schema.nullable(schema.string()),
   updatedBy: schema.nullable(UserSchema),
-});
+};
+
+export const EntityInformationSchema = schema.object(EntityInformationSchemaProps);
 
 export const CommentSchema = schema.object({
   commentId: schema.string(),
   comment: schema.string(),
   version: schema.maybe(schema.string()),
-  createdAt: schema.string(),
-  createdBy: UserSchema,
-  updatedAt: schema.nullable(schema.string()),
-  updatedBy: schema.nullable(UserSchema),
+  ...EntityInformationSchemaProps,
 });
 
 export const ExecutorAction = schema.oneOf([
@@ -67,8 +66,5 @@ export const ParamsSchema = schema.object({
   comments: schema.maybe(schema.arrayOf(CommentSchema)),
   description: schema.maybe(schema.string()),
   incidentId: schema.nullable(schema.string()),
-  createdAt: schema.string(),
-  createdBy: UserSchema,
-  updatedAt: schema.nullable(schema.string()),
-  updatedBy: schema.nullable(UserSchema),
+  ...EntityInformationSchemaProps,
 });