From 1df458d2d605f5a3281c3b18bda9f433d41a7c05 Mon Sep 17 00:00:00 2001 From: Tim Sullivan Date: Fri, 4 Oct 2024 14:00:57 -0700 Subject: [PATCH] [Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation (#193798) A variable for the page height was not being calculated correctly when the Kibana chrome is invisible. This PR fixes the issue by adding `px` as a unit to a variable used as input in the calculation. Unblocks: https://github.com/elastic/kibana/pull/193647 ## Testing It will help to test within the https://github.com/elastic/kibana/pull/193647 PR branch. The following screenshots show the before and after effects of having this fix: **before** ![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea) **after** ![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5) Co-authored-by: Elastic Machine Co-authored-by: Marco Vettorello --- src/core/public/styles/rendering/_base.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/public/styles/rendering/_base.scss b/src/core/public/styles/rendering/_base.scss index 1bcfaab71ea17..259115f6a526a 100644 --- a/src/core/public/styles/rendering/_base.scss +++ b/src/core/public/styles/rendering/_base.scss @@ -67,7 +67,8 @@ } .kbnBody--chromeHidden { - --euiFixedHeadersOffset: 0; + // stylelint-disable-next-line length-zero-no-unit + --euiFixedHeadersOffset: 0px; &.kbnBody--hasHeaderBanner { --euiFixedHeadersOffset: var(--kbnHeaderBannerHeight);