From f31b56afe2fa7127bb7948626576d4e678444e2d Mon Sep 17 00:00:00 2001 From: Philippe Oberti Date: Tue, 19 Dec 2023 11:04:51 -0600 Subject: [PATCH 01/16] [Security Solution] - skipping failing Cypress tests (#173642) --- .../cypress/e2e/investigations/alerts/alerts_details.cy.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_details.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_details.cy.ts index 7e5e19b464c4a..0f24575d8a2a2 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_details.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_details.cy.ts @@ -82,7 +82,7 @@ describe('Alert details flyout', { tags: ['@ess', '@serverless'] }, () => { cy.task('esArchiverUnload', 'unmapped_fields'); }); - it('should display user and system defined highlighted fields', () => { + it.skip('should display user and system defined highlighted fields', () => { cy.get(SUMMARY_VIEW) .should('be.visible') .and('contain.text', 'event.kind') @@ -161,7 +161,7 @@ describe('Alert details flyout', { tags: ['@ess', '@serverless'] }, () => { cy.url().should('not.include', 'eventFlyout='); }); - it('should open the alert flyout when the page is refreshed', () => { + it.skip('should open the alert flyout when the page is refreshed', () => { cy.get(OVERVIEW_RULE).should('be.visible'); cy.reload(); cy.get(OVERVIEW_RULE).should('be.visible'); @@ -172,7 +172,7 @@ describe('Alert details flyout', { tags: ['@ess', '@serverless'] }, () => { cy.get(COPY_ALERT_FLYOUT_LINK).should('be.visible'); }); - it('should have the `kibana.alert.url` field set', () => { + it.skip('should have the `kibana.alert.url` field set', () => { openTable(); filterBy('kibana.alert.url'); cy.get('[data-test-subj="formatted-field-kibana.alert.url"]').should( From 4ae07aa0d0e79b869218c71dac0ed7afa69736f8 Mon Sep 17 00:00:00 2001 From: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Date: Tue, 19 Dec 2023 12:05:17 -0500 Subject: [PATCH 02/16] [Security Solution] Skip flaky suites (#173667) ## Summary Skip suites failing in Serverless. Will also backport to 8.12. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --- .../cypress/e2e/artifacts/artifacts_mocked_data.cy.ts | 3 ++- .../security_solution_endpoint/apps/endpoint/endpoint_list.ts | 3 ++- .../apps/integrations/policy_details.ts | 3 ++- .../apis/endpoint_response_actions/execute.ts | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/artifacts/artifacts_mocked_data.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/artifacts/artifacts_mocked_data.cy.ts index e7f32820c00d7..55a1035ca8969 100644 --- a/x-pack/plugins/security_solution/public/management/cypress/e2e/artifacts/artifacts_mocked_data.cy.ts +++ b/x-pack/plugins/security_solution/public/management/cypress/e2e/artifacts/artifacts_mocked_data.cy.ts @@ -31,7 +31,8 @@ const loginWithoutAccess = (url: string) => { loadPage(url); }; -describe('Artifacts pages', { tags: ['@ess', '@serverless'] }, () => { +// Flaky: https://github.com/elastic/kibana/issues/171168 +describe.skip('Artifacts pages', { tags: ['@ess', '@serverless'] }, () => { let endpointData: ReturnTypeFromChainable | undefined; before(() => { diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts index f1edd7a45800c..0f65111b81e5b 100644 --- a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts +++ b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts @@ -85,7 +85,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { return tableData; }; - describe('endpoint list', function () { + // Flaky: https://github.com/elastic/kibana/issues/170357 + describe.skip('endpoint list', function () { targetTags(this, ['@ess', '@serverless']); let indexedData: IndexedHostsAndAlertsResponse; diff --git a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts index b48c64b5e9dd4..efa7e6e505780 100644 --- a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts +++ b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts @@ -28,7 +28,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { const endpointTestResources = getService('endpointTestResources'); const retry = getService('retry'); - describe('When on the Endpoint Policy Details Page', function () { + // Flaky: https://github.com/elastic/kibana/issues/171653 + describe.skip('When on the Endpoint Policy Details Page', function () { targetTags(this, ['@ess', '@serverless']); let indexedData: IndexedHostsAndAlertsResponse; diff --git a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts index f904539dae231..b11b83df5a235 100644 --- a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts +++ b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts @@ -16,7 +16,8 @@ export default function ({ getService }: FtrProviderContext) { const supertestWithoutAuth = getService('supertestWithoutAuth'); const endpointTestResources = getService('endpointTestResources'); - describe('Endpoint `execute` response action', function () { + // Flaky: https://github.com/elastic/kibana/issues/171666 + describe.skip('Endpoint `execute` response action', function () { targetTags(this, ['@ess', '@serverless']); let indexedData: IndexedHostsAndAlertsResponse; From 06fe6ec9c305cf038c70f7dcae30fbbff8f36774 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:17:24 +0000 Subject: [PATCH 03/16] skip flaky suite (#171654) --- .../apps/integrations/policy_details.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts index efa7e6e505780..c415d3b9d8505 100644 --- a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts +++ b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts @@ -29,6 +29,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { const retry = getService('retry'); // Flaky: https://github.com/elastic/kibana/issues/171653 + // FLAKY: https://github.com/elastic/kibana/issues/171654 describe.skip('When on the Endpoint Policy Details Page', function () { targetTags(this, ['@ess', '@serverless']); From f543158278e53e25244104ea5f8e964c04c314a5 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:20:21 +0000 Subject: [PATCH 04/16] skip flaky suite (#171653) --- .../apps/integrations/policy_details.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts index c415d3b9d8505..a2b1feaabd7cd 100644 --- a/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts +++ b/x-pack/test/security_solution_endpoint/apps/integrations/policy_details.ts @@ -28,7 +28,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { const endpointTestResources = getService('endpointTestResources'); const retry = getService('retry'); - // Flaky: https://github.com/elastic/kibana/issues/171653 + // FLAKY: https://github.com/elastic/kibana/issues/171653 // FLAKY: https://github.com/elastic/kibana/issues/171654 describe.skip('When on the Endpoint Policy Details Page', function () { targetTags(this, ['@ess', '@serverless']); From 2dce69eebc30ef849d3e8df61be8da73844eddf7 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:22:49 +0000 Subject: [PATCH 05/16] skip flaky suite (#171666) --- .../apis/endpoint_response_actions/execute.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts index b11b83df5a235..1da78f53b3627 100644 --- a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts +++ b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts @@ -16,7 +16,7 @@ export default function ({ getService }: FtrProviderContext) { const supertestWithoutAuth = getService('supertestWithoutAuth'); const endpointTestResources = getService('endpointTestResources'); - // Flaky: https://github.com/elastic/kibana/issues/171666 + // FLAKY: https://github.com/elastic/kibana/issues/171666 describe.skip('Endpoint `execute` response action', function () { targetTags(this, ['@ess', '@serverless']); From 80b755ad6511aa19ea1f4e4bb618c52dcf13ea6c Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:25:41 +0000 Subject: [PATCH 06/16] skip flaky suite (#171667) --- .../apis/endpoint_response_actions/execute.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts index 1da78f53b3627..401ff25fee620 100644 --- a/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts +++ b/x-pack/test/security_solution_endpoint_api_int/apis/endpoint_response_actions/execute.ts @@ -17,6 +17,7 @@ export default function ({ getService }: FtrProviderContext) { const endpointTestResources = getService('endpointTestResources'); // FLAKY: https://github.com/elastic/kibana/issues/171666 + // FLAKY: https://github.com/elastic/kibana/issues/171667 describe.skip('Endpoint `execute` response action', function () { targetTags(this, ['@ess', '@serverless']); From 304b4a35be889eacb78d0230fab5495a6a7de5b7 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:27:56 +0000 Subject: [PATCH 07/16] skip flaky suite (#173670) --- .../security_solution_endpoint/apps/endpoint/endpoint_list.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts index 0f65111b81e5b..d0267b3eac5ac 100644 --- a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts +++ b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts @@ -86,6 +86,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { }; // Flaky: https://github.com/elastic/kibana/issues/170357 + // FLAKY: https://github.com/elastic/kibana/issues/173670 describe.skip('endpoint list', function () { targetTags(this, ['@ess', '@serverless']); From 4b8edd785ddc2e0dd1d310b96187aee15686fb75 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:29:02 +0000 Subject: [PATCH 08/16] skip flaky suite (#170357) --- .../security_solution_endpoint/apps/endpoint/endpoint_list.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts index d0267b3eac5ac..e4d9b91e579b7 100644 --- a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts +++ b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts @@ -85,7 +85,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { return tableData; }; - // Flaky: https://github.com/elastic/kibana/issues/170357 + // FLAKY: https://github.com/elastic/kibana/issues/170357 // FLAKY: https://github.com/elastic/kibana/issues/173670 describe.skip('endpoint list', function () { targetTags(this, ['@ess', '@serverless']); From 3d4aaba1956f40fcab38d919ef7121fa3ff3c83c Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:33:01 +0000 Subject: [PATCH 09/16] skip flaky suite (#168904) --- .../ftr/cloud_security_posture/compliance_dashboard.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/test_serverless/functional/test_suites/security/ftr/cloud_security_posture/compliance_dashboard.ts b/x-pack/test_serverless/functional/test_suites/security/ftr/cloud_security_posture/compliance_dashboard.ts index 54fa5a725e29a..6a6734b8f3fe3 100644 --- a/x-pack/test_serverless/functional/test_suites/security/ftr/cloud_security_posture/compliance_dashboard.ts +++ b/x-pack/test_serverless/functional/test_suites/security/ftr/cloud_security_posture/compliance_dashboard.ts @@ -56,7 +56,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await pageObjects.svlCommonPage.forceLogout(); }); - describe('Kubernetes Dashboard', () => { + // FLAKY: https://github.com/elastic/kibana/issues/168904 + describe.skip('Kubernetes Dashboard', () => { it('displays accurate summary compliance score', async () => { const scoreElement = await dashboard.getKubernetesComplianceScore(); From 6825c02faf409a01404729e1ba63453a3cf93aa6 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:40:55 +0000 Subject: [PATCH 10/16] skip flaky suite (#173597) --- .../e2e/investigations/alerts/changing_alert_status.cy.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts index e8426c4599fb5..8a49b4eb02065 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts @@ -158,6 +158,7 @@ describe('Changing alert status', { tags: ['@ess', '@brokenInServerless'] }, () }); }); }); + // FLAKY: https://github.com/elastic/kibana/issues/173597 context.skip('Closing alerts', () => { beforeEach(() => { login(); From 3fbf0ddf1dc6feac3b407b0b7f3795b9ebf913ca Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:42:56 +0000 Subject: [PATCH 11/16] skip flaky suite (#173586) --- test/functional/apps/discover/group1/_discover_histogram.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/functional/apps/discover/group1/_discover_histogram.ts b/test/functional/apps/discover/group1/_discover_histogram.ts index 43f39b417864c..bdaf14fca96e4 100644 --- a/test/functional/apps/discover/group1/_discover_histogram.ts +++ b/test/functional/apps/discover/group1/_discover_histogram.ts @@ -33,7 +33,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const log = getService('log'); const queryBar = getService('queryBar'); - describe('discover histogram', function describeIndexTests() { + // FLAKY: https://github.com/elastic/kibana/issues/173586 + describe.skip('discover histogram', function describeIndexTests() { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.load('test/functional/fixtures/es_archiver/long_window_logstash'); From e2c8db12d02e867037833a830f004f69088245a9 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:44:08 +0000 Subject: [PATCH 12/16] skip flaky suite (#173625) --- .../apps/management/data_views/_data_view_create_delete.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/functional/apps/management/data_views/_data_view_create_delete.ts b/test/functional/apps/management/data_views/_data_view_create_delete.ts index e3bc2240887ad..245ac88606b50 100644 --- a/test/functional/apps/management/data_views/_data_view_create_delete.ts +++ b/test/functional/apps/management/data_views/_data_view_create_delete.ts @@ -187,7 +187,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - describe('index pattern edit', function () { + // FLAKY: https://github.com/elastic/kibana/issues/173625 + describe.skip('index pattern edit', function () { it('should update field list', async function () { await PageObjects.settings.editIndexPattern( 'kibana_sample_data_flights', From 1e1d959010c38d877bab0edc9e951263d2a96702 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 17:46:55 +0000 Subject: [PATCH 13/16] skip flaky suite (#173653) --- .../test_suites/observability/burn_rate_rule/burn_rate_rule.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/test_serverless/api_integration/test_suites/observability/burn_rate_rule/burn_rate_rule.ts b/x-pack/test_serverless/api_integration/test_suites/observability/burn_rate_rule/burn_rate_rule.ts index 7d863d6cdbc66..0d2f3a5958d47 100644 --- a/x-pack/test_serverless/api_integration/test_suites/observability/burn_rate_rule/burn_rate_rule.ts +++ b/x-pack/test_serverless/api_integration/test_suites/observability/burn_rate_rule/burn_rate_rule.ts @@ -70,7 +70,8 @@ export default function ({ getService }: FtrProviderContext) { await cleanup({ esClient, logger }); }); - describe('Rule creation', () => { + // FLAKY: https://github.com/elastic/kibana/issues/173653 + describe.skip('Rule creation', () => { it('creates rule successfully', async () => { actionId = await alertingApi.createIndexConnector({ name: 'Index Connector: Slo Burn rate API test', From b26bd788e794717c514a998a722c5e5150643b4d Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 18:48:09 +0000 Subject: [PATCH 14/16] skip flaky suite (#173681) --- .../apps/integrations/artifact_entries_list.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts b/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts index 802cbf8be16fc..9dd9b319071a4 100644 --- a/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts +++ b/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts @@ -51,7 +51,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { .set('kbn-xsrf', 'true'); }; - describe('For each artifact list under management', function () { + // FLAKY: https://github.com/elastic/kibana/issues/173681 + describe.skip('For each artifact list under management', function () { targetTags(this, ['@ess', '@serverless']); this.timeout(60_000 * 5); From 182b2c95c0fe3e714ffca0e4ab8c2b76f81604ed Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 19 Dec 2023 18:49:46 +0000 Subject: [PATCH 15/16] skip flaky suite (#173682) --- .../apps/integrations/artifact_entries_list.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts b/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts index 9dd9b319071a4..5746a9cc06a25 100644 --- a/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts +++ b/x-pack/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts @@ -52,6 +52,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { }; // FLAKY: https://github.com/elastic/kibana/issues/173681 + // FLAKY: https://github.com/elastic/kibana/issues/173682 describe.skip('For each artifact list under management', function () { targetTags(this, ['@ess', '@serverless']); From dd765ab84c98ddd823dc48152c36bc7ee6a1bd81 Mon Sep 17 00:00:00 2001 From: Robert Austin Date: Tue, 19 Dec 2023 14:13:12 -0500 Subject: [PATCH 16/16] Allow members of @security-solution-test-skippers to use `/skip` comments on failed test issues (#173430) ## Summary After a PR is merged, CI runs all the tests on `main`. If one fails, a github issue with the label `failed-test` is created. If you comment `/skip` on the issue then a workflow action will skip the test directly on the failing branches. This workflow can only be used by contributors who have `admin` access to Kibana, OR to people who are on an allow-list of elastic teams. The list of teams allowed is `appex-qa`. This PR adds another team to the list: @elastic/security-solution-test-skippers This team was just created to allow a small list of Security Solution contributors the ability to use this workflow. Allowing a few of us access to this workflow will allow Security to triage our own test by writing `/skip` comments. ### Without this PR we have to: Without this PR we have to do a bunch of stuff to skip our own flaky tests: 1. Manually edit the files to create a PR on all affected branches. 2. Create PRs using the web app. 3. Get a second developer to approve the PR. 4. Wait for CI. 5. Merge the PR. This process is slow because of manual steps, and because CI must run before we can skip the test. At a minimum we should expect that process to take as long as CI takes (e.g. 90 minutes.) But the PRs that are meant to skip tests may also in turn be blocked by flaky tests. It also requires coordination from 2 people to make and approve the PR. ### Code references [skip-failed-test.yml](https://github.com/elastic/kibana/blob/main/.github/workflows/skip-failed-test.yml#L25-L30) is where the workflow is defined [Docs on the syntax for workflows.](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses) [permission-check/index.ts](https://github.com/elastic/kibana-github-actions/blob/main/permission-check/index.ts#L23-L26) is where the permission check is implemented. Users need to have: * either the right permission level * or be a member of the team ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Gloria Hornero --- .github/workflows/skip-failed-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/skip-failed-test.yml b/.github/workflows/skip-failed-test.yml index 9ac9485709bd6..039d0ab8aa8b4 100644 --- a/.github/workflows/skip-failed-test.yml +++ b/.github/workflows/skip-failed-test.yml @@ -26,7 +26,7 @@ jobs: uses: ./actions/permission-check with: permission: admin - teams: appex-qa + teams: appex-qa, security-solution-test-skippers token: ${{secrets.KIBANAMACHINE_TOKEN}} - name: Checkout kibana-operations