[APM] Add feature flag for APM table search (#174750)

This adds a feature flag for table search (#127036). The feature itself is being worked on in #174490
elastic · Jan 12, 2024 · 0dd4e37 · 0dd4e37
1 parent 7b69611
commit 0dd4e37
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 0 deletions.
diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc
@@ -433,6 +433,9 @@ Set the default environment for the APM app. When left empty, data from all envi
 [[observability-apm-enable-profiling]]`observability:apmEnableProfilingIntegration`::
 Enable the Universal Profiling integration in APM.
 
+[[observability-apm-enable-table-search-bar]]`observability:apmEnableTableSearchBar`::
+beta:[] Enables faster searching in APM tables by adding a handy search bar with live filtering. Available for the following tables: Services, Transactions, and Errors.
+
 [[observability-enable-aws-lambda-metrics]]`observability:enableAwsLambdaMetrics`::
 preview:[] Display Amazon Lambda metrics in the service metrics tab.
 

diff --git a/packages/kbn-management/settings/setting_ids/index.ts b/packages/kbn-management/settings/setting_ids/index.ts
@@ -133,6 +133,8 @@ export const OBSERVABILITY_APM_ENABLE_CONTINUOUS_ROLLUPS_ID =
 export const OBSERVABILITY_APM_ENABLE_PROFILING_INTEGRATION_ID =
   'observability:apmEnableProfilingIntegration';
 
+export const OBSERVABILITY_APM_ENABLE_TABLE_SEARCH_BAR = 'observability:apmEnableTableSearchBar';
+
 // Reporting settings
 export const XPACK_REPORTING_CUSTOM_PDF_LOGO_ID = 'xpackReporting:customPdfLogo';
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -449,6 +449,10 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
+  'observability:apmEnableTableSearchBar': {
+    type: 'boolean',
+    _meta: { description: 'Non-default value of setting.' },
+  },
   'observability:apmAWSLambdaPriceFactor': {
     type: 'text',
     _meta: { description: 'Non-default value of setting.' },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -48,6 +48,7 @@ export interface UsageStats {
   'observability:enableInfrastructureHostsView': boolean;
   'observability:enableInfrastructureProfilingIntegration': boolean;
   'observability:apmAgentExplorerView': boolean;
+  'observability:apmEnableTableSearchBar': boolean;
   'visualization:heatmap:maxBuckets': number;
   'visualization:colorMapping': string;
   'visualization:useLegacyTimeAxis': boolean;

diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -9863,6 +9863,12 @@
             "description": "Non-default value of setting."
           }
         },
+        "observability:apmEnableTableSearchBar": {
+          "type": "boolean",
+          "_meta": {
+            "description": "Non-default value of setting."
+          }
+        },
         "observability:apmAWSLambdaPriceFactor": {
           "type": "text",
           "_meta": {

diff --git a/x-pack/plugins/apm/public/components/app/settings/general_settings/index.tsx b/x-pack/plugins/apm/public/components/app/settings/general_settings/index.tsx
@@ -20,6 +20,7 @@ import {
   apmEnableContinuousRollups,
   enableAgentExplorerView,
   apmEnableProfilingIntegration,
+  apmEnableTableSearchBar,
 } from '@kbn/observability-plugin/common';
 import { isEmpty } from 'lodash';
 import React from 'react';
@@ -41,6 +42,7 @@ const apmSettingsKeys = [
   apmEnableServiceMetrics,
   apmEnableContinuousRollups,
   enableAgentExplorerView,
+  apmEnableTableSearchBar,
   apmEnableProfilingIntegration,
 ];
 

diff --git a/x-pack/plugins/observability/common/index.ts b/x-pack/plugins/observability/common/index.ts
@@ -35,6 +35,7 @@ export {
   enableInfrastructureProfilingIntegration,
   enableAwsLambdaMetrics,
   enableAgentExplorerView,
+  apmEnableTableSearchBar,
   apmAWSLambdaPriceFactor,
   apmAWSLambdaRequestCostPerMillion,
   apmEnableServiceMetrics,

diff --git a/x-pack/plugins/observability/common/ui_settings_keys.ts b/x-pack/plugins/observability/common/ui_settings_keys.ts
@@ -21,6 +21,7 @@ export const enableInfrastructureProfilingIntegration =
   'observability:enableInfrastructureProfilingIntegration';
 export const enableAwsLambdaMetrics = 'observability:enableAwsLambdaMetrics';
 export const enableAgentExplorerView = 'observability:apmAgentExplorerView';
+export const apmEnableTableSearchBar = 'observability:apmEnableTableSearchBar';
 export const apmAWSLambdaPriceFactor = 'observability:apmAWSLambdaPriceFactor';
 export const apmAWSLambdaRequestCostPerMillion = 'observability:apmAWSLambdaRequestCostPerMillion';
 export const enableCriticalPath = 'observability:apmEnableCriticalPath';

diff --git a/x-pack/plugins/observability/public/index.ts b/x-pack/plugins/observability/public/index.ts
@@ -40,6 +40,7 @@ export {
   apmServiceGroupMaxNumberOfServices,
   enableInfrastructureHostsView,
   enableAgentExplorerView,
+  apmEnableTableSearchBar,
 } from '../common/ui_settings_keys';
 export {
   alertsLocatorID,

diff --git a/x-pack/plugins/observability/server/ui_settings.ts b/x-pack/plugins/observability/server/ui_settings.ts
@@ -20,6 +20,7 @@ import {
   apmTraceExplorerTab,
   apmLabsButton,
   enableAgentExplorerView,
+  apmEnableTableSearchBar,
   enableAwsLambdaMetrics,
   apmAWSLambdaPriceFactor,
   apmAWSLambdaRequestCostPerMillion,
@@ -284,6 +285,23 @@ export const uiSettings: Record<string, UiSettings> = {
     requiresPageReload: true,
     type: 'boolean',
   },
+  [apmEnableTableSearchBar]: {
+    category: [observabilityFeatureId],
+    name: i18n.translate('xpack.observability.apmEnableTableSearchBar', {
+      defaultMessage: 'Instant table search',
+    }),
+    description: i18n.translate('xpack.observability.apmEnableTableSearchBarDescription', {
+      defaultMessage:
+        '{betaLabel} Enables faster searching in APM tables by adding a handy search bar with live filtering. Available for the following tables: Services, Transactions and Errors',
+      values: {
+        betaLabel: `<em>[${betaLabel}]</em>`,
+      },
+    }),
+    schema: schema.boolean(),
+    value: false,
+    requiresPageReload: false,
+    type: 'boolean',
+  },
   [apmAWSLambdaPriceFactor]: {
     category: [observabilityFeatureId],
     name: i18n.translate('xpack.observability.apmAWSLambdaPricePerGbSeconds', {