From 06aed736c2d7942df9e28d7d86a95e583f3d355a Mon Sep 17 00:00:00 2001
From: Tim Sullivan <tsullivan@users.noreply.github.com>
Date: Mon, 9 Mar 2020 10:04:08 -0700
Subject: [PATCH] [Reporting] Improve the page exit error messages (#59351)
 (#59578)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../browsers/chromium/driver_factory/index.ts | 39 ++++++++++++++-----
 1 file changed, 29 insertions(+), 10 deletions(-)

diff --git a/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts b/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
index 553a0234e4fb2..f90f2c7aee395 100644
--- a/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
+++ b/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
@@ -3,27 +3,28 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
+import { i18n } from '@kbn/i18n';
+import del from 'del';
 import fs from 'fs';
 import os from 'os';
 import path from 'path';
 import {
   Browser,
-  Page,
-  LaunchOptions,
   ConsoleMessage,
+  LaunchOptions,
+  Page,
   Request as PuppeteerRequest,
 } from 'puppeteer';
-import del from 'del';
 import * as Rx from 'rxjs';
-import { ignoreElements, map, mergeMap, tap } from 'rxjs/operators';
 import { InnerSubscriber } from 'rxjs/internal/InnerSubscriber';
-
+import { ignoreElements, map, mergeMap, tap } from 'rxjs/operators';
 import { BrowserConfig, CaptureConfig } from '../../../../types';
 import { LevelLogger as Logger } from '../../../lib/level_logger';
-import { HeadlessChromiumDriver } from '../driver';
 import { safeChildProcess } from '../../safe_child_process';
-import { puppeteerLaunch } from '../puppeteer';
+import { HeadlessChromiumDriver } from '../driver';
 import { getChromeLogLocation } from '../paths';
+import { puppeteerLaunch } from '../puppeteer';
 import { args } from './args';
 
 type binaryPath = string;
@@ -216,17 +217,35 @@ export class HeadlessChromiumDriverFactory {
   }
 
   getPageExit(browser: Browser, page: Page) {
-    const pageError$ = Rx.fromEvent<Error>(page, 'error').pipe(mergeMap(err => Rx.throwError(err)));
+    const pageError$ = Rx.fromEvent<Error>(page, 'error').pipe(
+      mergeMap(err => {
+        return Rx.throwError(
+          i18n.translate('xpack.reporting.browsers.chromium.errorDetected', {
+            defaultMessage: 'Reporting detected an error: {err}',
+            values: { err: err.toString() },
+          })
+        );
+      })
+    );
 
     const uncaughtExceptionPageError$ = Rx.fromEvent<Error>(page, 'pageerror').pipe(
-      mergeMap(err => Rx.throwError(err))
+      mergeMap(err => {
+        return Rx.throwError(
+          i18n.translate('xpack.reporting.browsers.chromium.pageErrorDetected', {
+            defaultMessage: `Reporting detected an error on the page: {err}`,
+            values: { err: err.toString() },
+          })
+        );
+      })
     );
 
     const browserDisconnect$ = Rx.fromEvent(browser, 'disconnected').pipe(
       mergeMap(() =>
         Rx.throwError(
           new Error(
-            `Puppeteer was disconnected from the Chromium instance! Chromium has closed or crashed.`
+            i18n.translate('xpack.reporting.browsers.chromium.chromiumClosed', {
+              defaultMessage: `Reporting detected that Chromium has closed.`,
+            })
           )
         )
       )