Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memcached] Add dimension fields to stats datastream #6926

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

What does this PR do?

Add dimension fields for stats datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

#6925

Screenshots

@agithomas agithomas mentioned this pull request Jul 12, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-12T10:51:17.778+0000

  • Duration: 15 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@agithomas agithomas changed the title Add dimension fields to stats datastream [memcached] Add dimension fields to stats datastream Jul 13, 2023
@agithomas agithomas marked this pull request as ready for review July 17, 2023 05:12
@agithomas agithomas requested a review from a team as a code owner July 17, 2023 05:12
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 5bed897 into elastic:main Jul 17, 2023
@elasticmachine
Copy link

Package memcached - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=memcached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants