-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Enable TSDB for some metric datasets - Part 1 #6782
Conversation
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
🌐 Coverage report
|
For data_stream vpn, the dimension fileds are define here. The dimension fields are missing in the sample event. Are they not needed in the sample event? |
@lalit-satapathy Not every dimension is present in every document. There were a few changes on the |
@elastic/obs-cloud-monitoring even dimension fields missing in elb_metrics sample events. Is that accidental, May be that should be addressed separately? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for TSDB release; except for the outdated sample events issue highlighted before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to allow releasing TSDB but I'd like to look into the sample events more, as they are a valuable tool and I feel we need improvements in that area.
Package aws - 1.46.0 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Enable time series data streams for the metrics datasets:
Checklist
changelog.yml
file.Related issues
Relates to #6293.