Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM MQ Added metric type mappings #6468

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

What does this PR do?

Added metric_type related changes as beta release for IBM MQ package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@agithomas agithomas mentioned this pull request Jun 5, 2023
7 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T10:49:10.633+0000

  • Duration: 16 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (20/20) 💚 4.167
Lines 98.904% (451/456) 👍 13.582
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review June 6, 2023 08:50
@agithomas agithomas requested a review from a team as a code owner June 6, 2023 08:50
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit a918f67 into elastic:main Jun 7, 2023
@elasticmachine
Copy link

Package ibmmq - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=ibmmq

@agithomas agithomas mentioned this pull request Jun 8, 2023
7 tasks
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
* Added metric type mappings for numeric fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants