[AWS] Set dimensions fields of Billing, SQS and SNS data streams #6311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
aspacca
approved these changes
Jun 5, 2023
packages/aws/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.36.9" | |||
There was a problem hiding this comment.
nit: in #6365 we bumped minor version, here only patch one
why the difference? :)
|
Package aws - 1.38.4 containing this change is available at https://epr.elastic.co/search?package=aws |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add SQS dimensions. Signed-off-by: constanca-m <[email protected]> * Add SNS dimensions. Signed-off-by: constanca-m <[email protected]> * Add SNS dimensions. Signed-off-by: constanca-m <[email protected]> * Add Billing dimensions. Signed-off-by: constanca-m <[email protected]> * Update changelog. Signed-off-by: constanca-m <[email protected]> * Add 2 ecs dimension fields. Signed-off-by: constanca-m <[email protected]> * Remove cloud.availability_zone as dimension (not present) Signed-off-by: constanca-m <[email protected]> * Update md. Signed-off-by: constanca-m <[email protected]> --------- Signed-off-by: constanca-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set dimensions fields of Billing, SQS and SNS data streams.
Billing:
cloud.account.idandServiceName1work as a unique combination.SQS:
aws.dimensions.QueueNameandaws.sqs.queue.name. From my understanding, when one of them is available, the other is as well (they come from"cloudwatch:GetMetricData"), so only one of them was set as dimension (aws.dimensions.QueueName).SNS:
Regarding ECS fields, more info can be found here #5193 (comment).
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Refer to #6293.
Related issues
Relates to #6293.