Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric type mapping for Redis Info Datastream #5822

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Metric type mapping for Redis Info Datastream #5822

merged 2 commits into from
Apr 10, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Apr 7, 2023 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner April 7, 2023 12:55
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T16:16:20.457+0000

  • Duration: 14 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 66.667% (14/21) 👎 -33.333
Lines 94.186% (81/86) 👍 5.056
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Apr 8, 2023
Closed
16 tasks
ritalwar
ritalwar approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 57c04fc into elastic:main Apr 10, 2023
@elasticmachine
Copy link

Package redis - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
Integration:redis Redis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agithomas @elasticmachine @ritalwar @andrewkroh